Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp916008rdb; Fri, 22 Dec 2023 08:38:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFs+Rc2drKZINd8zEwMLOIzd8xwrRnNFuV0/kCLF/Yx/tpRJz9h1Ln4KIfL6VGh6f3xOdu5 X-Received: by 2002:a17:903:2682:b0:1d4:f1c:6378 with SMTP id jf2-20020a170903268200b001d40f1c6378mr1347987plb.27.1703263083743; Fri, 22 Dec 2023 08:38:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703263083; cv=none; d=google.com; s=arc-20160816; b=MlLrXznMC+e+JkEMmTmWvr4HkMPxB0MouZXVaOxGC3KfSaaeeHXvROWsi2v+Pneo2o 3bP0ylVeF1O9r137MD+JgwxfUUUnuByOEFThDjAbkBrN5H+J3fs9wxP3WyJWgfNnWGvH vVtabXT+8VUtdtEoIzFYAIU2ILvZzE5Oe+8RlwFqY5/EfPSjp2Yex0HDDKdgrlw3jTMC SJlmDIct8Mzs9sJgmm08KZy7m89KM8refbmKlpsmO7J/OP3yHYpHmtbjgy8/SgHfr/5F zv0CmC3+w8uwECuevuvU4ooxeD9We70Jg2FuJVsu0KRW+ITC1Zl2WIlDpTXnpV0bGp5S swnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=oGdL48dgFICsTL2OUbizMvlK9HMRdIJG2gL0WNBgzO8=; fh=XmidgA7Vj/OIXTPx2PV4CE0dFJUjRrD6Zcb9kp20om4=; b=GGBKbWg4v99WAeiPZBsDX4RRezIZAhhzHDlMeThrFdi5srjiTghubfkYesw8sSTz9Q WjEa5tS3fxHgSwLnv/DiKAOfoOEXlraFeAreh4nVZuiLOPuOCocvAiezc/2fIcBGGwcN YjjEhzfhE1pr+IPt2i4o/Ju4O6I+c6T+n8529KDOLvF+SGk3Upk7pKU3vcyW9VPosxBU VsPMaIQBUwePw6MGYvHU925a8CjZKIvMmBqpW36OVRveeMCRuhyGyOXiQw9qwkjNsES5 g39uTySOM1JPMwZyWE4DIjHqW11GzKvsT+FdDWt1Ng/n5iJ8evC7VBnnovnasf0jgiZw n/TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fO+SlFyu; spf=pass (google.com: domain of linux-kernel+bounces-9912-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9912-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bs125-20020a632883000000b0058556a636dbsi3389163pgb.434.2023.12.22.08.38.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 08:38:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9912-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fO+SlFyu; spf=pass (google.com: domain of linux-kernel+bounces-9912-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9912-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 91288B22369 for ; Fri, 22 Dec 2023 16:34:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 529D525570; Fri, 22 Dec 2023 16:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fO+SlFyu" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 191D024A1F for ; Fri, 22 Dec 2023 16:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703262869; x=1734798869; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Nwu0jTUTyUVExiakxdbtIQfJuL2c3K4kO9Pr5Ymd8sQ=; b=fO+SlFyuw72KMKXLr1jBPOOFt1KrQ92h2oI63KQbvLW1X+jun1ZjkNHi szX8UNjeO8IT8Tpy42j6fNJuX0Wa4YXkvkyasIVj81PPFYptSaOhislU0 i0QKyZB2qKYaXp8uyOYNpCAkIGSnfRt6+TQpo6xSk7suLe8B+r+foTZt0 dMUJvwxf036t6St0dOxwi2P6gQ/QUGYddtkCJbKykVK6pslRmyJB0eFfv ncvC0TGlqofvcl+xKRCCzAvD/bRH3mbkMnHu8aI1i+ntHvNaJiSnoRDQh ZL6ec6B0MdpmazGNb9u4GAtnw5YD09vwbVbD8Rz1O3F0YVHp2XyJgm4DR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10932"; a="395024981" X-IronPort-AV: E=Sophos;i="6.04,297,1695711600"; d="scan'208";a="395024981" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 08:34:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10932"; a="777082152" X-IronPort-AV: E=Sophos;i="6.04,297,1695711600"; d="scan'208";a="777082152" Received: from hassanfa-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.33.171]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 08:34:23 -0800 Received: by box.shutemov.name (Postfix, from userid 1000) id EC2FB10945B; Fri, 22 Dec 2023 19:34:20 +0300 (+03) Date: Fri, 22 Dec 2023 19:34:20 +0300 From: "Kirill A. Shutemov" To: Thomas Gleixner Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Adrian Hunter , Kuppuswamy Sathyanarayanan , Elena Reshetova , Jun Nakajima , Rick Edgecombe , Tom Lendacky , "Kalra, Ashish" , Sean Christopherson , "Huang, Kai" , Baoquan He , kexec@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Message-ID: <20231222163420.4mu5kmznfmsave6k@box.shutemov.name> References: <20231205004510.27164-1-kirill.shutemov@linux.intel.com> <20231205004510.27164-15-kirill.shutemov@linux.intel.com> <877clfmcpy.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877clfmcpy.ffs@tglx> On Fri, Dec 15, 2023 at 09:29:13PM +0100, Thomas Gleixner wrote: > So this waits and then does nothing if the wait fails. What's the point? > > ... > > > Do we really need this specific hackery or is there some similar > identity mapping muck which can be generalized? I've addressed all your feedback, but this gave me pause. Looks like none of kernel_ident_mapping_init() users frees memory on failure. Is it okay to get this part as is and I will follow up with patchset that fixes memory handling for all kernel_ident_mapping_init() users? -- Kiryl Shutsemau / Kirill A. Shutemov