Received-SPF: pass (google.com: domain of linux-kernel+bounces-9988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>, Lee Jones <lee@kernel.org>
Cc: fuyao <fuyao1697@cyg.com>, Chen-Yu Tsai <wens@csie.org>,
 Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org,
 linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
 Maxime Ripard <mripard@kernel.org>,
 maijianzhang <maijianzhang@allwinnertech.com>
Subject:
 Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number
Date: Fri, 22 Dec 2023 18:54:53 +0100
Message-ID: <4953611.0VBMTVartN@jernej-laptop>
In-Reply-To: <20231221152553.GM10102@google.com>
References:
 <YxmR5SPPY18O7LaG@google.com>
 <20231220115412.65bbc8c7@donnerap.manchester.arm.com>
 <20231221152553.GM10102@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Dne =C4=8Detrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a):
> On Wed, 20 Dec 2023, Andre Przywara wrote:
>=20
> > On Wed, 20 Dec 2023 15:23:17 +0800
> > fuyao <fuyao1697@cyg.com> wrote:
> >=20
> > Hi,
> >=20
> > > __platform_get_irq_byname determinies whether the interrupt
> > > number is 0 and returns EINVAL.
> >=20
> > can you please say what this fixes, exactly? Is something not working at
> > the moment? Can you please provide parts of the error message?
> >=20
> > And maybe expand the explanation a bit more? For instance mention that =
the
> > identifiers are used as IRQ resource numbers, where 0 is treated specia=
lly.
> >=20
> > Cheers,
> > Andre
> >=20
> > >=20
> > > Signed-off-by: fuyao <fuyao1697@cyg.com>
>=20
> You have to use your full real name as well.

Isn't that enough after
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3Dd4563201f33a022fc0353033d9dfeb1606a88330 ?

Best regards,
Jernej

>=20
> > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > > ---
> > >  include/linux/mfd/sun4i-gpadc.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >=20
> > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4=
i-gpadc.h
> > > index ea0ccf33a459..021f820f9d52 100644
> > > --- a/include/linux/mfd/sun4i-gpadc.h
> > > +++ b/include/linux/mfd/sun4i-gpadc.h
> > > @@ -81,8 +81,8 @@
> > >  #define SUN4I_GPADC_TEMP_DATA				0x20
> > >  #define SUN4I_GPADC_DATA				0x24
> > > =20
> > > -#define SUN4I_GPADC_IRQ_FIFO_DATA			0
> > > -#define SUN4I_GPADC_IRQ_TEMP_DATA			1
> > > +#define SUN4I_GPADC_IRQ_FIFO_DATA			1
> > > +#define SUN4I_GPADC_IRQ_TEMP_DATA			2
> > > =20
> > >  /* 10s delay before suspending the IP */
> > >  #define SUN4I_GPADC_AUTOSUSPEND_DELAY			10000
> >=20
>=20
>=20