Received-SPF: pass (google.com: domain of linux-kernel+bounces-10006-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 22 Dec 2023 10:57:54 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Coly Li <colyli@suse.de>
CC: Dan Williams <dan.j.williams@intel.com>, Jens Axboe <axboe@kernel.dk>,
	Xiao Ni <xni@redhat.com>, Geliang Tang <geliang.tang@suse.com>, "Hannes
 Reinecke" <hare@suse.de>, NeilBrown <neilb@suse.de>, Vishal L Verma
	<vishal.l.verma@intel.com>, <linux-block@vger.kernel.org>,
	<nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: Bug in commit aa511ff8218b ("badblocks: switch to the improved
 badblock handling
Message-ID: <6585dc32bebce_ab80829462@iweiny-mobl.notmuch>
References: <6585d5fda5183_9f731294b9@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6585d5fda5183_9f731294b9@iweiny-mobl.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cAH18dXARZ+fGkdQITwBNInJPOUMJ4hoqWpn8JB6eT9ihquQLkWhkC55eWrB?=
 =?us-ascii?Q?uSMjGMy9fs1SlxhsEXxp90EcqTNP1FLl/RRePnrvxJKf4zMAG4Ue5jkn1zFR?=
 =?us-ascii?Q?GbxPuDfLW+tPdSZRRdR/ZS8B4TXrFKaOCc4AKYQNmS0PHabPKw3qjFVRmrAf?=
 =?us-ascii?Q?rYuWCPy6XNNc1XjoHxZcT+9V2tAx2K6uVaLTmm4FYEEfIZ7ffPlrUUvun71J?=
 =?us-ascii?Q?1OegnpKCXe9Blj4Qibn1C3p8WE43Wtj7bwBL3eKEz36wpGLra90n/3Pjm4FR?=
 =?us-ascii?Q?OM7rWJzj/b0oAoH878bHsOcDSBcWMU9RIHomxYQq4ohZn4lvbPZzlQoJItKW?=
 =?us-ascii?Q?PB/UgYdT7R/RQw6IYT6lbgrJL0eD63cjf1NKnHYgMpx3cyA171FUUeRvlf14?=
 =?us-ascii?Q?c7D/jWgtnA+I8h51SCsLLLq4AFEp7vBHMOsaV9Vhtu3fnUchpwGMtRM/Q2HR?=
 =?us-ascii?Q?GTXKgEVkcj5MH8ESu4QBDPreuRMx2fQqdOkY9EGvySQdtlpXzCKqloLwhL4S?=
 =?us-ascii?Q?BAbzBE7+5eaZxLpdYP10oCKUc7Vgh/mkOx+NRnb2LftNGVhkHmBN7TQ0IVjn?=
 =?us-ascii?Q?GfGfBVdM+6hEQhixKBA5tTdik6JmzDgRFxJs22O4rn6VA5bTCjbssUruvFJl?=
 =?us-ascii?Q?X/DgKkmMBZOzVm5x7GGhXhbpow80qHo8ipynxk+w9mO2pdHaIY481zUh8pQm?=
 =?us-ascii?Q?W2BBo+JWS4Y1WinKkVB0AbUUwDSyBLEDGPp1mZQIaAM6ZNzyV0CxzAEqIhCv?=
 =?us-ascii?Q?7yb8w4dv0/NFoY/tfw3RtX+K3xG7xh8nITcrWOH2ipicFIrbZUFL1lfQXP02?=
 =?us-ascii?Q?vMbz2EEWgmDgwi3l1GTBmUwMPAyNP8LDIxE24+5IAiFgOQpjGfwQB6p50g0y?=
 =?us-ascii?Q?sr3sVEotboweWvhrqYhu76aPXNlp8qtIZJ0Tc0Eszeq7yzQYj+Pny4wjYQlx?=
 =?us-ascii?Q?pAZUi8Hv+NHviHyEVW2bwux31ITDmQDhn3IAVo8KFKEXFHvEtYbMSuh6l+gw?=
 =?us-ascii?Q?2Od5AZWEiYItDG9NFbrkzOKjhEvm+3aVz1rvjQ31Pzl27jxmJ9PCIaj2wr/m?=
 =?us-ascii?Q?Np+RGASgOgCCj6nPlhZAOpAAKVOyJTJaWd4dpNuwaJU7BvVVmtB1drZ0ISO/?=
 =?us-ascii?Q?6aDLMyQacYKb0Wo39+FOLgNqZB4ellaDjTAL6IOYdIEO6kT5HR8iFE49JkOm?=
 =?us-ascii?Q?Y4luArzY6ROIvNm/hWmkOfET4/ujRoHboUATLyNBJqKu5RMOVstvvWuPB58l?=
 =?us-ascii?Q?yjjXS+jwFOh5qUqDn8XhW3a9vLXwBOOWYkLxBqvAGoMr1R+I6LIDVtSLJNfJ?=
 =?us-ascii?Q?lB8O1ak+krRigBw7h/R4M0TnDlQEhfjxzjF+LZt0X+JBhsxBVkyHqQ0qeW9w?=
 =?us-ascii?Q?+AyPXCRhqVnX9hWk4hMO8AVTktADKXnRaLqAGJ7zKGrVuFP70TQIpvbcYAFZ?=
 =?us-ascii?Q?2cQzFlC/4oVdS81LcQPuZyjM2dodeJhpLvjmm+dyp8aPwh2hdnGh6RQvxUak?=
 =?us-ascii?Q?eEKhFPelvuZPq6ENpS8MoMp99tfPZvxupK5ctkEO0KdnzeCvifBDXa4+wstp?=
 =?us-ascii?Q?appi1C3Ij0Jh0P1K+EwgwrWG2QldYotBLlgDzJqw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e020394-f713-4333-dfba-08dc031fe966
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 18:57:57.7300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vrwrQq6YxHQfkJAWjjbBppdyQRjCMh8ycqGuzfEt9KKsPAhBJ6wv/VtCY2a4XnR/l+rIoWr8IyEV70uax5FSlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7085
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> Coly,
> 
> Yesterday I noticed that a few of our nvdimm tests were failing.  I bisected
> the problem to the following commit.
> 
> aa511ff8218b ("badblocks: switch to the improved badblock handling code") 
> 
> Reverting this patch fixed our tests.
> 
> I've also dug into the code a bit and I believe the algorithm for
> badblocks_check() is broken (not yet sure about the other calls).  At the
> very least I see the bb->p pointer being indexed with '-1'.  :-(
> 
> I did notice that this work was due to a bug report in badblock_set().
> Therefore, I'm not sure of that severity of that fix is vs a revert.  But
> at this point I'm not seeing an easy fix so I'm in favor of a revert.
> 

Dan and I were discussing this and it occurs to us that it may be easy for
you to stand up the test environment I'm using.

For CXL we have a run_qemu.sh project[1] which stands up a qemu
environment with the ndctl[2] tests in them.  Clone ndctl to ~/git/ndctl
so run_qemu.sh can find it.  Then start run_qemu.sh in a kernel tree like
this:

$ <path_to_run_qemu>/run_qemu.sh --cxl --nfit-test --nfit-debug [-r img]

[-r img] is optional but useful if you have changed the ndctl tests.

Once booted you can run the test suite with meson:

$ cd ndctl && meson test -C build

I've been running just our clear.sh test which shows the error.

$ cd ndctl/build && meson test clear.sh

Hope this helps,
Ira

[1] https://github.com/pmem/run_qemu
[2] https://github.com/pmem/ndctl