Subject: Re: [PATCH] vivi driver works only as first device
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Gregor Jasny <jasny@vidsoft.de>
Cc: video4linux-list@redhat.com, Ted Walther <ted@enumera.com>,
       John Sokol <sokol@videotechnology.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20071206220634.GT17496@vidsoft.de>
References: <20071203225610.GS17496@vidsoft.de>
	 <20071206220634.GT17496@vidsoft.de>
Content-Type: text/plain; charset=utf-8
Date: Mon, 10 Dec 2007 05:08:51 -0200
Message-Id: <1197270531.5168.5.camel@gaivota>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 921
Lines: 23

Hi Gregor,
Em Qui, 2007-12-06 às 23:06 +0100, Gregor Jasny escreveu:
> From: Gregor Jasny <gjasny@web.de>
> 
> When the vivi driver allocates a video device, video_register_device() stores the
> allocated device minor inside the vivi structure. But when the device node is opened,
> the file minor number is compared to the minor in the device list. So this patch
> copies the allocated minor in the device list, too.

Thanks for the report. Instead of applying your patch, I decided to
better analyze the issue, fixing it with the proper solution. The issue
is that vivi_register changes iminor, but this change were not properly
returned to the driver.

-- 
Cheers,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/