Received-SPF: pass (google.com: domain of linux-kernel+bounces-10116-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Andreas Dilger <adilger@dilger.ca>
Message-Id: <A0551254-5464-429A-9D7E-98065BB544D7@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_9EC47313-BC83-46B4-80D3-BB34DE69435F";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] checkpatch: ignore deleted lines for comment context
Date: Fri, 22 Dec 2023 16:22:29 -0700
In-Reply-To: <2b294dc33ea64d1d605cf146741d92677b13006a.camel@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
To: Joe Perches <joe@perches.com>
References: <20231222230551.95425-1-adilger@whamcloud.com>
 <2b294dc33ea64d1d605cf146741d92677b13006a.camel@perches.com>


--Apple-Mail=_9EC47313-BC83-46B4-80D3-BB34DE69435F
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Dec 22, 2023, at 4:15 PM, Joe Perches <joe@perches.com> wrote:
> 
> On Fri, 2023-12-22 at 16:05 -0700, Andreas Dilger wrote:
>> From: Andreas Dilger <adilger@dilger.ca>
>> 
>> Don't consider lines being removed by a patch as part of a comment.
>> Otherwise, false "WARNING: memory barrier without comment" and similar
>> issues can be reported when a comment does exist on the previous line.
>> 
>> For example, a change like below was previously incorrectly flagged:
>> 
>> 	/* matched by smp_store_release() in some_function() */
>> -	if (smp_load_acquire(&list->tail) == head))
>> +	if (smp_load_acquire(&list->tail) == head) && flags == 0)
>> 
>> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
> 
> OK, but:
> 
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -1972,7 +1972,8 @@ sub ctx_locate_comment {
>> 	$current_comment = '';
>> 	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
>> 		my $line = $rawlines[$linenr - 1];
>> -		#warn "           $line\n";
>> +		#warn "LINE($linenr): $line\n";
> 
> This is a superfluous change

Sure, I can resubmit without it if you want.  I found it helpful when
debugging why this code didn't work in the first place...

> 
>> +		next if ($line =~ /^-/); # ignore lines removed by patch
>> 		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
>> 			$in_comment = 1;
>> 		}
> 


Cheers, Andreas


--Apple-Mail=_9EC47313-BC83-46B4-80D3-BB34DE69435F
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmWGGjUACgkQcqXauRfM
H+B1fg/9HrL3HAO+54BMABfLd0piwVWdoOf3aVx0JEqkjFJhIXWeQbGr3Hct7ccf
nQPMc1QOt9lWMeeTkbog1IMqg8W0tE+Xv5IKkjb7QrwVcWaP27VD7ctlD6qEs5Xe
jasDBzdig/Vgxd8bfelaeM9hFJMSAxC9cwmnBUQ8OXFo8X3//ieIQfHycC0K9MTI
TuHqkHiON85JM3aE/j0iyjKS5owYxKyonJ8+B1J+Nwxqu961LRRpnpoISKO/Je/3
9b2it8kzIBJgRQjNxgxrQXNXSTgsZeRmdZ8b0aw8PAjkOTk9e6hJl4mQeSTwi8rx
FvjpXbDd9sJ4BNGRhmOq1VmoOwTun8yKc+Cgv1LizuVFByy2F4AsIUILxFv7MbpF
G5G8CE2O1BqX4Qkmg/m+27yEvjAaDZuY+DyOnCxdoil6LlJPDF429JyS/9jHUlI5
Q2sV/XKjWmE01q9XxlZZ5dUfIKl4ekYuH0DFTqoimAQyuiZmjIuf8qr7SM4WXHnz
ZTKiPlFyK3DTTv6mSY/MjNw+HZHzpEHc6CAGHZexF3x+o5cuopShAnleMrQy28xU
JeCAFDLSjlp//Fizn3CaKT2afDi3LpKH4wzhhPMxVvoLm5bkGTO+peAfh29RvVTe
4PKi695DlHJtOzROVaLGGDI5+WnVEn8BwOZ96jEGgdsYSZwQ5UU=
=3Scm
-----END PGP SIGNATURE-----

--Apple-Mail=_9EC47313-BC83-46B4-80D3-BB34DE69435F--