Received-SPF: pass (google.com: domain of linux-kernel+bounces-10378-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e7a46035-9c5e-495d-8f20-73dca4fec068@redhat.com>
Date: Sat, 23 Dec 2023 11:25:45 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in
 ia_css_acc_types.h
To: Randy Dunlap <rdunlap@infradead.org>,
 Dipendra Khadka <kdipendra88@gmail.com>, mchehab@kernel.org,
 sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, hpa@redhat.com
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
 linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org
References: <20231223051108.74711-1-kdipendra88@gmail.com>
 <d1c18155-9c8e-4164-a2bf-5eab3d42995d@infradead.org>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <d1c18155-9c8e-4164-a2bf-5eab3d42995d@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 12/23/23 06:18, Randy Dunlap wrote:
> Hi Dipendra,
> 
> On 12/22/23 21:11, Dipendra Khadka wrote:
>> codespell reported spelling mistakes in
>> ia_css_acc_types.h as below:
>>
>> '''
>> ia_css_acc_types.h:87: cummulative ==> cumulative
>> ia_css_acc_types.h:411: descibes ==> describes
>> '''
>>
>> This patch fixes these spelling mistakes.
>>
>> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> 
> This patch is an improvement so it could be merged as is IMO.
> But...
> 
>> ---
>> v2:
>>  - Previously only corrected spelling  mistake reported by checkpatch.pl.
>>  - All spelling mistakes reported by codespell are fixed.
>> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
>>
>>  drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>> index d6e52b4971d6..1dc2085ecd61 100644
>> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
>>  		memory_offsets;  /** offset wrt hdr in bytes */
>>  	u32 prog_name_offset;  /** offset wrt hdr in bytes */
>>  	u32 size;			/** Size of blob */
>> -	u32 padding_size;	/** total cummulative of bytes added due to section alignment */
>> +	u32 padding_size;	/** total cumulative of bytes added due to section alignment */
> 
> I apologize for not looking at your v1 patch carefully.
> The comment above would be much better as
> 
> 				/** total accumulation of bytes added due to section alignment */

I agree that that is better. Dipendra can you please send a v3
using the new text suggested by Randy ?

Regards,

Hans


>>  	u32 icache_source;	/** Position of icache in blob */
>>  	u32 icache_size;	/** Size of icache section */
>>  	u32 icache_padding;/** bytes added due to icache section alignment */
>> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
>>  };
>>  
>>  /* Acceleration firmware descriptor.
>> -  * This descriptor descibes either SP code (stand-alone), or
>> +  * This descriptor describes either SP code (stand-alone), or
>>    * ISP code (a separate pipeline stage).
>>    */
>>  struct ia_css_acc_fw_hdr {
>