Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp1381729rdb; Sat, 23 Dec 2023 04:54:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFY+5DfynLoDGRmUZmS35ST1svMQZYdwNk1dmRpcxBXINj1X7Mgc9vNcvjASRjf+LxIFSR X-Received: by 2002:a17:906:c358:b0:a23:5a57:1793 with SMTP id ci24-20020a170906c35800b00a235a571793mr1337865ejb.56.1703336044498; Sat, 23 Dec 2023 04:54:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703336044; cv=none; d=google.com; s=arc-20160816; b=WjTyOzPJObrlylGI/FFZBddlVAunvgPIScrIb0XyaU0upeOamtmL2bHvYvbyJTSInm 26hTfu8/vQWd2bidSwP/REsYeV84g9oyRniLTNmLZ6WsLbKnRDHZGsi2CVZ1z6V92SKh ezg2D1e/cU4pZWgrdiq8X9ZaDDzsnI8RRvk+UsETXTwK+j71jEkG2ZGKgYA2hBPXHIPG bVboVUVL5ZSkOrgvxfmDiz6iUtRegi5K29yv2se2CY75OozTZgm5R48bohfj6ZZR7aol UCLagVFjEvt+mohU55eEZGI5xK5R/cwyQ/ppRbQuXNNGYLI1B1bFpwngrL3kWkrvicWv OLaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=RHuvb+1eWaNdWAEf0x3XBJn2GUmppyTKGeO58s7qJtQ=; fh=OONq2QKImA1XvJaTrKtxrGjIjVEIFZKq4KXVSaAJI5E=; b=gucgKiqu/0KjrhlsHIMSdeIaK+/ir162n9TMaG7TbRcdcT5Dhe3SfaxwJEc3cIiBUX ZW91Nm3Ql0nlzBO32AqCTITpGXiQg1EI1RQm/6wKoLxEtBalZVApQ3qP/hNjYLfNEPjL 5F5PaZd4SAHDhTVfCVwl+SZ9wko6S5HUgY00u2gw+kA9MoX9PuVaZ3qR5D6ey+Iyk1+I I2vsBzVsidZY8w0se5nW7sSM5ZvGxWTRNHnui8m2WJLKmIVUQSpaa8Bd7LGXBOiov9mt VQ+YFvcU852vt/B3J3yq3eaoDY0yLB0m3n9pasudn4sYG8/A5ERXC2pQEh4+BTxs792k e1sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RzP7j82f; spf=pass (google.com: domain of linux-kernel+bounces-10412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10412-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gh37-20020a1709073c2500b00a26b42502d0si1675032ejc.403.2023.12.23.04.54.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Dec 2023 04:54:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RzP7j82f; spf=pass (google.com: domain of linux-kernel+bounces-10412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10412-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 061191F227C7 for ; Sat, 23 Dec 2023 12:54:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 11239D2F6; Sat, 23 Dec 2023 12:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RzP7j82f" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408ECD28B; Sat, 23 Dec 2023 12:53:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA991C433C7; Sat, 23 Dec 2023 12:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703336033; bh=AVUxd05ykx/O/0lzq0rz6ESQ9un8BWEmfNzbEAr9GOE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RzP7j82f4ljDVLL1/WOoYX6CjZ6zcRBpzifJvh8KQ5k5RXHXzsh8ZEaXYtIAVpJoG pXfofOvbIQeqxgmvX+laQdiP1v1SFt4XcP0GD5BuT84zz+1GCHJ6FOg6Ms19tw/LZb xAKPjbK+x2BGYk7vSVt1aSLcWhqRVM09FzaCA1txSf1M2jfvkBC5hIJE7+5NTeld1d /joFfSksjQ/Vj/astFyBQNPGsUIob+DytKPlgmokdeTuqRmger6gCosRf9hXufMwSD CfFicBgMulcbZ4wfpogbSYs6OKs2yHV2OFSSEXn10kVNjPotI5WGmxuPm/XHIqbAZY vnQ7gP5+kBV2w== Received: by pali.im (Postfix) id 327B5A3B; Sat, 23 Dec 2023 13:53:50 +0100 (CET) Date: Sat, 23 Dec 2023 13:53:50 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Hans de Goede Cc: Paul Menzel , Jean Delvare , Andi Shyti , Wolfram Sang , linux-i2c@vger.kernel.org, LKML , Kai-Heng Feng , Marius Hoch , Mario Limonciello , Dell.Client.Kernel@dell.com, Greg KH Subject: Re: Ideas for a generic solution to support accelerometer lis3lv02d in Dell laptops/notebooks? Message-ID: <20231223125350.xqggx3nyzyjjmnut@pali> References: <4820e280-9ca4-4d97-9d21-059626161bfc@molgen.mpg.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 On Saturday 23 December 2023 13:45:32 Hans de Goede wrote: > 2. Add a "probe_i2c_address" bool module option and when this > is set try to read the WHO_AM_I register, see > drivers/misc/lis3lv02d/lis3lv02d.c > and if this succeeds and gives a known model id then > continue with the found i2c_address. This should first > try address 0x29 which seems to be the most common and > then try 0x18 and then give up. This is the main problem of the whole email thread. How to figure out the correct smbus device address. And we really must not poke random address during kernel boot time. I think in the past was there enough problems linux kernel broke some HW or made system unbootable just because it tried to read something from some random undocumented address. Please do not try random unverified address on all machines. smbus is not really bus which provides discovering and identifying devices on the bus.