Received-SPF: pass (google.com: domain of linux-kernel+bounces-10464-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 23 Dec 2023 14:42:17 +0000
From: Gary Guo <gary@garyguo.net>
To: Benno Lossin <benno.lossin@proton.me>
Cc: Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>,
 Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng
 <boqun.feng@gmail.com>, =?UTF-8?B?QmrDtnJu?= Roy Baron
 <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>,
 Alice Ryhl <aliceryhl@google.com>, Martin Rodriguez Reboredo
 <yakoyoku@gmail.com>, rust-for-linux@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] rust: macros: allow generic parameter default
 values in `#[pin_data]`
Message-ID: <20231223144217.5c71727e.gary@garyguo.net>
In-Reply-To: <20231213220447.3613500-2-benno.lossin@proton.me>
References: <20231213220447.3613500-1-benno.lossin@proton.me>
	<20231213220447.3613500-2-benno.lossin@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gwrIn0zxaVohoxpZAiTyDBXWxfBuE09axEyeH8bdtOK6sKml08YCiM/9p2v7?=
 =?us-ascii?Q?Y0luWKyHqH7xvoCXsmbpsMXBbbVYFfJG/xiv52aLTepzlnOgQlkwaiCfUUw7?=
 =?us-ascii?Q?QRaEq5VvlSkW4FWftgTLwV2u5zlvrvtSq3CAVXnL83gISFrJgRiOEyOH+ORM?=
 =?us-ascii?Q?yHBLkPVwBAcp69jRdmds1RPil51Ks4kmjcu8Dm8+X8nVSUIkV08XrkyG+qO9?=
 =?us-ascii?Q?EVoH7ds6McnZIfziL3ORr+5Oe39CEO7z5gJj2NOG5pJDReAns86QjrsUGo2e?=
 =?us-ascii?Q?DndJzWRuXwgjf4jHxINtIRRHC/TNfuTVqi4iO0Bt6tBHVtPxrnfRW4cpty5n?=
 =?us-ascii?Q?oDeVviPsBPuqtCJ5zLd9GMRNU1DEhjFhfnyyfwbteBgRqyecJawf41dF7dba?=
 =?us-ascii?Q?3zYSA9E8wlscPyjMr/7krXy101q6fWDa3DYi6WQp7cO2rFsZr1wLbTwgFVST?=
 =?us-ascii?Q?rF3t/xAwW76mEhZAdrPEanKXyyP6yHdyGFU/j5jskum67fnuiJeqSPACRbX/?=
 =?us-ascii?Q?9/WGk/i6FSeagmaUxZNZ3la0tBeKHTZVA0aZSlC4+/nN+E+Y3Jc6rPj7JDmI?=
 =?us-ascii?Q?h+iFXizINUnhAfPVVixzsEcMkAW+QhUDe+yguUPunVFy+OaqKnhtZJYAMyjd?=
 =?us-ascii?Q?csEI6BcFuS+x6Ch2tgQQKyBFt1+XITqWhdy4kDBgZH/dIyvDYo6cwcXTdWFx?=
 =?us-ascii?Q?y844AvhphyzCnAyeVVOBMSX/qdUK5nSQi2Rz5XeKz/8nXGFTYy1YR9qu2gCr?=
 =?us-ascii?Q?QE8uUCC4KcFsiE3bvT8Imr2VkwUeRDRjrOp7fGFfICYMsmS1V88occ/0WQ/G?=
 =?us-ascii?Q?YJCeDNq9P/+8EKMND/qytKDydZnNbIZx6u65umbRdZgSnGUajDjzdEMAXbSJ?=
 =?us-ascii?Q?i8oieS0tPftNF7FInyEaQxOUeK0G+D4J57oVrMN3kzb3NAY8gc7Xfh1gPuJ0?=
 =?us-ascii?Q?ZzaLXhdveuC6CikK/w2ElJ9DUMJ/B3cQP84K8ab2XJ2jTRzZSnH6WLxmdzgA?=
 =?us-ascii?Q?obJDedWPX9ZYs8Y1N8j7JPz+1hl0IW48gZso7jXphg4tDeVPM4mfc6vDNCko?=
 =?us-ascii?Q?j/y0E5ikakzGHrb2bZIQ+f3jhi/T1HImY6VZTD2gETtwAlcMINgv522wOLsW?=
 =?us-ascii?Q?QbAkp5bYzTTU1ix3V97E0nMkzlg1li7XZFL125jeMxX56t38TSjBOw18hZPQ?=
 =?us-ascii?Q?LgvG4x+/suRM3yUWNIumzkQVsTr4zWAsENre+F3C4ZX8NfKqEC6EPkE0NsG6?=
 =?us-ascii?Q?inps0Dzek80rblzMNI0NuNI7pmi4YTDY8XhrFHN7uDgFcqDmSJkwFN+1qxho?=
 =?us-ascii?Q?7wLogGBaL26c2gjdafCjgJJJ6y8p/rCX79KX+OJNNQNmTU55UOaFwAVkNC1Z?=
 =?us-ascii?Q?NTVKCEguHUCb1/joOvuwz/DE1ccHlCvMsT1d/P1cwTifYasyB8C88SvU951S?=
 =?us-ascii?Q?bg5kJG9IfHuZcorX0u+lp4bJWVzIdcihblNpLhQR+hqJYUQZSF+p2d7x0ld0?=
 =?us-ascii?Q?eumZKwQFX1zuUQYAyaaK3c2Apts+sdIh+wXybWMjA8EfUU6vF0XJ4MRu4eeF?=
 =?us-ascii?Q?WrQCKkEo/JMathyRFq7STC/ubWkDmBXT/vBTp2XCHi5MBqOZYSBWfGxstR4p?=
 =?us-ascii?Q?h2LY83hiD9+TJchDuX7wUVBBZIgDSaeVwpL/ZvsXvbGw?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: f8a9e435-8a4f-43ad-672e-08dc03c55df5
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2023 14:42:20.0685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h6fezBeLiWIq/Uwc0Iu1SjEnyfqa6GqMeXuQTC1R9843s6ByCCHUSu7dnMM3REg3YiWfB4Wx3MGyWCjnGEEH4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB1908

On Wed, 13 Dec 2023 22:08:53 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> Add support for generic parameters defaults in `#[pin_data]` by using
> the newly introduced `decl_generics` instead of the `impl_generics`.
> 
> Before this would not compile:
> 
>     #[pin_data]
>     struct Foo<const N: usize = 0> {
>         // ...
>     }
> 
> because it would be expanded to this:
> 
>     struct Foo<const N: usize = 0> {
>         // ...
>     }
> 
>     const _: () = {
>         struct __ThePinData<const N: usize = 0> {
>             __phantom: ::core::marker::PhantomData<fn(Foo<N>) -> Foo<N>>,
>         }
>         impl<const N: usize = 0> ::core::clone::Clone for __ThePinData<N> {
>             fn clone(&self) -> Self {
>                 *self
>             }
>         }
> 
>         // [...] rest of expansion omitted
>     };
> 
> The problem is with the `impl<const N: usize = 0>`, since that is
> invalid Rust syntax. It should not mention the default value at all,
> since default values only make sense on type definitions.
> 
> The new `impl_generics` do not contain the default values, thus
> generating correct Rust code.
> 
> This is used by the next commit that puts `#[pin_data]` on
> `kernel::workqueue::Work`.
> 
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> v1 -> v2:
> - clarify the change in the commit message
> - add motivation to the commit message
> 
>  rust/kernel/init/macros.rs | 19 ++++++++++++++++++-
>  rust/macros/pin_data.rs    |  3 ++-
>  2 files changed, 20 insertions(+), 2 deletions(-)