Received-SPF: pass (google.com: domain of linux-kernel+bounces-10466-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 23 Dec 2023 14:43:09 +0000
From: Gary Guo <gary@garyguo.net>
To: Benno Lossin <benno.lossin@proton.me>
Cc: Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>,
 Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng
 <boqun.feng@gmail.com>, =?UTF-8?B?QmrDtnJu?= Roy Baron
 <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>,
 Alice Ryhl <aliceryhl@google.com>, Martin Rodriguez Reboredo
 <yakoyoku@gmail.com>, Tejun Heo <tj@kernel.org>, Wedson Almeida Filho
 <walmeida@microsoft.com>, rust-for-linux@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work`
Message-ID: <20231223144309.3bc42ecf.gary@garyguo.net>
In-Reply-To: <20231213220447.3613500-3-benno.lossin@proton.me>
References: <20231213220447.3613500-1-benno.lossin@proton.me>
	<20231213220447.3613500-3-benno.lossin@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IyyXCvhxFUEWRFUJjn3xdRlaWNJUD/zGeQtXOb0eCtTgGpM1pbGPsnHmwhmy?=
 =?us-ascii?Q?has++O2KGlDCVB31q7LnRSCK0ZzfMHsfl/PTf5p1QMU5vW2A85A0vs5RTjVC?=
 =?us-ascii?Q?9p5s7nFO58zvU8e4P7BsODkQaqoswVHYCRMlPVpqkxfdlY/HDvfor5Wnv2Qh?=
 =?us-ascii?Q?HrMeMYK2f49vlc/3uz3HWcrBfmPFsPg44UTCzYHp4Lo5Dk3aV/m2RxoQwnvW?=
 =?us-ascii?Q?I6nO38zhlZv4MotXxTVo/izSIzlLhc/JKUtBBaLTnix78YD1mKQ1FLVgcKpS?=
 =?us-ascii?Q?1fzqgFONkGsqSMMApRi32M8wTZaGBrwydxbx9FitlmTVmGHRcZK42yy5X9+t?=
 =?us-ascii?Q?40Fm7mXx5OUd1GVGi/4M7Hu0OJZh6wWK6isSJuf6h+7sfXX141STz9yDpKmq?=
 =?us-ascii?Q?Ik0FFJIPsW+iURpPbAeuewxHoEGUV/ktFA4Ec+fhL1ETJjsmDyNfC8RUPLE8?=
 =?us-ascii?Q?pcPq8O2cyeO7ElTEVMDsi4U7WWRR9xd7un5rtIJz2ZWYp50PpE48Je60h0Wr?=
 =?us-ascii?Q?r+RYPSydkoCzcVaETc4/Ul/cAMg27Cmg2sgpIsgqbaStOhQmvXhUGWpX2/Uw?=
 =?us-ascii?Q?UKOGUWCo2NMuC7KdkufDKr19dvCqIJ8ok6xj6ftbNRNt6Pk93wpPC1GaKTrS?=
 =?us-ascii?Q?PEdFf6uwspnig0HjRN+QHEioIt/mOX/SuYFsW49WvM14cnbEKgAPcniefmEx?=
 =?us-ascii?Q?CXeeiHfIp9u5ntj11MfBhft29hmYer1rRcTKtErEKtlkTfH12Up3OT341kFy?=
 =?us-ascii?Q?YGVOsWcpkgLr8poz8HFA3Onbux/lJohXYewEedme4V2FSzmgYYC2WliIVgXw?=
 =?us-ascii?Q?jKJ+nuGwNPtzYagIkeSLcjYTUfFKNIBUrdOmAqd0coYrbZr6l0IAVo9lZsSW?=
 =?us-ascii?Q?dA9SkVY9oIEbVKVn5Iewyx3Vkt+lQ6DPDWPIgJLfybjuhusNwyoG2HfqJQbP?=
 =?us-ascii?Q?SNn1bHFKYDfcE9y6f5/AtYOp3R/ZitAfmXoT8WY1b+Xc7iTSAnZ0mUvCHNpt?=
 =?us-ascii?Q?eij93OWe48gT5De3FYPZlVcm3i3e9GyeCesz+UFe/hQF2y9SIdggC+qFZDa8?=
 =?us-ascii?Q?voSmmImIHsPQghJMumv9dD0IcYDY3mga/iHub0fg/OgrDVtU4mSdon2DZu3p?=
 =?us-ascii?Q?CmCsxDJ+Vy4DVFVX+buHTu/RD2CJTY9IMBq1Uj7nZxWP20Nl0LR60qahhLJn?=
 =?us-ascii?Q?4UFl0RaBMlt8jUGGf1PHFjIRXsetbQXT3pXsj6ofdaeM69E0aHdon4jsXhBw?=
 =?us-ascii?Q?PPWPfymXa6eKN4feuiZbqJPu2BKfbP1IVFZtYONW5t8/BZzw33+/BqM46U16?=
 =?us-ascii?Q?4d88xbp+B0iNl35T5hplyP60KVOEVcdjWF63rItCN/apVtMSB2Swbr2i8qMs?=
 =?us-ascii?Q?jQUkLCyLNWG/yTRCiSk2kLJELZ7TO9z+rqDOAMa720ADpybncgfM8IeZmqQd?=
 =?us-ascii?Q?QK+qarBtflLjbS4PtZIDubZXllpvG5v2EfjsLVV+wH+fD/QAQzxD0VRxoURv?=
 =?us-ascii?Q?A7qFrbKt6zXfnpy2tVpux+hHuCyfARxW/Gzx0FRS3/jXTqZ2DG+5kC+X+Ib3?=
 =?us-ascii?Q?c13bhRH9bgeE7ErGVYo9gLP2MTnG0goi4L3+SrUES3SYDKUjYgBUNk1Pw70C?=
 =?us-ascii?Q?pARBXTDlJ8r0haPPW2mfbkw5LtWAaMMZgX/U8ieFEj87?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: bde98005-a658-4677-7c27-08dc03c57c99
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2023 14:43:11.4673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kto3/JJPiGSINXLZ/Y1cZcfoSl56+v7ucjD9+zuY+lJ5F3w5u0s/AC1Iy5Daj57oJ/5DA92KOTZDVNsp0s//ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB5747

On Wed, 13 Dec 2023 22:09:04 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> The previous two patches made it possible to add `#[pin_data]` on
> structs with default generic parameter values.
> This patch makes `Work` use `#[pin_data]` and removes an invocation of
> `pin_init_from_closure`. This function is intended as a low level manual
> escape hatch, so it is better to rely on the safe `pin_init!` macro.
> 
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> v1 -> v2:
> - improve commit message wording
> - change `:` to `<-` in `pin_init!` invocation
> 
>  rust/kernel/workqueue.rs | 33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)