Received-SPF: pass (google.com: domain of linux-kernel+bounces-10469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 23 Dec 2023 14:57:36 +0000
From: Simon Horman <horms@kernel.org>
To: deepakx.nagaraju@intel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	jdavem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	mun.yew.tham@intel.com,
	Andy Schevchenko <andriy.schevchenko@linux.intel.com>
Subject: Re: [PATCH v2 2/4] net: ethernet: altera: fix indentation warnings
Message-ID: <20231223145736.GD201037@kernel.org>
References: <20231213071112.18242-6-deepakx.nagaraju@intel.com>
 <20231221134041.27104-1-deepakx.nagaraju@intel.com>
 <20231221134041.27104-3-deepakx.nagaraju@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231221134041.27104-3-deepakx.nagaraju@intel.com>

On Thu, Dec 21, 2023 at 09:40:39PM +0800, deepakx.nagaraju@intel.com wrote:
> From: Nagaraju DeepakX <deepakx.nagaraju@intel.com>
> 
> Fix indentation issues such as missing a blank line after declarations
> and alignment issues.
> 
> Signed-off-by: Nagaraju DeepakX <deepakx.nagaraju@intel.com>
> Reviewed-by: Andy Schevchenko <andriy.schevchenko@linux.intel.com>

...

> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 1c8763be0e4b..6a1a004ea693 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -258,14 +258,12 @@ static int alloc_init_skbufs(struct altera_tse_private *priv)
>  	int i;
> 
>  	/* Create Rx ring buffer */
> -	priv->rx_ring = kcalloc(rx_descs, sizeof(struct tse_buffer),
> -				GFP_KERNEL);
> +	priv->rx_ring = kcalloc(rx_descs, sizeof(struct tse_buffer), GFP_KERNEL);
>  	if (!priv->rx_ring)
>  		goto err_rx_ring;
> 
>  	/* Create Tx ring buffer */
> -	priv->tx_ring = kcalloc(tx_descs, sizeof(struct tse_buffer),
> -				GFP_KERNEL);
> +	priv->tx_ring = kcalloc(tx_descs, sizeof(struct tse_buffer), GFP_KERNEL);

Hi,

Networking still prefers code that is less than 80 columns wide.
So I think the above changes are not desirable.

The rest of the patch looks find to me, assuming the maintainers want to
take cosmetic changes of this nature. Which, personally, I lean to thinking
is ok in the context of the rest of this patch-set.

>  	if (!priv->tx_ring)
>  		goto err_tx_ring;
> 

...