Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp1463908rdb; Sat, 23 Dec 2023 07:35:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjEY1K5zwf2pekFoU20KolQ+lyA9bQgIyEOBOHzuZc6v7fICVOI/bEjvyQsoijqKcX4VsB X-Received: by 2002:a05:6a00:1996:b0:6d4:511d:e0a1 with SMTP id d22-20020a056a00199600b006d4511de0a1mr3143299pfl.21.1703345744634; Sat, 23 Dec 2023 07:35:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703345744; cv=none; d=google.com; s=arc-20160816; b=v5P33cdolWOf1huvc7pdaZsnMzs1XEIEJiz+I45x/pO1+hNVCMkCkMvMD46aMx4Rq2 C7Ehw2Y3xQzTPxM32Uatbns2AiUCHysgsk7Q0ni033Bz2ayveETsiMk1lj7mbMYsV9Q5 KUD8EGl7D4/ozWh74XiuemGc//5u6m/Uo0FnpUe1pxTMBKmynLBGNBcKUx6olyJ9lZIP Zeo2wivHTJwlNmT2K0/9qW1E+RFi6/RggPgpqyMbiHGTX24x+sW9qliG/INOOB1m6n9U 9Vbasngdbogo7noyLq2Mx6mX0MmRXlInkMTKV0v0GQnELmS83AAlw5tMQFacx71BbGf6 BvoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HVCikgrpszvnIF8Rv4yjC7320KJYsFNpKifoldBNonQ=; fh=pPDKJBlb9aWWOeuLaA021jrMvBnBJhJO9NmGs4OueI4=; b=juiSPaszLw89/Vz9QXriDnclBCDaKB0wtEMyRxhJtAwkBRzYF6x0BKxfAev2JBb+Nb a+Rurg7L2zIugg5uPvdbXMKp6yTPWRw4qNdLsosLkSDPFCCtRQ/h4MkNvM9Myckw5Wsh 8UoJUitsGMJq/qsQB6Mon4YqDlufo8tV800TKmou5bG537GnFIK8W1eKXq4qKFK1y01Z lfpz5Ud5ruT9gHnV3dtUfesrKfqkqETD41WPAdexN0xcz4KtmEkoaq0I9I9/WNhIA4/X EmlUJElDYGjO9dAHiKg0abkm/M7BuFezapU6BVb7+oUAsLYRvf5vlou1gd2IsrLCfR5m nkzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bii8R9Mq; spf=pass (google.com: domain of linux-kernel+bounces-10481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10481-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d15-20020aa7868f000000b006ce83264887si5068131pfo.57.2023.12.23.07.35.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Dec 2023 07:35:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bii8R9Mq; spf=pass (google.com: domain of linux-kernel+bounces-10481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10481-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6A611B21441 for ; Sat, 23 Dec 2023 15:34:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D11D810958; Sat, 23 Dec 2023 15:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bii8R9Mq" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED943DF5C; Sat, 23 Dec 2023 15:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0702C433C7; Sat, 23 Dec 2023 15:34:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703345656; bh=TQAtHtfyY5SOEXTBMr548AVub4xXZ+3Y7MAwfzf7KaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bii8R9Mqv6ZnIpA6eiJFaC0xPtd99hbGkytddNbV60T7RBBlvOeHX9kKTsi5AKpPJ mg/u74N4XpGn90BnzoxK2jWeqfBHbkfvLeNgCvWqrQmJ0Gi54eyqkFu2lvafA1kL3o CuwFZPZNJyFBSoszXuMfOIsvzVpgl71qlxHxMn5C6FRhqnv4vavhtlx+/w5EpOHPjT y05popLssBes0f9XsnsWHw7xEJaSm9s+IVnhkeLGbx2ujlxBFr05gGP22YvXuPv5WF OaRfIb/y9wGRWgSDhVhwiyZCeWaNdMhIYiYPQ9kdif8l8hhUYfe+K2sFz0srKhn1Lq KRyukHBxV9PuA== Date: Sat, 23 Dec 2023 09:34:11 -0600 From: Eric Biggers To: Paul Moore Cc: Alfred Piccioni , Stephen Smalley , Eric Paris , linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, Casey Schaufler , Tetsuo Handa Subject: Re: [PATCH] security: new security_file_ioctl_compat() hook Message-ID: <20231223153411.GB901@quark.localdomain> References: <20230906102557.3432236-1-alpic@google.com> <20231219090909.2827497-1-alpic@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 22, 2023 at 08:23:26PM -0500, Paul Moore wrote: > > Is it considered valid for a native 64-bit task to use 32-bit > FS_IO32_XXX flags? No, that's not valid. > If not, do we want to remove the FS_IO32_XXX flag > checks in selinux_file_ioctl()? I don't see any such flag checks in selinux_file_ioctl(). Is there something else you have in mind? - Eric