Received-SPF: pass (google.com: domain of linux-kernel+bounces-10507-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <04d355d7-ced1-4dd6-b0de-29478a67f15d@infradead.org>
Date: Sat, 23 Dec 2023 09:16:56 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] LoongArch: signal.c: add header file to fix build
 error
Content-Language: en-US
To: Huacai Chen <chenhuacai@kernel.org>
Cc: linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
 loongarch@lists.linux.dev, Kent Overstreet <kent.overstreet@gmail.com>
References: <20231222044554.25656-1-rdunlap@infradead.org>
 <CAAhV-H6pXSuj+bpf=skMYLQh8znboT6YxAA4UXokwm60-aXa8Q@mail.gmail.com>
 <CAAhV-H5-ORE2zGT2oZu+dusfzoXfn6mpSDsyE4wo+3XYVUpovg@mail.gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAAhV-H5-ORE2zGT2oZu+dusfzoXfn6mpSDsyE4wo+3XYVUpovg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 12/23/23 02:27, Huacai Chen wrote:
> On Fri, Dec 22, 2023 at 12:59 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>>
>> Hi, Randy,
>>
>> I cannot reproduce it with the default config file.
> Oh, I know, this error only occurs in linux-next, but I think this
> patch should be squashed into "rseq: Split out rseq.h from sched.h".
> Or as a fix applied to the bcachefs tree rather than the loongarch
> tree.

Yes, I think Kent is taking care of it.

Yes, in linux-next.

Thanks.

> Huacai
> 
>>
>> Huacai
>>
>> On Fri, Dec 22, 2023 at 12:46 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> loongarch's signal.c uses rseq_signal_deliver() so it should
>>> pull in the appropriate header to prevent a build error:
>>>
>>> ../arch/loongarch/kernel/signal.c: In function 'handle_signal':
>>> ../arch/loongarch/kernel/signal.c:1034:9: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
>>>  1034 |         rseq_signal_deliver(ksig, regs);
>>>       |         ^~~~~~~~~~~~~~~~~~~
>>>
>>> Fixes: b74baf4ad05b ("LoongArch: Add signal handling support")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Huacai Chen <chenhuacai@kernel.org>
>>> Cc: WANG Xuerui <kernel@xen0n.name>
>>> Cc: loongarch@lists.linux.dev
>>> Cc: Kent Overstreet <kent.overstreet@gmail.com>
>>> ---
>>> v2: repair Cc: list
>>>
>>>  arch/loongarch/kernel/signal.c |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff -- a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
>>> --- a/arch/loongarch/kernel/signal.c
>>> +++ b/arch/loongarch/kernel/signal.c
>>> @@ -15,6 +15,7 @@
>>>  #include <linux/context_tracking.h>
>>>  #include <linux/entry-common.h>
>>>  #include <linux/irqflags.h>
>>> +#include <linux/rseq.h>
>>>  #include <linux/sched.h>
>>>  #include <linux/mm.h>
>>>  #include <linux/personality.h>

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html