Received-SPF: pass (google.com: domain of linux-kernel+bounces-10568-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <f669eb1e-20af-4923-b328-f31bea4f7dbb@infradead.org>
Date: Sat, 23 Dec 2023 11:30:22 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Documentation/trace: Fixed typos in the ftrace FLAGS
 section
Content-Language: en-US
To: Matthew Cassell <mcassell411@gmail.com>, corbet@lwn.net
Cc: linux-doc@vger.kernel.org, trivial@kernel.org,
 linux-kernel@vger.kernel.org
References: <20231223185845.2326-1-mcassell411@gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231223185845.2326-1-mcassell411@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/23/23 10:58, Matthew Cassell wrote:
> Fixed typos in the FTRACE_OPS_FL_RECURSION flag description.
> 
> Signed-off-by: Matthew Cassell <mcassell411@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  Documentation/trace/ftrace-uses.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/trace/ftrace-uses.rst b/Documentation/trace/ftrace-uses.rst
> index f7d98ae5b885..e198854ace79 100644
> --- a/Documentation/trace/ftrace-uses.rst
> +++ b/Documentation/trace/ftrace-uses.rst
> @@ -182,7 +182,7 @@ FTRACE_OPS_FL_SAVE_REGS_IF_SUPPORTED
>  
>  FTRACE_OPS_FL_RECURSION
>  	By default, it is expected that the callback can handle recursion.
> -	But if the callback is not that worried about overehead, then
> +	But if the callback is not that worried about overhead, then
>  	setting this bit will add the recursion protection around the
>  	callback by calling a helper function that will do the recursion
>  	protection and only call the callback if it did not recurse.
> @@ -190,7 +190,7 @@ FTRACE_OPS_FL_RECURSION
>  	Note, if this flag is not set, and recursion does occur, it could
>  	cause the system to crash, and possibly reboot via a triple fault.
>  
> -	Not, if this flag is set, then the callback will always be called
> +	Note, if this flag is set, then the callback will always be called
>  	with preemption disabled. If it is not set, then it is possible
>  	(but not guaranteed) that the callback will be called in
>  	preemptable context.

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html