Received-SPF: pass (google.com: domain of linux-kernel+bounces-10612-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <2e34aa5c-4e50-4492-b3c2-aed9e06e8236@nvidia.com>
Date: Sun, 24 Dec 2023 02:23:31 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] IB/iser: iscsi_iser.h: fix kernel-doc warning and spellos
Content-Language: en-US
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org,
 Jason Gunthorpe <jgg@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Leon Romanovsky <leonro@nvidia.com>,
 linux-rdma@vger.kernel.org
References: <20231222234623.25231-1-rdunlap@infradead.org>
From: Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <20231222234623.25231-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ektXVWx1WVhJWjlOcjFyNnlFZEczY3NEVXAwVTFPaVJxa3hhalp4MERYczBK?=
 =?utf-8?B?VGY1RDViWG5WN1ZJMXNpQytvbUkxZU94bnBiYy9lS2VaakVMZW9JT2VpeEQy?=
 =?utf-8?B?ajdYWHZBd0w1UDQrTEMxREtqNWJRVjJ6aGt6dlRsNkZ2MzhCTStFT3hWalZT?=
 =?utf-8?B?VkVONENBQjA1S3cxWmJ0RFF4RklZTTBJVkVsd2ROcGNOVDE4Qyt5QWVNWGUr?=
 =?utf-8?B?MGpHQ2oxNmpWazE2MllKUmJrR2tIUVFReXlDOFFwczdwNDFGYklJOGY0TEQw?=
 =?utf-8?B?UzJKVHBLUGJjVG5LY29hQTBDQVJMQ1psUmcwNmZ5NEcxQ1NYSGNrRCtZd0ZO?=
 =?utf-8?B?bTJmQTdldWdmM1U1K1NiemV1OTFkWmZEWVhHL3RVYjhsbm5ncER1VmV6N0d0?=
 =?utf-8?B?OUlFUjB2YlAzWDdZUVNqRTZHVE1QY0M1TlN5b3BwdmxrL3hBdDlJSW56dGpY?=
 =?utf-8?B?T0tZYnVvb3FzeGNOK0xyNTVXY1F6YnBZb2ZBUnVZQytzekxTemtzZy9XaGNG?=
 =?utf-8?B?K1FxbHlBSXJJR0toTDNjY09oTGdsaWRkS0pSdzZrYi9YWWJ5MlFEeksweEZ1?=
 =?utf-8?B?TmI5WGRERkw4emtNMjl3cUdFOTJFTUEvZXQ4NXRPNzdya1MySnJBNmV3bU92?=
 =?utf-8?B?cUNtVkQ4N0p4UUxud2dpMTBhR2xVV2VGSGllNDNEN1AvNzEweGdaVzhxVURL?=
 =?utf-8?B?Rnlza0gzRWk3Mk9ycEFxb0ZtNDJEZFh6dHFIS2VBTk94OWh4dSt5cmdLUktK?=
 =?utf-8?B?V0syNHoxN0ErVjI2K3l5Q3dKaWZiQ1I2SW5hSVEzNWlUZGlXS0Vya05LcCtl?=
 =?utf-8?B?dERiTVFQOEpsVEJENzNIbmVLbEUzV0xJeXg2cm9CTnBWU1pFeCttV2daVWkx?=
 =?utf-8?B?aHdObVMraTRjSWZ1U3oyUFFUUkZXMjExaUVUTUdwVnFLdHhTS3VNUkVXU0Jn?=
 =?utf-8?B?SVo0SlhyeExyTEJvK3ZIM0dnRGxhcjY5NXluM3VBUzE2NHByYWxBZFVuMERU?=
 =?utf-8?B?aGNPUTN0dnhVSFBON0hyZGswc1k1dlRhOHhUaFM3UVhIUlZRQW1SRGtkckNo?=
 =?utf-8?B?UDU2SDR2T3ZYcmZ4ckc4bjkvQi92SFlXTWJsR0xLbGk5L1JabXYxN0c4NHNU?=
 =?utf-8?B?dUJxOHhNWWFFWHJqY3Z1MW1IZ2oyYkphYW56V1pwZW1laXlzZVFRT2xid01F?=
 =?utf-8?B?RElCbjIybEpqM0Q4ZDFkbjlBenRBOTNrSGMxY0dVd1lrS3JvR1dERGhEVXRa?=
 =?utf-8?B?cjEzT1RsenBRQzZkcWdMYWU1YVRudmI4V0ZaN3BvaWFUT2ExSTJnTG9Ja0VJ?=
 =?utf-8?B?cm0wY2tWdmFGL3pnVVhSaEJ1bkJNdjEzdUppZUoyNEM1K1BhNE5iZkxDTDBH?=
 =?utf-8?B?N3Z6Ky82ekp3V2JVQm13amJUaFl1N3BBNVJWQ3J2SWswZ3dGcHJSZ0RjaTdo?=
 =?utf-8?B?VVBLdXVRdjZpbStyQU5ZZUwwczhFOWZRdlFMQitqdVFGU25ha0h2amdJUlND?=
 =?utf-8?B?QTB2RmxqQmh2bVVVS0R5Z2U2L3RxLzVyczFGV0t3R29CZTRGVkxJTnExd1VQ?=
 =?utf-8?B?bE5mMXVNY1lzVjlCOUNmc3FOdWdNdU5OVUdlbmViRmhzUEdnUGJUNUNrR1JT?=
 =?utf-8?B?QU5FekZCelZtU1lSQ1BLQXFNaDBSYXRPYWthV3pEdDg0ZHp3TE1Nc0F6WXYy?=
 =?utf-8?B?cHFQc0UvT080Rkh0QkV5UkVxRElkNnNLdEZOcUNURjNKSkpEWGNqRE90QlIw?=
 =?utf-8?B?ZlRKUFFzK2kwZW9QQTF0eFRwVko1UUxJMlVsYTJqT0I1VEZCWi9lSWpaKy9U?=
 =?utf-8?B?bFdSZEkwbXJrYTc4ZitSRHNNUWU2UW1LZnZvR2ZFOUs0VXRlenhSTXp3ZU9P?=
 =?utf-8?B?c2QvQzliQ1c2YU5qYTVUWVFqaDUvQ0JKdUZtdFQrZTFKMm1uMW9mVldCVDZq?=
 =?utf-8?B?alNBVThTTDkxOWhUcHJna2RqaURkcU82QUtrK0JaVWNZWVJWWDNYN1RGVDEr?=
 =?utf-8?B?R1hVcWRIQ1k5MkxieHd1K2l0RTVBZUhIWFl4UmFhTHRtVXh1WFVhOVNvVFdv?=
 =?utf-8?B?MnBtMWdDeG5SdGVIblFLUXZ6NGZ4S2l0OUtnK2Z3bjFueFJoeTRjbVlaWWVQ?=
 =?utf-8?Q?MThQVrgkq0d+adUoyf+s02M01?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e4a5a2c-0851-435f-27a9-08dc04169297
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2023 00:23:38.0924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K/mlTU83S/5h6a3Nheav4ZYaPULGhrvqHxgh7RuI9mlz7TLv8IaQu3Nh9QfRlCbUvppHhT2wdjr99P81zNPjkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5005


On 23/12/2023 1:46, Randy Dunlap wrote:
> Drop one kernel-doc comment to prevent a warning:
> 
> iscsi_iser.h:313: warning: Excess struct member 'mr' description in 'iser_device'
> 
> and spell 2 words correctly (buffer and deferred).
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Max Gurtovoy <mgurtovoy@nvidia.com>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Cc: linux-rdma@vger.kernel.org
> ---
>   drivers/infiniband/ulp/iser/iscsi_iser.h |    5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff -- a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.h
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.h
> @@ -182,7 +182,7 @@ enum iser_data_dir {
>    *
>    * @sg:           pointer to the sg list
>    * @size:         num entries of this sg
> - * @data_len:     total beffer byte len
> + * @data_len:     total buffer byte len
>    * @dma_nents:    returned by dma_map_sg
>    */
>   struct iser_data_buf {
> @@ -299,7 +299,6 @@ struct ib_conn;
>    *
>    * @ib_device:     RDMA device
>    * @pd:            Protection Domain for this device
> - * @mr:            Global DMA memory region
>    * @event_handler: IB events handle routine
>    * @ig_list:	   entry in devices list
>    * @refcount:      Reference counter, dominated by open iser connections
> @@ -389,7 +388,7 @@ struct ib_conn {
>    *                    to max number of post recvs
>    * @max_cmds:         maximum cmds allowed for this connection
>    * @name:             connection peer portal
> - * @release_work:     deffered work for release job
> + * @release_work:     deferred work for release job
>    * @state_mutex:      protects iser onnection state
>    * @stop_completion:  conn_stop completion
>    * @ib_completion:    RDMA cleanup completion

Looks good,

Acked-by: Max Gurtovoy <mgurtovoy@nvidia.com>