Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp1649932rdb; Sat, 23 Dec 2023 16:33:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKD9EhwjrBJwnGOG3fTwu5v8/OVZKAc5cLr1f7XKOv+19gZ5eCW2L9NClnvusfBS3XKxAo X-Received: by 2002:a05:6214:2264:b0:67a:568e:5b10 with SMTP id gs4-20020a056214226400b0067a568e5b10mr5989049qvb.20.1703377991655; Sat, 23 Dec 2023 16:33:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703377991; cv=none; d=google.com; s=arc-20160816; b=Fh88P8lMdynpoDZAY0gMBjLI98BrVeEH1BNJWtuvVN61YKAv5KpTz3602P6O4Bgr/W pE5D1QoY1qu8EHZl+hMGwmQlCLc0rVFVYNX3DFm5ZvMbvCg59zuAfR9j0r6NxvGBCSep O9FoUqv7fwVUCVImWVEScDvxLHgvvWPKh+2n3kPFSr8hvTGkSgbaZALCCIhs2dTaBYmf cVU0VqmTbZwCkodGuQKczoA0/Mo6bp0jJEWmK4ebbcFTrYF4IUg3o6PvrGpqz3cs58Kr aS5XEZRqyqXdjlqobFTStNeBFxEXJvT9dAcoySojp91y1Sy4AptJdQW7YHaFRWXJXIdV dQfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=M/d6jhLWIAoafyZMIbU7FyHZ5o1LeCN0mHS2QimSYDY=; fh=9lI9spZNbykC/1nHhMgLR5H3+cNyDjSX8UIsRUegM4E=; b=c8DeHNvC3BdGOQRPcqC0DFlDwbcJ9fqO/+IhP/J6TIuxhM0ycgAoFy8QcJexYjDjfD XecwTk0t6oh9WZCokk+fewJdd//35VjuPICpMj+yMcBdE3bmL8Tg//VgbwQm/N8ZUB2V raPqQzYu8nYMIEId27m3c+IGRk9IkimRNiXBwHRuKnxNBxVd4bFXqOiFI5RgqcIUqORL jFwAHCzGZBlnxtNpbZnIIr6YVuxApAX2Q4C+PsEy0jeYfI7uPmf5Fcpc3gzdpUVTy5dY vGMp0GzLlWJvRCHoHlvi/KnCFpyC7lV6h8kUClcgVaIKkgrQGL4GAah6rfueanF2fd3d LAwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AilYrcRY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AilYrcRY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel+bounces-10614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10614-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d2-20020a0ce442000000b0067f9fbc70a3si3732712qvm.167.2023.12.23.16.33.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Dec 2023 16:33:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AilYrcRY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AilYrcRY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel+bounces-10614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10614-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 64EA11C211CD for ; Sun, 24 Dec 2023 00:33:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2A322137D; Sun, 24 Dec 2023 00:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="AilYrcRY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="VQjviSH5"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="AilYrcRY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="VQjviSH5" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B37B10E8; Sun, 24 Dec 2023 00:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7751021CD8; Sun, 24 Dec 2023 00:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1703377976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M/d6jhLWIAoafyZMIbU7FyHZ5o1LeCN0mHS2QimSYDY=; b=AilYrcRYOHo7HnTp96YKlhRGRte5ApMzUN3rk0J07PpvmQJS6FCNQbZX5/LM4IHAluVZbN +aMtqA5cT9nvlc0rbiGf5yJFgFpSFUKh6N8xRx7tiXF8hL8X48H8GS+aELVzc5z0GzbA0S xTcdi/uxxOCZZIoG/jvENsl0qEpC11Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1703377976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M/d6jhLWIAoafyZMIbU7FyHZ5o1LeCN0mHS2QimSYDY=; b=VQjviSH5KURZfCachlhBP+FqWv7iT9CFthS4cjmyk4lhTliGNFrbx4SdVPqlWSWOxioGKQ LO57/xCdKxGfYpAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1703377976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M/d6jhLWIAoafyZMIbU7FyHZ5o1LeCN0mHS2QimSYDY=; b=AilYrcRYOHo7HnTp96YKlhRGRte5ApMzUN3rk0J07PpvmQJS6FCNQbZX5/LM4IHAluVZbN +aMtqA5cT9nvlc0rbiGf5yJFgFpSFUKh6N8xRx7tiXF8hL8X48H8GS+aELVzc5z0GzbA0S xTcdi/uxxOCZZIoG/jvENsl0qEpC11Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1703377976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M/d6jhLWIAoafyZMIbU7FyHZ5o1LeCN0mHS2QimSYDY=; b=VQjviSH5KURZfCachlhBP+FqWv7iT9CFthS4cjmyk4lhTliGNFrbx4SdVPqlWSWOxioGKQ LO57/xCdKxGfYpAw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id AF25D13902; Sun, 24 Dec 2023 00:32:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id MRmtFzR8h2X6fgAAn2gu4w (envelope-from ); Sun, 24 Dec 2023 00:32:52 +0000 Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: [PATCH] badblocks: avoid checking invalid range in badblocks_check() From: Coly Li In-Reply-To: <20231224002820.20234-1-colyli@suse.de> Date: Sun, 24 Dec 2023 08:32:35 +0800 Cc: nvdimm@lists.linux.dev, Linux Kernel Mailing List , Linux Block Devices , Ira Weiny , Dan Williams , Geliang Tang , Hannes Reinecke , NeilBrown , Vishal L Verma , Xiao Ni Content-Transfer-Encoding: quoted-printable Message-Id: References: <20231224002820.20234-1-colyli@suse.de> To: Jens Axboe X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Level: X-Spam-Level: X-Spamd-Result: default: False [-0.47 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-0.87)[85.65%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[11]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,suse.com:email,kernel.dk:email,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: -0.47 X-Spam-Flag: NO > 2023=E5=B9=B412=E6=9C=8824=E6=97=A5 08:28=EF=BC=8CColy Li = =E5=86=99=E9=81=93=EF=BC=9A >=20 > If prev_badblocks() returns '-1', it means no valid badblocks record > before the checking range. It doesn't make sense to check whether > the input checking range is overlapped with the non-existed invalid > front range. >=20 > This patch checkes whether 'prev >=3D 0' is true before calling > overlap_front(), to void such invalid operations. >=20 > Fixes: 3ea3354cb9f0 ("badblocks: improve badblocks_check() for = multiple ranges handling") > Reported-and-tested-by: Ira Weiny > Signed-off-by: Coly Li > Link: = https://lore.kernel.org/nvdimm/3035e75a-9be0-4bc3-8d4a-6e52c207f277@leemhu= is.info/ > Cc: Dan Williams > Cc: Geliang Tang > Cc: Hannes Reinecke > Cc: Jens Axboe > Cc: NeilBrown > Cc: Vishal L Verma > Cc: Xiao Ni > --- > block/badblocks.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Hi Jens, Is it possible to take this fix into 6.7 still? Thanks in advance. Coly Li [snipped]