Received-SPF: pass (google.com: domain of linux-kernel+bounces-10620-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Jens Axboe <axboe@kernel.dk>
To: Coly Li <colyli@suse.de>
Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, 
 linux-block@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>, 
 Dan Williams <dan.j.williams@intel.com>, 
 Geliang Tang <geliang.tang@suse.com>, Hannes Reinecke <hare@suse.de>, 
 NeilBrown <neilb@suse.de>, Vishal L Verma <vishal.l.verma@intel.com>, 
 Xiao Ni <xni@redhat.com>
In-Reply-To: <20231224002820.20234-1-colyli@suse.de>
References: <20231224002820.20234-1-colyli@suse.de>
Subject: Re: [PATCH] badblocks: avoid checking invalid range in
 badblocks_check()
Message-Id: <170338190635.1172668.12689831383588478650.b4-ty@kernel.dk>
Date: Sat, 23 Dec 2023 18:38:26 -0700
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Sun, 24 Dec 2023 08:28:20 +0800, Coly Li wrote:
> If prev_badblocks() returns '-1', it means no valid badblocks record
> before the checking range. It doesn't make sense to check whether
> the input checking range is overlapped with the non-existed invalid
> front range.
> 
> This patch checkes whether 'prev >= 0' is true before calling
> overlap_front(), to void such invalid operations.
> 
> [...]

Applied, thanks!

[1/1] badblocks: avoid checking invalid range in badblocks_check()
      commit: 146e843f6b09271233c021b1677e561b7dc16303

Best regards,
-- 
Jens Axboe