Received-SPF: pass (google.com: domain of linux-kernel+bounces-10625-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\))
Subject: Re: [PATCH] badblocks: avoid checking invalid range in
 badblocks_check()
From: Coly Li <colyli@suse.de>
In-Reply-To: <0eef6feb-4775-4249-af74-9fccb093b6bc@kernel.dk>
Date: Sun, 24 Dec 2023 10:11:03 +0800
Cc: nvdimm@lists.linux.dev,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Linux Block Devices <linux-block@vger.kernel.org>,
 Dan Williams <dan.j.williams@intel.com>,
 Geliang Tang <geliang.tang@suse.com>,
 Hannes Reinecke <hare@suse.de>,
 NeilBrown <neilb@suse.de>,
 Vishal L Verma <vishal.l.verma@intel.com>,
 Xiao Ni <xni@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <98F03B8B-5A3E-463F-AB27-0AE00DC27CB9@suse.de>
References: <20231224002820.20234-1-colyli@suse.de>
 <A110805F-3448-4A87-AE70-F94A394EA826@suse.de>
 <0eef6feb-4775-4249-af74-9fccb093b6bc@kernel.dk>
To: Jens Axboe <axboe@kernel.dk>,
 Ira Weiny <ira.weiny@intel.com>


> 2023=E5=B9=B412=E6=9C=8824=E6=97=A5 09:38=EF=BC=8CJens Axboe =
<axboe@kernel.dk> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> On 12/23/23 5:32 PM, Coly Li wrote:
>>> 2023?12?24? 08:28?Coly Li <colyli@suse.de> ???
>>>=20
>>> If prev_badblocks() returns '-1', it means no valid badblocks record
>>> before the checking range. It doesn't make sense to check whether
>>> the input checking range is overlapped with the non-existed invalid
>>> front range.
>>>=20
>>> This patch checkes whether 'prev >=3D 0' is true before calling
>>> overlap_front(), to void such invalid operations.
>>>=20
>>> Fixes: 3ea3354cb9f0 ("badblocks: improve badblocks_check() for =
multiple ranges handling")
>>> Reported-and-tested-by: Ira Weiny <ira.weiny@intel.com>
>>> Signed-off-by: Coly Li <colyli@suse.de>
>>> Link: =
https://lore.kernel.org/nvdimm/3035e75a-9be0-4bc3-8d4a-6e52c207f277@leemhu=
is.info/
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Cc: Geliang Tang <geliang.tang@suse.com>
>>> Cc: Hannes Reinecke <hare@suse.de>
>>> Cc: Jens Axboe <axboe@kernel.dk>
>>> Cc: NeilBrown <neilb@suse.de>
>>> Cc: Vishal L Verma <vishal.l.verma@intel.com>
>>> Cc: Xiao Ni <xni@redhat.com>
>>> ---
>>> block/badblocks.c | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>=20
>> Hi Jens,
>>=20
>> Is it possible to take this fix into 6.7 still? Thanks in advance.
>=20
> Yep, we're still a few weeks out, so not a problem.

Jes and Ira,

Thank you all for fast response during holidays.

Happy holidays and merry Christmas!

Coly Li