Received-SPF: pass (google.com: domain of linux-kernel+bounces-10713-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 24 Dec 2023 20:44:35 +0800
From: Zhang Ning <zhangn1985@outlook.com>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	lasstp5011@gmail.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1
Message-ID:
 <OS0P286MB064153B62ECBBEED9C16755DCD9AA@OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM>
References: <20231224075001.3032214-1-andyshrk@163.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231224075001.3032214-1-andyshrk@163.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: OS0P286MB0641:EE_|TYWP286MB3079:EE_
X-MS-Office365-Filtering-Correlation-Id: 06182430-0148-4ab4-afb5-08dc047e18a9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8imfxOhnBYV6G/O6Q6redJvuTuNfe2aVV9p4zuuSOcCshrZ33iHyeeeepKx93bOCGRBJAZUclqUfvFNfsUgMHuJ7OkAZWFudZJzWOdWJiQTF2WPdm3+LguGbDvg6uHsROZ68x9sTkQdNZPxluzup2uWxPNsaGsGdLwYFIEl4RVssBJI47fAxmyiMKHwOIGkAPqvnrLy3X57CE1+vb+BbP4Kil7X0hdc6uJIgpf2x4Dkc85i5rTxTAXyz8g0ihUCYEWcTuo6o738M1vFZlY8GdKFXpyPWAH5MO6/ALdN1R76ukXC/8Nl3C17vv6E1pNPPE1bJPf2eLorkgDKj+pV+3Sjpg50S/pNTpsl4FFRXnNR3Dpcqux/JEGm6ZZVEi9c1TtXJfjmtvLViNAdDgu8JRHpf0mhNBv5G2hHqtBkgd32fUxZqkLKGemcWXuV6zJlQInFULlKYCnWUazfPew3PFNPF9FW5ZzOAp6hXhEhluDjkxgL/25Vp1XYXWezf3bYv9TibnO6p8HXUSXX8kT6oPduXC3yJkjpfsq6d0JhTI9wfVNCw2MtM7saG+gXnYO7QVxq4EFkrTAHtgUthn29eCu1yeY97kh+9Xlsgw4x9RjI=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SHl3NkZDZURsaytkMWFWVlJZa2dJelVlTHl1YzlyQ3RxV0JETWpOZ1NIQ1pP?=
 =?utf-8?B?NFJqd0NvcDlzd3N4eHZaaklVSElCM2hySC8xbUpiL3k5RkppakpPa3JhRWVE?=
 =?utf-8?B?MUR0QTlXbEpDeEUrR2s4RUw4SUU1RWpONHlvcWxLMGdKY3h2MGhtQ2lDaEdk?=
 =?utf-8?B?YnNPV1Z1clB6c1dienBDcVlNU2RkMzNrazRvaHBqajE3OE5tQlZoQm5lNlFY?=
 =?utf-8?B?ZlFobU9yWUxKb1JaaU5ESzRZRE5lSGNRdCthVTF1eXRQUHNTVWpTdzVnRW9h?=
 =?utf-8?B?L21xa0x3T3NKN2tacWtxZFRldm1IMVN0cXdlRDc0WDBBWnpFU1Jqd2VsY3Ur?=
 =?utf-8?B?NEppbm9wbENqTkJtaW55L3ZQV09VMXRwcU1vNmJTUE82cXRTU0JudmJFUlZ1?=
 =?utf-8?B?RGZDaG5CcmJjSW0zajQyalA0YzdycjdLd0g5Nk5ldGJvbk4rbm9GUzlpYlpv?=
 =?utf-8?B?VUtxSk1DMXQyNm9TdmtjSG9mSzNmcEdRTC9xRVlqY0g5Nkw1RHRZTUhyY0Zk?=
 =?utf-8?B?MkZCRGpUdzJIRFR0dzJqRWxDTmcza1Y5S0QrNVlyQi9xSkd1aUU3NXUwejhN?=
 =?utf-8?B?Y001d2RYaTErYmVEeElQQWJ1WnpDNlpuNWtBdWdNbFVwcTQrYkNKdVJab3l2?=
 =?utf-8?B?VndVTEVOc09pa1FTYXpkMDNqM0lrTmtKTVNyVmdwSFNoSmFjdFovT0NBWW03?=
 =?utf-8?B?S01aZjBoVE42OXFFQk94clFLeUt5RWlVQ2g1akM0eW4vQjVUQzNRVmUxRlQy?=
 =?utf-8?B?K2JGUHZMS2NBU1l3UTJsSXRLaHlGa0FSQ2NFYUZESjdlMlNZTWQ3NmFjZExQ?=
 =?utf-8?B?RjlsMjI0RWNGYS9LRUZyM3d1OC9EVHdQdHFEQkd1UU1HZEJGdDR4OTZLUXVT?=
 =?utf-8?B?ZXpOd2toQ0dvRFJQN1o3LzRQRWFoVkw2T3JSdnRHNG1Bc1RhR1pPQU5BU0pJ?=
 =?utf-8?B?UklFMGloUCtXWUYrbzJTcE9ib1RhMnVNd0hMSm5DSlhVdy84OWRWZEtTdnFS?=
 =?utf-8?B?b1NyK3RRUGlJL0xaTVBIK1NkRGZHWjkwbGpCRlJ1ZXY4ajhyQXhiQ2gyeVVz?=
 =?utf-8?B?U292NFZZQkpwdi84VC92N0hlclNFN0x6VUhwNUZtRzBFNVRWRkNScU5FcUEv?=
 =?utf-8?B?NnFBUk1MZFhLblBwZk96Y3JqM1FnNmNRR2plVTR1WDVxM3p4UnBaMlEwQis1?=
 =?utf-8?B?WG9Nbm9jZlN1V2RoY1NNL0dId2VaUEo2ZUNidVJ1aExyQUVYcE5CK2RPUkhY?=
 =?utf-8?B?NitTcHNUMnFMR0RUUGtDVXUzK2ZLek00WTZNNm85cUtyNnlJS1ZsWDZmMFBn?=
 =?utf-8?B?VEduNWtVREo4eEJ5c3ZYektnUXpPOFZybWgwUUppVktySWFsalZ3a1ZPTXBl?=
 =?utf-8?B?TCszR2ZzS0sxSmhxN0lIQ0RzczRIMWJkV29rak5xZDVBOFl4ZFoxYTJzaUNs?=
 =?utf-8?B?MDJCN2dpcDRJSldrdnhpTlZiOURDL2VJeFdPUWpaSk5LZGZyWEN6RzBkR1M3?=
 =?utf-8?B?UDkrUnpjcThRZ3pXbi9ZVm5pcE0rTFRBcVBBNnh6UGVSajFLTmszaFBzd0Qz?=
 =?utf-8?B?QXN1YTlrbEEzSlpmc21JNG9WUHFacjRQd1ZZdy9NL3kweDRGemIyWS8vcXMz?=
 =?utf-8?B?Z2d3MUM3bm5HdE41bFp5L00rK1AvNHA5SW9FYnUxT1VKNjN6eFQ2WE9sQU1U?=
 =?utf-8?B?MnlyRTNqeUNnekJQSlZ4Mmw1V1hWVWYyazRzUnBOZk9KY2RzU3p6TDhHWlJ0?=
 =?utf-8?Q?Jq2oG3f7m8b99e4fKg=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06182430-0148-4ab4-afb5-08dc047e18a9
X-MS-Exchange-CrossTenant-AuthSource: OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2023 12:44:40.8351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB3079

O Sun, Dec 24, 2023 at 03:50:01PM +0800, Andy Yan wrote:
> According to the sch, the gpio control sys_led
> is GPIO0_C5.
> 
> Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
>Reported-by: zhangn1985@outlook.com

Reported-by: Zhang Ning <zhangn1985@outlook.com>

in case if have rev2.

> Closes: https://lore.kernel.org/linux-rockchip/OS0P286MB06412D049D8BF7B063D41350CD95A@OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM/T/#u
> Signed-off-by: Andy Yan <andyshrk@163.com>
> ---
> 
>  arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> index 1c6d83b47cd2..6ecdf5d28339 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> @@ -455,7 +455,7 @@ &pcie2x1 {
>  &pinctrl {
>  	leds {
>  		sys_led_pin: sys-status-led-pin {
> -			rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> +			rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
>  		};
>  	};
>  
> -- 
> 2.34.1
>