Received-SPF: pass (google.com: domain of linux-kernel+bounces-10803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 23 Dec 2023 14:12:24 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Luis Chamberlain <mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	Iurii Zaikin <yzaikin@google.com>, <linux-kernel@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] sysctl: remove struct ctl_path
Message-ID: <20231223131224.phe54a3smekirek3@localhost>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="6e4yjwcz57irya7w"
Content-Disposition: inline
In-Reply-To: <20231220-sysctl-paths-v1-1-e123e3e704db@weissschuh.net>
CMS-TYPE: 201P
References: <CGME20231220212343eucas1p2f905cf62bec100412a4ecdabe8916619@eucas1p2.samsung.com>
	<20231220-sysctl-paths-v1-1-e123e3e704db@weissschuh.net>

--6e4yjwcz57irya7w
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 10:23:35PM +0100, Thomas Wei=DFschuh wrote:
> All usages of this struct have been removed from the kernel tree.
>=20
> The struct is still referenced by scripts/check-sysctl-docs but that
> script is broken anyways as it only supports the register_sysctl_paths()
> API and not the currently used register_sysctl() one.
>=20
> Fixes: 0199849acd07 ("sysctl: remove register_sysctl_paths()")
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
>  include/linux/sysctl.h | 5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
> index 61b40ea81f4d..8084e9132833 100644
> --- a/include/linux/sysctl.h
> +++ b/include/linux/sysctl.h
> @@ -210,11 +210,6 @@ struct ctl_table_root {
>  	int (*permissions)(struct ctl_table_header *head, struct ctl_table *tab=
le);
>  };
> =20
> -/* struct ctl_path describes where in the hierarchy a table is added */
> -struct ctl_path {
> -	const char *procname;
> -};
> -
>  #define register_sysctl(path, table)	\
>  	register_sysctl_sz(path, table, ARRAY_SIZE(table))
> =20
>=20
> ---
> base-commit: 1a44b0073b9235521280e19d963b6dfef7888f18
> change-id: 20231220-sysctl-paths-474697856a3f
>=20
> Best regards,
> --=20
> Thomas Wei=DFschuh <linux@weissschuh.net>
>=20

LGTM
Reviewed-by: Joel Granados <j.granados@samsung.com>

--=20

Joel Granados

--6e4yjwcz57irya7w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmWG3K4ACgkQupfNUreW
QU/WVwv/TO2btpnDtp9v97DpO8pENbO9EQa2espWDa3fGysdCTiumu7W45gzF6s+
r/gf+iukRudvW0qf2AmS7RoHYy22cm2L3DkAyCrSA/wiJj3CQ5VDF6LoWDP+xMsW
pLWatMhJWeB3lO3h4ox4h1EN+XR55nzvmxo/RNupMp6MnUjbVa2Nk0PgqY+VGrZm
rPRHeFBBPgnZ8hTB8NhuCP4dQrMp9N1V/CxZY3+Qd5Pr3fCpvbnfYMj4KKLLyxSa
qvXYIN1GSY9VXkHt088ExRQWEKvxa9E0ifkw1gfEgQeFGcaU3S8wl9SfhabZcr72
ShRpbw1sdn3YiIvbY67nXbs+W1KLC+ORcXgPhMM8+Pb8lIHDoVNMNcRSWiIw0aRC
omJCv/sGe7edb9NMITU3IAFfJvtDQ1iL5xILHzhKueRqFT78Js3jfZa8ibH2gTPc
X582f/AC8ccQcoJwHaa1KZzPUe3sBgV+tjuJ+pfBO9jd17j2IXAhQoVaPB0Oribp
uuqU9bka
=w0Uf
-----END PGP SIGNATURE-----

--6e4yjwcz57irya7w--