Received-SPF: pass (google.com: domain of linux-kernel+bounces-10856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Subject: Re: [PATCH 1/2] md: fix WARN_ON if create symlink fail in
 bind_rdev_to_array()
To: Song Liu <song@kernel.org>, Li Nan <linan666@huaweicloud.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
 yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com,
 "yukuai (C)" <yukuai3@huawei.com>
References: <20231221071109.1562530-1-linan666@huaweicloud.com>
 <20231221071109.1562530-2-linan666@huaweicloud.com>
 <CAPhsuW5SPiy5bsSfagYrSLa3JTn2Gw0VJKUToS2PS9h4w2=zSA@mail.gmail.com>
 <d00e6729-6e13-b1ab-0991-ce79b1245cfd@huaweicloud.com>
 <CAPhsuW6CBdM=8kmZDwQ2Ko4rN3cAW6z0=LpAOc+_t--FJZO9KQ@mail.gmail.com>
From: Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <3cf95141-0cdb-9e67-16a9-4c64b3251885@huaweicloud.com>
Date: Mon, 25 Dec 2023 09:35:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAPhsuW6CBdM=8kmZDwQ2Ko4rN3cAW6z0=LpAOc+_t--FJZO9KQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

在 2023/12/25 9:11, Song Liu 写道:
> On Thu, Dec 21, 2023 at 5:17 PM Li Nan <linan666@huaweicloud.com> wrote:
>>
>>
>>
>> 在 2023/12/22 2:58, Song Liu 写道:
> [...]
>>> In general, I would like to avoid adding flags if possible.
>>>
>>
>> This flag is mainly used to fix deadlock in next patch. Or should we
>> export bd_find_holder_disk()? Link hodler if it return NULL.
>> just like:
>>
>>     rdev_for_each_rcu
>>       if (!bd_find_holder_disk)
>>         bd_link_disk_holder
> 
> I was thinking we will not need the flag if we fail bind_rdev_to_array()
> on error (below).
> 
>>
>>
>>>>    };
>>>>
>>>>    static inline int is_badblock(struct md_rdev *rdev, sector_t s, int sectors,
>>>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>>>> index e05858653a41..d6612b922c76 100644
>>>> --- a/drivers/md/md.c
>>>> +++ b/drivers/md/md.c
>>>> @@ -2526,7 +2526,8 @@ static int bind_rdev_to_array(struct md_rdev *rdev, struct mddev *mddev)
>>>>                   sysfs_get_dirent_safe(rdev->kobj.sd, "bad_blocks");
>>>>
>>>>           list_add_rcu(&rdev->same_set, &mddev->disks);
>>>> -       bd_link_disk_holder(rdev->bdev, mddev->gendisk);
>>>> +       if (!bd_link_disk_holder(rdev->bdev, mddev->gendisk))
>>>> +               set_bit(SymlinkCreated, &rdev->flags);
>>>
>>> Shall we just fail bind_rdev_to_array() if bd_link_disk_holder()
>>> returns non-zero?
>>>
>>
>> I keep this action because of commit 00bcb4ac7ee7 ("md: reduce
>> dependence on sysfs."). Fail bind_rdev_to_array is good to me.
> 
> I wonder whether the assumption in 00bcb4ac7ee7 is still true. If
> bd_link_disk_holder() fails for valid reasons, we need to handle it
> properly (set a flag, check the flag on unlink, etc.). If we only fail
> bd_link_disk_holder() on extreme cases (ENOMEM, etc.), we can
> just fail bind_rdev_to_array().

I totally agree! Currently, bd_link_disk_holder() from md won't return
-EINVAL, it will return -ENOMEM or -ENODEV if underlying disk is
deleted, which means bind_rdev_to_array() should fail as well.

The only problem is that this will make next patch more complicated, but
I think this can be solved.

Thanks,
Kuai
> 
> Thanks,
> Song
> .
>