Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp2302622rdb; Mon, 25 Dec 2023 05:12:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaEJW0MD5aPF0yGXR5aTQsZDWzW2/8PzNXc7BoropSUmWS3LzV2GheRzTiogVX6QofvRi2 X-Received: by 2002:a05:6214:9a6:b0:67f:ce32:e153 with SMTP id du6-20020a05621409a600b0067fce32e153mr2609643qvb.110.1703509955354; Mon, 25 Dec 2023 05:12:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703509955; cv=none; d=google.com; s=arc-20160816; b=JpkXwDjSp+thGjbSaUG8n0aUOthgbMDNvNRCH0LXMg83QnumwN1radaBbmXS/G80RZ gYEnQsPjlaNMYI38Ep3MsKmFvZ9OqEqWkm7OawPxI2nE3QQGGb0c9K34xgZ31yuZ1pKl +UUGIqEOEwu35n8/I2SUFAEO1AOLyH9iHkfQ4rSVLCFoV789KrIwyn14dqvSu6aOci71 gF5ztGtdxAecTOdKs+GGvct5oY0N3OLCfzItnf0QAMezd4+ICuSDfgm4TPYgS3hEUwEa tIcBx9s9BW3nZ6wVygrOFLBrB4u5IDBMu6Ik0/ljp2eyZpwY5Mrf6CXDHUQwD7zaRIw2 Z+8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=i+K2pdjExcB5W62sjk3ptIA5akO9+GQ6cCv1kcMP6pw=; fh=RMcur3Cu6uw3rEjgZLG0Kkzp6YyiaM1p3CYqw/jIQ7w=; b=T7HLFWSh6xgfZZJmJ79AFTdXgO8rERtHyR3Pas0gZ4JVp8SJ3A5KziZsGhYq5PhB8w Rexl83MSex4RyYIRuc62Smw5PSCuL8q0gkvCC924DTpLE4XEaJda7nmm4n4XZSyLb3Hy x5yiuNAJpfroPIOIHWzrfy1HXhab+wwminUepzWqbJc56Qplg6f4Ez7NdUVoEQUr0vfm HKM9t0KR7pYiTQN0jRT5BuWQIGgIHdjfcvO9Ct6nQGfB+NNio9r/MhKXq1a/8U2B6ez9 jMG+Cgh9CrWkacMNbkBCXMdrhCNhm1DD02eKxBNfzk9I/Io/uef8+STB6s+kSQAyFUIs xfag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sCb5aHhJ; spf=pass (google.com: domain of linux-kernel+bounces-11059-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w16-20020a05620a425000b0077f8a61c9e6si10928761qko.718.2023.12.25.05.12.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 05:12:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11059-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sCb5aHhJ; spf=pass (google.com: domain of linux-kernel+bounces-11059-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B1F571C214D6 for ; Mon, 25 Dec 2023 13:12:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D391551C5B; Mon, 25 Dec 2023 13:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sCb5aHhJ" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 830EA51C46 for ; Mon, 25 Dec 2023 13:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a269a271b5bso425862666b.1 for ; Mon, 25 Dec 2023 05:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703509942; x=1704114742; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i+K2pdjExcB5W62sjk3ptIA5akO9+GQ6cCv1kcMP6pw=; b=sCb5aHhJvY94j5aVa4QZilKfr4QeDq/daDSPDXWXJLx7Vmfu0CYcBCRKQAaExjqJu1 Tu6b15FwKd+k9lj/yxZ8JlQeObLCl8f5Li+RHoiix54fvgP0q5DueYn8/Tnf+sbjUrwh OawgbEn2CEs/NcnjKyk2YBQRfCEmWibPgZOrVtPlVf8RqCYFpyD6eUyoo5IdFFSK0N+7 yZ3V8arcmjMC9s7EGSBzGokbuV9k3zmcWFl97wWpLdAVWScz+nNbOT+9mRhQ1GrEkZIT HBYAboNzuF5wHzUiz/dmFrJPegjbG1/WYj6ffQByWmtYujCFoPTgkjoEZIrSu0GEXGD4 Fjbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703509942; x=1704114742; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i+K2pdjExcB5W62sjk3ptIA5akO9+GQ6cCv1kcMP6pw=; b=Tml1DjD4h3CgVoT1xy58EDuuXN31o2kETfJwlnglpeXONE6dbl3chl62jdlPPROVv5 SwVRpJ99k6jr2L9GEMNbWdsXuJYKaPrLJCzu5DAAPMdrZZVgipDJe6ZasuzMk3ja61U+ cET+ptq1/he/ZqvW4257XA3eJ3iKHGzpBkLauTuJWMx5RF/zcy0vsIWc9l6aYPzIujmV rxwzl3l5mwCZs2uPC4ihBJhY4S338qsABuy05h/+98GuCx1FANXZVrGezCpyttlVhPYk PzeXPDD69WDuIX+lvExVXMaBG0djo+7aSbRe1SbdBKxtfVsoQyFTWyQUk/2bsCdKRhOr nUqg== X-Gm-Message-State: AOJu0Yy1kF/BE8rwoSHGMs+m0hQ5nfQnlfao2QeR8iEbYMvPo5hdwNBS SV3g96PVQJfXcgv2qJy270nAl4Mja9znlg== X-Received: by 2002:a17:906:4892:b0:a19:f69e:1d3f with SMTP id v18-20020a170906489200b00a19f69e1d3fmr2378782ejq.71.1703509941899; Mon, 25 Dec 2023 05:12:21 -0800 (PST) Received: from [192.168.0.22] ([78.10.206.178]) by smtp.gmail.com with ESMTPSA id jt4-20020a170906dfc400b00a2369d8ca07sm4829683ejc.203.2023.12.25.05.12.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Dec 2023 05:12:21 -0800 (PST) Message-ID: <74711d84-4c43-431e-8e7c-95753f4c8815@linaro.org> Date: Mon, 25 Dec 2023 14:12:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Content-Language: en-US To: Shenghao Ding , broonie@kernel.org, conor+dt@kernel.org Cc: robh+dt@kernel.org, andriy.shevchenko@linux.intel.com, kevin-lu@ti.com, baojun.xu@ti.com, devicetree@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, 13916275206@139.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de, peeyush@ti.com, navada@ti.com References: <20231225053932.1138-1-shenghao-ding@ti.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231225053932.1138-1-shenghao-ding@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25/12/2023 06:39, Shenghao Ding wrote: > Move tas2563 from tas2562.yaml to tas2781.yaml, because tas2563 only work > in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for > tas2563, it has been moved to tas2781 driver. As to the hardware part, > such as register setting and DSP firmware, all these are stored in the > binary firmware. What tas2781 drivder dooes is to parse the firmware and > download them to the tas2781 or tas2563, then power on tas2781 or tas2563. > So, tas2781 driver can be resued as tas2563 driver。 Only attention will > be paid to downloading corresponding firmware. > > Signed-off-by: Shenghao Ding > > --- > Change in v3: > - remove tas2563, which will be move to tas2781 driver > - Add more comments on why move tas2563 to tas2781 driver > - provide rationale in terms of bindings and hardware, not in terms of driver. > Or at least not only. How did you implement my comment about squashing? If you decided not to implement it, why not dropping a note? Best regards, Krzysztof