Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp2318636rdb; Mon, 25 Dec 2023 05:53:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IErju6xPuGUB9Z+TtY/5+vYyT3z86v9THwvh/RgnsqlugbAns6wN9H9AahDwNsFO9MKVLmN X-Received: by 2002:a17:906:25d8:b0:a23:69ea:659e with SMTP id n24-20020a17090625d800b00a2369ea659emr2573160ejb.136.1703512387867; Mon, 25 Dec 2023 05:53:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703512387; cv=none; d=google.com; s=arc-20160816; b=huSbsbNf3JdORRB6G93FxpeO0mjtbD42J8skBOxUQgbpPlVAuXWkGMcN4nlkc9dVPX SNdEc/qkynxmXgwNQSmvPJNugYHBPa/S2MXdePB0yn1elGKC+KRP7h3fIKdl9zRcrJie isVBUrKg1g5mcIwXbKK94pVQgoRqq4SGK2AWytEL4Gl4Wf4DnDVRhtB5edcYhPlC2fX4 fhDQa3hW6YvzAIpycfVsGBJZA0/N26pviHLGpGM95htXG+4a05yWlgimBu2g1PaOAe5l sDiu7wgd7W3InwL4BWvKKgLFbvNN13DhMSpIcDO7T3jCI/eojndL/gI9+yBx9lgcKG/i ZR9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=P7pzHNGgaJ9I2e8M8+mp0l9BkmoY6S2EZybdTdnH+08=; fh=zq/kTYSb4kHUAaxkWUbvmqC+sl7O3x4rrdIXSgxAw+w=; b=WHf2FRFkLhcfuwoDg0ljL1WrFoEpd3RACzkSJ2afoHHcdmk7jBsgHBjT9Z+9xQ3pne H/KRCxlUoonLrBr/zduOVajKyBs1ISQkGMNry2jDUBLkxbxpB6TN5APDiN7sMBnUcfak e8Oed2EjP3htZw2+LdBD1ofl6w3m28sW++X53l6Sa9JDe+ZaBrrDXQnT9jLyM57ICM9k PT3qgGkK6THe2blGpIzE2c4hYIIt0W3FrLB3TR0qW5oKKRYE4MJnp9jQ9fQEje/rcZ7N sPfCVum8Yu5H4z7DstA7WkQ3gAMGXvJCszIpryrWJ1G3TnaY7+KZp8BV2XvXvNkavl6f oMLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-11075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h18-20020a17090791d200b00a26979c3264si4290851ejz.151.2023.12.25.05.53.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 05:53:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-11075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9CF211F22171 for ; Mon, 25 Dec 2023 13:53:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87777524B8; Mon, 25 Dec 2023 13:53:01 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mail-m6015.netease.com (mail-m6015.netease.com [210.79.60.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8D6F524AC for ; Mon, 25 Dec 2023 13:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=easystack.cn Received: from [10.9.0.134] (unknown [211.103.144.18]) by smtp.qiye.163.com (Hmail) with ESMTPA id EB78C4C0290; Mon, 25 Dec 2023 21:44:02 +0800 (CST) Message-ID: Date: Mon, 25 Dec 2023 21:44:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] x86/kexec: fix potential cmem->ranges out of bounds Content-Language: en-US To: Baoquan He Cc: Vivek Goyal , Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231222121855.148215-1-fuqiang.wang@easystack.cn> From: fuqiang wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVkaGEpMVk5KTxlLTExNGR5KGFUZERMWGhIXJBQOD1 lXWRgSC1lBWUlKSlVKS0hVSk9PVUpDWVdZFhoPEhUdFFlBWU9LSFVKTU9JTE5VSktLVUpCS0tZBg ++ X-HM-Tid: 0a8ca137e1fd022ekunmeb78c4c0290 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MRQ6Nzo5STc#Fy4DGT0SIzgR Gh0aCxBVSlVKTEtITkpKQ09ITE1PVTMWGhIXVR0OChIaFRxVDBoVHDseGggCCA8aGBBVGBVFWVdZ EgtZQVlJSkpVSktIVUpPT1VKQ1lXWQgBWUFJS0xCNwY+ 在 2023/12/24 12:46, Baoquan He 写道: > Rethink about this, seems above code comment is fine to be kept, and the > same feeling about the elfheader region split from crashk_res. So, other > than the patch log concerns, this patch looks good to me. Let's see if > other people has concern about the newly added comments. > Hi Baoquan Thank you very much for your suggestions in the patch log and code comments. I have learned a lot and I will gradually improve. I found the following patch in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=666ef13f2870c43ba8a402ec8a3cedf6eb6c6f5a I'm sorry, It's my mistake. Do you think it is still necessary to merge this patch based on that ? Thanks a lot again fuqiang