Received-SPF: pass (google.com: domain of linux-kernel+bounces-11152-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <07ca2474-560f-4cbb-9740-db987227416a@web.de>
Date: Mon, 25 Dec 2023 20:18:44 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Jonathan Hunter <jonathanh@nvidia.com>, Justin Stitt
 <justinstitt@google.com>, Kees Cook <keescook@chromium.org>,
 Mikko Perttunen <mperttunen@nvidia.com>,
 Thierry Reding <thierry.reding@gmail.com>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] firmware: tegra: bpmp: Return directly after a failed
 kzalloc() in get_filename()
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:9EhpqDUh4eU=;/MCHgEjnuTlr8ORYlyOXc1Ibztp
 P/eDlh0Xd+VwkT1u2/mXCgGa0USATF/EuWmdAFDe1/szSxKf5GLUmE3cd9TZX4wh0DdT6Buf2
 J0ZBXt2zDnr9ABwV80Nc26px4XJct7b1M/KpCpPv73FF9vZ4HD/1I2hi7XSoLRSsg+yn62Qcj
 clL/Do5LfXZ81gDQOCaQtImxCDgY4aqmnfviideEoQ4Vx/PgUY58pHe3she58E7CxCwKdVPw1
 ABQxnrQ0mx2iuIvYf7TfPWlgx1rH+gghNu8XFJftZw4NIlZ5W6CW9XiZGWyqKqAPnb3ABlag4
 HClPdWbN6x5Duk/c1zdKLE9o7GrGzzrAjm/0VCKuxiUxZBpKcUyBjdDYRg1jL12t9VLUc8eUR
 I9fEWTWTLwvgqpztDIoNn7rkdeu90iqM0xZi5JN6TFQ/m3DKF6NuCqfTWrO/arBGuMpY29VWM
 YUtI6to0e8O7Z6c10nfbFW0ZkvcT+tFVUxxDD7yCuKUv2ZFsm+bpCb6fiBB/LnWN4+kDtRAzP
 X3vkUQZA49LI2dgeQHtjJIibEY0notIcdDLkW9KLjN1fvEeSWVgWln9i8DVCi6sWhpOiGEwp6
 s5I7FzyatBNPgruwLuADNTDj3rfXrFlo59zgn7S1zSkLcs6OGiA3dGAjagN5AB+RrjKFI8mdn
 /N07gXIcvYNZJBAfSzp/hJVxyplUFjV6zCEYZcUXlOLgcdqPOduphTekxQO+59rix1Ihy5+IC
 n7LxF9c1hOHSxdnhwUklF0FuSVtboT4ZmkQrckEYwtMNtBrQ+LXaET6fs957iv88kN7CvIdAr
 EI742ipRd1pzF7p1KBU/rbkVLqSAuDL5o70sxru9jvvJfkoASUH1WcfO8nXsSlGp+V1ERAjya
 NAHQTFWsfnKtsoObvMiACa3sRALKBRGVgmz4lugo9HFoVV3kNKYqT6Dw2+pFBYuoXz5M+FOHL
 7jfSNg==

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 25 Dec 2023 20:03:56 +0100

The kfree() function was called in one case by
the get_filename() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software.

Thus return directly after a call of the function =E2=80=9Ckzalloc=E2=80=
=9D failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/firmware/tegra/bpmp-debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/tegra/bpmp-debugfs.c b/drivers/firmware/tegr=
a/bpmp-debugfs.c
index bbcdd9fed3fb..4221fed70ad4 100644
=2D-- a/drivers/firmware/tegra/bpmp-debugfs.c
+++ b/drivers/firmware/tegra/bpmp-debugfs.c
@@ -77,7 +77,7 @@ static const char *get_filename(struct tegra_bpmp *bpmp,

 	root_path_buf =3D kzalloc(root_path_buf_len, GFP_KERNEL);
 	if (!root_path_buf)
-		goto out;
+		return NULL;

 	root_path =3D dentry_path(bpmp->debugfs_mirror, root_path_buf,
 				root_path_buf_len);
=2D-
2.43.0