Received-SPF: pass (google.com: domain of linux-kernel+bounces-11167-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 25 Dec 2023 22:29:26 +0200
From: Petre Rodan <petre.rodan@subdimension.ro>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andreas Klinger <ak@it-klinger.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 03/10] dt-bindings: iio: pressure:
 honeywell,mprls0025pa.yaml add spi bus
Message-ID: <ZYnmJjUJjYZHxfUM@sunspire>
References: <20231224143500.10940-1-petre.rodan@subdimension.ro>
 <20231224143500.10940-4-petre.rodan@subdimension.ro>
 <b23a6b74-a568-4e11-8429-6344e10a9937@linaro.org>
 <ZYmcNySur-ZQryWc@sunspire>
 <1b54a167-1c90-46b8-8a7b-a21f5d4655e7@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="2af24PaiwPbcA0FS"
Content-Disposition: inline
In-Reply-To: <1b54a167-1c90-46b8-8a7b-a21f5d4655e7@linaro.org>


--2af24PaiwPbcA0FS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 25, 2023 at 07:56:24PM +0100, Krzysztof Kozlowski wrote:
> On 25/12/2023 16:13, Petre Rodan wrote:
> >>> @@ -88,6 +88,9 @@ properties:
> >>>        Maximum pressure value the sensor can measure in pascal.
> >>>        To be specified only if honeywell,pressure-triplet is not set.
> >>>
> >>> +  spi-max-frequency:
> >>> +    maximum: 800000
> >>
> >> So you miss allOf: with $ref to spi props.
> >=20
> > for simplicity's sake and for compatibility with the i2c devices alread=
y in use,
> > this driver does not have distinct 'compatible' properties for the i2c =
and spi
> > implementation.
> > this is why I just defined spi-max-frequency, used it in the spi exampl=
e, but
> > not required it. just like in hsc030pa.yaml .
> >=20
> > without a differentiation in the 'compatible' string I don't see how yo=
ur request
> > can be implemented.
>=20
> You cannot have different compatibles. I did not propose it. I wrote
> nothing about compatible. I wrote about missing $ref in top-level for
> spi-peripheral-props. Where do you see anything about compatible?

sorry, for one hot second I thought you want that property to be conditiona=
lly
defined, like

allOf:
  - $ref: /schemas/spi/spi-peripheral-props.yaml

  - if:
      properties:
        compatible:
          contains:
            const: honeywell,foo-spi
    then:
      properties:
        spi-max-frequency:
          maximum: 800000
      required:
        - spi-max-frequency

but I guess you only want the first two lines from here.

happy holidays,
peter

--2af24PaiwPbcA0FS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE2Ap/wXYVGTXsPl+pzyaZmYROfzAFAmWJ5iEACgkQzyaZmYRO
fzDdARAA2M3MPZmM2mQ2vxbYaO7I4LWYIAZXE8AR8WBD5W95ulhz9smCSG4OOBeq
Y6QQmzOBz6UiotQa9gSwSXIUt/bU625TQ4aFIB+o0Cr5oAHJEQFxR3h8ZlGR9Dl5
eD7W29Pryq1Ila5Bp+AZV2va1cVqo4AnfE4nl3z5kw8G0tKzISK2W4k+J0JE4Goy
ak4/kH7OsKhzYeC4OZ8Tn5IMz9Qvg+frXvf8Zl+Q6XrRV0uJzJ+q/EyO57qz5775
eUijBCxZpldg2WRWMYkDqfIUM/X60397c78NNKj29Fb35ZtQw9+hoLRi6f+Zxzdr
bWRHUc1CmqhP6qS+scVEB39yanclLp1c6FPsIC/wQgyVI0t/ZkYaZ6W4UebqKFL4
vxY0zXmo1dyPd/40mICn9KG6dqNAwk73/wF/JUv/TtxEb8W1Bj8VcbmuPR9n+Shx
43tw22qgu54O5qukS7dGALJdSOivUAg4XlvuQsV7kPXwrya9QSjxEyvW8v8QmFPj
AGRwpyJ17mfrwoGVJphi/9Q+ZEoEAkjjmqG8TVzUiFMWeuMDTZUd7atvFjoLX6l9
nWBmko2CVBTleSvQgEiNjcDZM8sWsTcfLBaaO3tkjnLXSnZmKyxYdhGQIpdUK3lI
tnZhycHQYm7nns+xTp/+C/ikvywTf8tmA8hQrWJ3QbEqqB6LYuo=
=9FKe
-----END PGP SIGNATURE-----

--2af24PaiwPbcA0FS--