Received-SPF: pass (google.com: domain of linux-kernel+bounces-11189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 26 Dec 2023 07:31:49 +0800
From: Baoquan He <bhe@redhat.com>
To: fuqiang wang <fuqiang.wang@easystack.cn>, akpm@linux-foundation.org
Cc: Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] x86/kexec: fix potential cmem->ranges out of bounds
Message-ID: <ZYoQ5ej3uDKt5rmw@MiWiFi-R3L-srv>
References: <20231222121855.148215-1-fuqiang.wang@easystack.cn>
 <ZYWPHSmwK8iG6xUr@MiWiFi-R3L-srv>
 <ZYe3iN816iiKDwIu@MiWiFi-R3L-srv>
 <a65e7a06-bc91-4c82-9a65-6066f9f64409@easystack.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a65e7a06-bc91-4c82-9a65-6066f9f64409@easystack.cn>

On 12/25/23 at 09:44pm, fuqiang wang wrote:
> 在 2023/12/24 12:46, Baoquan He 写道:
> 
> > Rethink about this, seems above code comment is fine to be kept, and the
> > same feeling about the elfheader region split from crashk_res. So, other
> > than the patch log concerns, this patch looks good to me. Let's see if
> > other people has concern about the newly added comments.
> > 
> 
> Hi Baoquan
> 
> Thank you very much for your suggestions in the patch log and code comments. I
> have learned a lot and I will gradually improve.
> 
> I found the following patch in linux-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=666ef13f2870c43ba8a402ec8a3cedf6eb6c6f5a
> 
> I'm sorry, It's my mistake. Do you think it is still necessary to merge this
> patch based on that ?

That patch need be withdrew because that is not expected according to
our discussion.

Hi Andrew,

Could you withdraw the patch fuqiang mentioned?

x86/crash: fix potential cmem->ranges array overflow
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=666ef13f2870c43ba8a402ec8a3cedf6eb6c6f5a

Thanks