Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp2539760rdb; Mon, 25 Dec 2023 16:39:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCE1hgueoHl8/UQdEMnrSkdEfYFkNcPFbBIkZLZoAiyB4qOQEXskpl4qR3bjgL1XO4GNMN X-Received: by 2002:a05:6e02:1649:b0:35f:f7f3:4c21 with SMTP id v9-20020a056e02164900b0035ff7f34c21mr2576320ilu.68.1703551165553; Mon, 25 Dec 2023 16:39:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703551165; cv=none; d=google.com; s=arc-20160816; b=joSUZnLvwOvoY6tC3qzmdp+Alpsc/497BER+R0FdUYwhKiikhS0XSLHjHY7tN7fl/I CKqVivR7ByJ+UEEPQP9zL0fuwLxNvbYu9EiFFqh2at/Rz4cabSbNEWVC22jMn13Wwgca +lsOUcJNBsJ37kRxdK8i+tYzDK0xlJOeq0OfCnN2WvKFXWcvATgtIL28GQrZZ4EAT5gR u1s6F4zSvh6vTvOQEbfFSajZa+oSJO890o6Ob1sqESoeF+7gu8jrm7Ar7fiV2XewQlCF DGqFGi3rP1LZv4WwGEFwsmWpFcAj9TmNwfLMDPm0yEtT/tJdou4m8kVvHHxl7j7bK3sb hkXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=M7xIiYdqfnEYm8pdaNv7vMK1pVBgcewewogL8Qbc/ss=; fh=eaGxAF08Gq8ZPNUtnCmQ0IxNT9eOLVPa8HFLTPsrikM=; b=oTrBwZfcS13N6G0UoGFSi5tZV84Vqb1bmpIn9YliVY84EgvUoJCRqCjbmwqjvm+YGI EurbvEvMr6u28zIRWdlYStQ2CVu3/v1k5Fqim2vfiIJxIDnWWV1YqNMeKzEHYrVKVNqV AXRVZGIQ8w9tDTY+SIBJig/dQ7dw3420bqvJJuiuNIKPEDrwEsa8qnHEJwsOiPpUJyhd iIvfR5R9CtWgrM/FOxSxciXlPzWycAiPA4tyCjxbvuE6U1QK0WlxD/B843eISX0cECeE 0xt7TQg/JQTfDSxxZ9ON3Eb89yCga5hm5xAtHvmM/s/posTaJXWa4U3iAHQVL8nRtkDW sCeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=erQugn+T; spf=pass (google.com: domain of linux-kernel+bounces-11254-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11254-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x29-20020a63171d000000b005c668dc2426si8630814pgl.176.2023.12.25.16.39.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 16:39:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11254-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=erQugn+T; spf=pass (google.com: domain of linux-kernel+bounces-11254-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11254-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8E98AB22433 for ; Tue, 26 Dec 2023 00:36:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9265259927; Tue, 26 Dec 2023 00:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="erQugn+T" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5BF35916C; Tue, 26 Dec 2023 00:23:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0A0DC433B6; Tue, 26 Dec 2023 00:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703550236; bh=S3WABjvm4trviiu3emPkc/9hxdtUAqhIyZWTzOX8BH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=erQugn+TT6M/UKb4mDsUbV7FLlRl7Lo21KrsLYV2WLgen6Um9oXnXf95FYAbCE3p/ PfWpf+ycCGLR8xIYsbFFXgvIi8aCNyKzw/pgp2vcgEg/Pb0uutsGVdAqGIpquGsK4t YmPn4OiqsppUzKqd0QUk7a8dtCn6yahO2GR1Gb3UWn64xg+svE4vjOZe/uBEweZnjq 6hFbXMxpvYE6dS77u8fQQUuEp7/QYSiW7P3Cl9G40FiSVayVORCZ1p/S48bdIqGqEi KnkXGCw9WMQTR6al9lZ2msFKT0IacVzkECJtHlYC/adeFjyfSdAQ2qtYgKYNjn1HQY 7x0gXxAqwujeA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij , Sasha Levin , linux-gpio@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 22/24] pinctrl: cy8c95x0: Fix regression Date: Mon, 25 Dec 2023 19:22:15 -0500 Message-ID: <20231226002255.5730-22-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231226002255.5730-1-sashal@kernel.org> References: <20231226002255.5730-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.69 Content-Transfer-Encoding: 8bit From: Patrick Rudolph [ Upstream commit 04dfca968cf7349773126340991b68a83378aca2 ] Commit 1fa3df901f2c ("pinctrl: cy8c95x0: Remove custom ->set_config()") removed support for PIN_CONFIG_INPUT_ENABLE and PIN_CONFIG_OUTPUT. Add the following options to restore functionality: - PIN_CONFIG_INPUT_ENABLE - PIN_CONFIG_OUTPUT_ENABLE Signed-off-by: Patrick Rudolph Link: https://lore.kernel.org/r/20231219125120.4028862-2-patrick.rudolph@9elements.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-cy8c95x0.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 99c3fe4ca518e..501b7c181df00 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -304,6 +304,9 @@ static const char * const cy8c95x0_groups[] = { "gp77", }; +static int cy8c95x0_pinmux_direction(struct cy8c95x0_pinctrl *chip, + unsigned int pin, bool input); + static inline u8 cypress_get_port(struct cy8c95x0_pinctrl *chip, unsigned int pin) { /* Account for GPORT2 which only has 4 bits */ @@ -764,6 +767,7 @@ static int cy8c95x0_gpio_set_pincfg(struct cy8c95x0_pinctrl *chip, u8 port = cypress_get_port(chip, off); u8 bit = cypress_get_pin_mask(chip, off); unsigned long param = pinconf_to_config_param(config); + unsigned long arg = pinconf_to_config_argument(config); unsigned int reg; int ret; @@ -802,6 +806,12 @@ static int cy8c95x0_gpio_set_pincfg(struct cy8c95x0_pinctrl *chip, case PIN_CONFIG_MODE_PWM: reg = CY8C95X0_PWMSEL; break; + case PIN_CONFIG_OUTPUT_ENABLE: + ret = cy8c95x0_pinmux_direction(chip, off, !arg); + goto out; + case PIN_CONFIG_INPUT_ENABLE: + ret = cy8c95x0_pinmux_direction(chip, off, arg); + goto out; default: ret = -ENOTSUPP; goto out; -- 2.43.0