Received-SPF: pass (google.com: domain of linux-kernel+bounces-11320-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <11e17542-75bd-40fc-a630-71842a47fb1b@intel.com>
Date: Tue, 26 Dec 2023 10:24:25 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 1/9] iommu: Add cache_invalidate_user op
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-2-yi.l.liu@intel.com>
 <BN9PR11MB5276CE7AE7E2FDA1D8A045298C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276CE7AE7E2FDA1D8A045298C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFMzYzNTaE40M3NYWkdHd0JreEdmbGhiM2pMUTFYT3lWdTQzamJCclBxUFVN?=
 =?utf-8?B?cHEybUx2aFF5TWc4R0hERmJwSUhnb3BTR0ZPelBwQmxqMmkrV3Z6ZkFPWGk4?=
 =?utf-8?B?TkhYUVErRmlZNXJId3VlL2xWVzdsd0hLd2Q5bXdTbzBFdEhGd2t6aG8zSkdi?=
 =?utf-8?B?NnpBRE05MERmNzJhNU0zTzZWdnBvOW83b3N0U2xGeHVXWGpOZXhGUDk4WWRJ?=
 =?utf-8?B?bFFJS0c0b0g3eU9SZUVEVVU2NFhEVFV2N0dHSmd4VXFmRStTYytVUnBURWlR?=
 =?utf-8?B?U2FBclA1VnlkYWMxYm1jejduSHFLYmxMN1VtVXpkS3RHT0FtcEIwaDZTS0NG?=
 =?utf-8?B?bXZqK0tpTTJCN2grcHkvZ0V5NFYrOEk0Wkk2ODZKWGYxQUZDRG5nV3dGOVMy?=
 =?utf-8?B?QVlmRDZVOTE4c3hSbUlaYWxzalRscXdDaHRNajEvOEg4UGhicDAvVDlvWFlD?=
 =?utf-8?B?MStIc2FKM1hzMmlzcU9uWG0reEdvdjdBcXBrNWtabGdRcGRtSURMVVhLc0JG?=
 =?utf-8?B?b2l0TWsrOTA2K053WUY1ZnNSSnBlc0dsWkZuM1diU2pVNnhmOHBTZkszL2JE?=
 =?utf-8?B?bDd1NEVEcjA0VlRFcE8wSWxHSUF0VkxxYlhvckJYZGtlU0VZWXBKbnE3K2Jr?=
 =?utf-8?B?RWF4S21Hd3phY2FIcW10QThwaEZLYTJkbEc4SGUyWlZzTjdOU1JjWkpNOWJj?=
 =?utf-8?B?OW84VjRIellqOThhT3R4WjhoTFFFMTJxQ05pbVIyekhiN2lDTFd3dmFGMWJY?=
 =?utf-8?B?QThvY1hMRFQ3VE5lNlVUdTIvY1kxME5tM212N2JGaFJBVnM0clAyZzl2RFVL?=
 =?utf-8?B?dUhnamliVEhRamFKSlNSQXVqM01Fb1JhVU16di9jeStxQ1NVeGlHdWhKdWl1?=
 =?utf-8?B?MXpkd3JGOTljQUpvY05way9ackJCTmpMK1B4RUFHTTRUbXdTYTFuUkRpQXpu?=
 =?utf-8?B?a2IrbmV6VTFlbWdENUhqUExKSy9ycG9ZUHBjNHpvUGNReTNNTTJ2ejFRWDBM?=
 =?utf-8?B?ZUZDVVp5RTZaMDBFblIyR04yQU8rZmM2WW84M0JGR2dwSUVDVnI0ZWFuYjI4?=
 =?utf-8?B?ckJTVWdBNTBTL0NLYS9vM2JYek9iS3pHMDFVZU5QS3N3NCtXa0tGRW5hSUly?=
 =?utf-8?B?TVU4eURUamg4Mnl2aGxhazFTVUtNcEdtRFcxSWMrU2E5TmFxUWxwZWhoZ3pt?=
 =?utf-8?B?VFYyaWdLWE8veFNUSDRzVzNGcGc3ZmhjUGdXT0NXbFIyUHRQdlZCM09GVUxG?=
 =?utf-8?B?OHFIK0JLaFhKU0pOUUF0OTRVYlhJYmE4OEdUZ3doV3l3K1RKUDJqZ1FIbzh4?=
 =?utf-8?B?dkRLaldqZnJpVkNYWHRzeVZ2QXlXUnBuZWVlVDVSMnFyUVEyL2sxM3J3TVFX?=
 =?utf-8?B?MFVBYjV0bCtGOGUwZHVCMko0bmRSYmhrOW9uYldHbmRybjZLdjRhSlRRV2xZ?=
 =?utf-8?B?M1QwMVBSMXRGT2xQa29WeDFEV3RRdUNqSXJpTklIY3lkTjRyQjNub05lOWwy?=
 =?utf-8?B?T2MrS251QTJpN05RNWJHbzVnc3l6TTRMc0kzY0JId25VNWdJSVB2STNmM3FZ?=
 =?utf-8?B?V3JubHdhNkg2RHBYcFNTSUJxWjk1dXYxYXgraWcrdDl1Qkc2bGxITGlULzdW?=
 =?utf-8?B?LzVnTlY0WFNmSnlYR0hHVkk0ZTZqVEp0dTlJVHcwaFZDbFVCeGhCamN6TUpI?=
 =?utf-8?B?NkFVNFJONGNaQ1NTUzBwRkZJM2NvYWJ3Z0V2M25WL0hxZmJZRllBWEx6WVpp?=
 =?utf-8?B?c0U1OEtURkpNdVNoaElITXNrcWxLMDVUU2doSU9CUW4zRGVqaUUyNTh5QU1j?=
 =?utf-8?B?L0pQdFpPWUIzbk1HeUVsY2k1cGtJekkyVjByYWQ0K0pFRGdXN0ZnTGNQT2FB?=
 =?utf-8?B?VjIyc2puaVhZdE5JU2ZTNEFYNkg3SUhoVUpCR2hLNzFrTkNmQ3U3M2k1RVVP?=
 =?utf-8?B?SDcvWXowakR1Um9DSFl0a0RxSFJLVmFtcTh3VWxCdUpSNDlrUVRNWVFpaFpY?=
 =?utf-8?B?bndoblhXRTVNMEhpQzhxY2lqYTVjRERvRjlTNDNpVm5LaDBJa1NQb09EZWh2?=
 =?utf-8?B?d0JJSXlISXJ3aHFHSmxJQ0l4cldRZWFiMWk4MTcwNld3dkE1TmVzeG9GdlM2?=
 =?utf-8?Q?nV0y09Ut6mH0So8AlX9Niu23j?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf8bbc8-5139-410c-ed33-08dc05b96420
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2023 02:21:39.4792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0aXMAksF/V7ggXNSNSyokIQYXUcfpKLzF7JbkZWBkefN4od+t4JK1dLLdUjQUpZuqsd1XTUZlWgBiVXE+ocfiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7855
X-OriginatorOrg: intel.com

On 2023/12/22 10:30, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, December 21, 2023 11:40 PM
>>
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>>
>> The updates of the PTEs in the nested page table will be propagated to the
>> hardware caches on both IOMMU (IOTLB) and devices (DevTLB/ATC).
> 
> this is incorrect. the scope of this cmd is driver specific.

yes. May just say the hardware caches.

> 
>>
>> Add a new domain op cache_invalidate_user for the userspace to flush the
>> hardware caches for a nested domain through iommufd. No wrapper for it,
>> as it's only supposed to be used by iommufd. Then, pass in invalidation
>> requests in form of a user data array conatining a number of invalidation
>> data entries.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
>> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>   include/linux/iommu.h | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 6291aa7b079b..5c4a17f13761 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -284,6 +284,24 @@ struct iommu_user_data {
>>   	size_t len;
>>   };
>>
>> +/**
>> + * struct iommu_user_data_array - iommu driver specific user space data
>> array
>> + * @type: The data type of all the entries in the user buffer array
>> + * @uptr: Pointer to the user buffer array for copy_from_user()
> 
> remove 'for copy_from_user();
> 
>> + * @entry_len: The fixed-width length of a entry in the array, in bytes
> 
> s/a/an/
> 
>> + * @entry_num: The number of total entries in the array
>> + *
>> + * A array having a @entry_num number of @entry_len sized entries, each
> 
> the first sentence is redundant.
> 
>> entry is
>> + * user space data, an uAPI defined in include/uapi/linux/iommufd.h where
>> @type
>> + * is also defined as enum iommu_xyz_data_type.
> 
> I'd just say:
> 
> "The user buffer includes an array of requests with format defined
> in include/uapi/linux/iommufd.h"

sure.

-- 
Regards,
Yi Liu