Received-SPF: pass (google.com: domain of linux-kernel+bounces-11337-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <10e340be-5551-4bd1-9c0c-30254e0b1f81@intel.com>
Date: Tue, 26 Dec 2023 12:01:49 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 6/9] iommufd/selftest: Add coverage for
 IOMMU_HWPT_INVALIDATE ioctl
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-7-yi.l.liu@intel.com>
 <BN9PR11MB52766EC5BBA4888218914CCB8C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB52766EC5BBA4888218914CCB8C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDVBTFBiTUExU2NxZDQ1V2pSSnFqeThndXlhMk52d083b29iSyswWXk5elZY?=
 =?utf-8?B?RTIvZk94SUZnWlNKRlFaTDJ5cHNYajZQWUlDNklNdHE1UnhyZzRHeWg3dUhE?=
 =?utf-8?B?ZmpYcENUVDlYZVNNSGdneUFZVUFwandSSXJSbmFtdG9jcjB3VGlCYm16cy8v?=
 =?utf-8?B?RDJOOTJWczl4TXk3dUI5Vnc1WUU5MTl3TGpUQ3Z3MXMyam9WY2lEdE8zTGcw?=
 =?utf-8?B?Z0VRZXFYT204a0YrRm1iL3FMT2M5S08wZFJsM2RsdFNJY3E0SHRzdDM5eVNX?=
 =?utf-8?B?WFprVGM5TU15UGhtZ2xGNm1WR05HNnFsZXQ0cnlqOHVDcXgzckVURUtuTy8w?=
 =?utf-8?B?QVRzQnpGREdiQjVWdWRBSnhkRkxPd29lZjZXdVBpMWZVbkNUZEQyczRKbGNZ?=
 =?utf-8?B?RzU1dnUxVlhEWnYrcllIZWJXSC8rQTVjS2sxa3hNUUwveE94clBNMlNOcjFm?=
 =?utf-8?B?WnJFRGxtQ0NBeElYeU5oV0h2d1Nldk9NY3RxSzIyWWowMCt3NWhTTGVwM2hv?=
 =?utf-8?B?SEF0MTFzT3JMYTkrMHhpSDIxQlppcE1IbkRTQ1hSRjlsMWZyMkxLNjV1cEl1?=
 =?utf-8?B?aWdNZC9TR1Zyb1owTGR3bU1naXRjRWc3ZlplQmxRYnoxZnZhTEZRd1JTaXpr?=
 =?utf-8?B?VDNEb25aajdybjkxL0svYlc5cVVRNGc5NEllcUI5Z2lBZmJ4T2FvakhuRVRF?=
 =?utf-8?B?MFlqaVE4ZEpWNUdFbVpETHMvc2FrbHJxWmd2VFRZSW5BUlVIRENrTlkzMGlW?=
 =?utf-8?B?UmFJWkRzeUJLci9uREZscDcrcStKOHRmMlNIUXZnUUh2NGRjVzlpR3RDbktF?=
 =?utf-8?B?WmR6bzBielltVWEyT1YyVjB0dTdaZ0F5aUhRQ3J5UThNZTdkQWRnYk5MOHh2?=
 =?utf-8?B?T0hkczF4dnhIUk45alFJT0gvbDZFc3lqN0ZDN0U2Z2xDRUttclRzMDdFMktT?=
 =?utf-8?B?cXArdFM0R3dFRXNiaDdaNkIzNE1NakVKVHFVbXdVTGw3bGNkVGFYYkplUmcv?=
 =?utf-8?B?TFlpbjVTakxRL2ZrU3ZUT1NWQTI4K2greDF1TmdmK25FNDlJS1YxL3MyWW9I?=
 =?utf-8?B?dng2ZWxZczBFYnJPWVNiSmovVkdWL2NFUlB0NWZBTHN3KzZkS051M2ViVDFB?=
 =?utf-8?B?a1J5b0RiamQxaUtSRmJrRllEZHNyWXBKR2djcEpHV0twdGxKaUg0c1licUVn?=
 =?utf-8?B?S0pvOWM2bmtYL1JEZ1FSdEJzNGxla0YxOU9kT0tuVVFOV0dCZTZCZzJhU1ho?=
 =?utf-8?B?eFhacXdtNHhaZnI1dWVZUXp6VkRiV0U2WWpBcVlqQmZaakt4aEtZZzdCREp0?=
 =?utf-8?B?aUZGZDIyNkNmenNWRjlDcE52cFgrWEppaW9mUTMzTy9kV0doazREb3k5WHZK?=
 =?utf-8?B?VW9iUFRJRVhaKzV3UEF1a2RreEl2VGZ1RVc2Z21iNTEzTE1iMEJNRWRvTllo?=
 =?utf-8?B?MDlQdVE2VlNSY1JpdGUyVC9BYldqRTdTUmhCNGNEcEFpQUJTZmFESW5PSHl3?=
 =?utf-8?B?VzVLaDV4Sml2OEdPcm41R2w5b0hpb00vemhKcmt3TzRjR0hDeEhRYVora01P?=
 =?utf-8?B?ZkRLUXFCMGhHK1R4aFFMZnNTRGp2NW1WK2NXUUs2MkNEVmJVZ2kxaEQ1Y2Jq?=
 =?utf-8?B?emwvTGtybXQ4SWFuTk1nY29EWDNIN2ROWFZqRFpucVdhN1cxUnNOeGJITTNI?=
 =?utf-8?B?MUN4M3pOdG9IamQ1Y045UHRNL25aRjM3ZnJJUXZ4TXZFRWNjWUdzbGxLSHU3?=
 =?utf-8?B?RkMwRVF4YUxyUjN3dkM5My81bk5aNnhVM2MwVXZPRmRLR29qUlhSMUt1SnFW?=
 =?utf-8?B?YVgwQU5xK3RaK0cra2w3MDM2c000TXNTakVVQmNnYXFiOWw4aVlYZUZ5YmRQ?=
 =?utf-8?B?dU9oalRnSWRmaTg0WDg4R1hlanhUVlNIT2liNmtKYTZpdzlOb3FEQWYwdyt0?=
 =?utf-8?B?a1oyL2ozWFhZTTEyNGwwbG12WGVZRERkVlJlUDR0bDFkdkFodmdMbnBhdlFF?=
 =?utf-8?B?UXhGYUNSWkxGVUJoN01HRUJzMkExU3NGZGxtblRnRGMzWG9mTUV6d3BOTVdS?=
 =?utf-8?B?U0RXTXF4MXJ0VU9ZSDFjWFpyUE10Umo2NGFWenUvMUJtVE0xNHFNVzRlTmpY?=
 =?utf-8?Q?FhNZ1s03+9ih+I0Z+6ASud2Pw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef97640-ea7b-44f2-d5b1-08dc05c6fc33
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2023 03:58:57.5912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kQubgMabqC2EbjRZJl+snc39HhQJtDWlAXdMu1bHgRpb1sGO5ULxM8bHAv3GzO0+VFowJuP2KoBy2u2ZjIj6kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8217
X-OriginatorOrg: intel.com

On 2023/12/22 12:09, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, December 21, 2023 11:40 PM
>>
>> From: Nicolin Chen <nicolinc@nvidia.com>
>>
>> Add test cases for the IOMMU_HWPT_INVALIDATE ioctl and verify it by using
>> the new IOMMU_TEST_OP_MD_CHECK_IOTLB.
>>
>> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
>> Co-developed-by: Yi Liu <yi.l.liu@intel.com>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> 
> overall this look good:
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> 
> with two  nits:
> 
>> +
>> +		num_inv = 1;
>> +		inv_reqs[0].flags = IOMMU_TEST_INVALIDATE_FLAG_ALL |
>> +
>> IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR;
>> +		test_err_hwpt_invalidate(EINVAL, nested_hwpt_id[0],
>> inv_reqs,
>> +
>> IOMMU_HWPT_INVALIDATE_DATA_SELFTEST,
>> +					 sizeof(*inv_reqs), &num_inv);
>> +		assert(!num_inv);
> 
> this may need adjustment upon whether we want to allow two flags together.

it was removed :)

> and let's add a test for below code for completeness:
> 
> +	if (cmd->req_num && (!cmd->reqs_uptr || !cmd->req_len)) {
> +		rc = -EINVAL;
> +		goto out;
> +	}

done.

-- 
Regards,
Yi Liu