Received-SPF: pass (google.com: domain of linux-kernel+bounces-11338-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e1cf94ba-aaf7-448b-a87b-95d8a2442b20@intel.com>
Date: Tue, 26 Dec 2023 12:03:09 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 7/9] iommu/vt-d: Allow qi_submit_sync() to return the
 QI faults
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-8-yi.l.liu@intel.com>
 <BN9PR11MB5276468811C5113427D4CA6F8C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276468811C5113427D4CA6F8C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEdXM1dETVlsWXBnUzRydE0xZ2xsN21INExaQXhqMXJvUzNEbTd3MnNwMzRU?=
 =?utf-8?B?KzgxNEwwVFJ3VmcvRkZ5RFo4cit0UE9nY2VqUnFHUWJrdTFjU28xRmdPY1RM?=
 =?utf-8?B?NnJTUkNFVXFqdUlnSS8ra0FPelpCSUJZdTE5R1czdlJUc2lZMjMrTTB1c0Jq?=
 =?utf-8?B?MDNhdnU1c2p3eUFEYzk0aS8rRHdSbjhiT0R1aUdMUkNEVktOMnI2YThQVWZy?=
 =?utf-8?B?VE42c1pVZmpnVXVrOUs1cjhYamgyZkhwSGcrSTJHcEZpaEZNbjFlNkVmRnha?=
 =?utf-8?B?bkM3OWhSWk1HZ0Q2ZkU5MjlsUllwWkI2c2JFZTUvRU1XQzRGY2w4enFOVThW?=
 =?utf-8?B?WlBlWHI2K21kNnROVXkrU01ybTJZM2NOT3FmNjdpbHA0VWIyQzRqcVBzdWdt?=
 =?utf-8?B?ZGRRUG9ta0F4WGMwMEw4ZjBubXd3ZkJacUdaMnlsM0hXTWVLaXVpZk53TlVQ?=
 =?utf-8?B?VXVDQTdrNmV6RmFmNlpxWFhZRWF4RldLWFFnTDgzWXZxYmtVMnZmQktaclJQ?=
 =?utf-8?B?eldBcDhoT1RYWVdWUkFKeE9zN0Mvb3l3UEswSlBLVXFmVlpCeTVKNHo2RDNB?=
 =?utf-8?B?bFhLblc1YjR5SmNzNWRxTEJZV01Ickx6bEVxeFlMc0U3QWdPMXpJOWZ3YXEr?=
 =?utf-8?B?ejhDMGlvSk9uVk5FNktMQ0syVjNCazRQUXBWTHNQNG1IS2ZCWTM5dUgyL2FT?=
 =?utf-8?B?cnEwR0Z6cVhOeXJIbVZBQU5kamhySEVtNzRIcmVMZ3lkVXNVUFlxUEpkQ2tx?=
 =?utf-8?B?K01SQnFQTmdpTE9IdjNlb2dIMXBSa3dMZFFsL1F5Q2ZNK01YU1Evbm14OE94?=
 =?utf-8?B?Q2k5SGVNRFhhbEJKV3NTMFFGTmJmQTdFcnVIVENhSVFINjYyaUNjY2EvZEI3?=
 =?utf-8?B?WGVQa0tHVmdjcGI0ZmJQSHYvRFpHaEZVYnA0d2tmZitzK0k1VHRTWHpUSjRt?=
 =?utf-8?B?THRIZWZ6VDdvaTR4c2M3ZXJDakc5aktZT3gzWEpzaVdWRFZaYlB0eXVTTUMv?=
 =?utf-8?B?b0NPTzNZY3hVTDJDSk1hMldWU0ZQbzU4VS9VbmQxdDV1cU9EQjZTZWFadUFs?=
 =?utf-8?B?RU1VUXROZDNYNVVWbm5aOXZyeGRYWC9zY01BOEp3ZkpQTnBXZG4zT09mQ1FZ?=
 =?utf-8?B?RjNTbGJBNFNZbnQweEw0NlVIdkNHZFVyUjQzb2xhQnU4YnZ0T3N5UndHdUVZ?=
 =?utf-8?B?M2RRaVRwTzVFeEQ0MGE0Mm5WQ1NRSzNneXorVlErdC9QSTFkMGpZa0NnSjNs?=
 =?utf-8?B?TFFkdjI3NFJKdmVwZjZLWXVldXFwTzNwd2o4Z1B0ZVZuYmc2K3Fxc0lEcG5J?=
 =?utf-8?B?MStBNks5Y1BpUWpNa3lHZ0VYclF0Zm1LSmJGOTBJeENmWUxKN2NlVm9CZmdk?=
 =?utf-8?B?Wk1GS3d5YnpNUXNQY0RmdldWR1F3VURveUJ2VTd5cDFOSXBUbGR3YzYxRXNC?=
 =?utf-8?B?OGNhRVdnWWtFRThraDFEVUFvY2xRVXU2OFBaa0Vnb0NqVm5QTTZGeVpQZFRL?=
 =?utf-8?B?T3J5MGNsK1dFclhGUVUzdVdZMkVBelFvL0JKcjZ3Wlp6QVowbHFZMDUyUFF3?=
 =?utf-8?B?TDhMRzFXQ29ZbkVDYlN4YWdWSmoyUTUxNExYSEh5MXhTMG81TGt5QlZTRTFH?=
 =?utf-8?B?NkJsWExNb3A0TmtSSG5ndVdhZUtDYjFHSlFtb1hnNy93OURaY2krZ3h3bGts?=
 =?utf-8?B?MURsVTlZUWQ2cG9nR1hwSWVuL0tIaFRJZjNVdGdnT0QxdVRvNnJDZCtzcmY2?=
 =?utf-8?B?MFlBUXVudEdpOGp1WitkQnBFMHE0cnBKNmc2MjVXcHRvclFEZEg5eWRzbG5Y?=
 =?utf-8?B?NmhoNW9yRUxnME5yZ0VXbUtGNU00TTBwM2hmZXRTenczMmhyYWlKdVVucWVr?=
 =?utf-8?B?dkFsTnd3RjV4SVBORVRVcUZ2VVYrdkdjMjlLUDhEYUJBR01taXZBMWxuWE90?=
 =?utf-8?B?aCt0TGd5bTFwYmxId1M0TGMxdEptQkU0ZW40aWZnM2gzMkJXeXJUQjE3MEMr?=
 =?utf-8?B?Z2xJb2RZcmQ0V0NQZit5bEM2ejI5QWhjamt2dXE0VDM2ODRtQlFGaTR4bUtQ?=
 =?utf-8?B?a1pQcGd3amIvYVRTQUIzRW5sUmNUVEZsWkx2Q1pFcjNaZm1zdVV0Q2ZjWkpn?=
 =?utf-8?Q?ohU7SZRob3tkQkI/iI6pQaT25?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c988914e-06a3-44dc-4c8e-08dc05c72c2f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2023 04:00:18.0894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Z3BKSgrwLtdOceEoIC97Pxg1vGypCINQOG/fHd6HyxfcXjFceefbgnxEB8w8Xo5Q2LkkSyKjTRKJrKZswkX4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8217
X-OriginatorOrg: intel.com

On 2023/12/22 12:23, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, December 21, 2023 11:40 PM
>>
>> +	fault &= DMA_FSTS_IQE | DMA_FSTS_ITE | DMA_FSTS_ICE;
>> +	if (fault) {
>> +		if (fsts)
>> +			*fsts |= fault;
> 
> do we expect the fault to be accumulated? otherwise it's clearer to
> just do direct assignment instead of asking for the caller to clear
> the variable before invocation.

not quite get. do you mean the fault should not be cleared in the caller
side?

> the rest looks good:
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

-- 
Regards,
Yi Liu