Received-SPF: pass (google.com: domain of linux-kernel+bounces-11374-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Aakarsh Jain" <aakarsh.jain@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>, "'Marek
 Szyprowski'" <m.szyprowski@samsung.com>, "'Andrzej Hajda'"
	<andrzej.hajda@intel.com>, "'Mauro Carvalho Chehab'" <mchehab@kernel.org>
Cc: <linux-fsd@tesla.coma>, <linux-samsung-soc@vger.kernel.org>, "'Smitha T
 Murthy'" <smithatmurthy@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20231224-n-s5p-mfc-const-v1-1-a3b246470fe4@linaro.org>
Subject: RE: [PATCH 01/15] media: s5p-mfc: drop unused static s5p_mfc_cmds
Date: Tue, 26 Dec 2023 10:40:11 +0530
Message-ID: <15ce01da37b9$cede8d20$6c9ba760$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKOGlHY6WxiJqLoSx78067AznjgmAHo/W/vAklP6R+vMaxvAA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>
	<CGME20231224154435epcas5p11c17dce71c5ce263c8028a43b401aa22@epcas5p1.samsung.com>
	<20231224-n-s5p-mfc-const-v1-1-a3b246470fe4@linaro.org>


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski=40samsung.com>; Andrzej Hajda
> <andrzej.hajda=40intel.com>; Mauro Carvalho Chehab
> <mchehab=40kernel.org>
> Cc: Aakarsh Jain <aakarsh.jain=40samsung.com>; linux-fsd=40tesla.coma; li=
nux-
> samsung-soc=40vger.kernel.org; Smitha T Murthy
> <smithatmurthy=40gmail.com>; linux-arm-kernel=40lists.infradead.org; linu=
x-
> media=40vger.kernel.org; linux-kernel=40vger.kernel.org; Krzysztof Kozlow=
ski
> <krzysztof.kozlowski=40linaro.org>
> Subject: =5BPATCH 01/15=5D media: s5p-mfc: drop unused static s5p_mfc_cmd=
s
>=20
> File-scope static variable =22s5p_mfc_cmds=22 is not read after assignmen=
t, thus
> it can be dropped entirely.
>=20
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> ---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c =7C 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> index 774c573dc075..196d8c99647b 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> =40=40 -12,14 +12,10 =40=40
>  =23include =22s5p_mfc_cmd_v5.h=22
>  =23include =22s5p_mfc_cmd_v6.h=22
>=20
> -static struct s5p_mfc_hw_cmds *s5p_mfc_cmds;
> -
>  void s5p_mfc_init_hw_cmds(struct s5p_mfc_dev *dev)  =7B
>  	if (IS_MFCV6_PLUS(dev))
> -		s5p_mfc_cmds =3D s5p_mfc_init_hw_cmds_v6();
> +		dev->mfc_cmds =3D s5p_mfc_init_hw_cmds_v6();
>  	else
> -		s5p_mfc_cmds =3D s5p_mfc_init_hw_cmds_v5();
> -
> -	dev->mfc_cmds =3D s5p_mfc_cmds;
> +		dev->mfc_cmds =3D s5p_mfc_init_hw_cmds_v5();
>  =7D
>=20
> --
> 2.34.1

Reviewed-by: Aakarsh Jain <aakarsh.jain=40samsung.com>

Thanks=21