Received-SPF: pass (google.com: domain of linux-kernel+bounces-11375-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Aakarsh Jain" <aakarsh.jain@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>, "'Marek
 Szyprowski'" <m.szyprowski@samsung.com>, "'Andrzej Hajda'"
	<andrzej.hajda@intel.com>, "'Mauro Carvalho Chehab'" <mchehab@kernel.org>
Cc: <linux-fsd@tesla.coma>, <linux-samsung-soc@vger.kernel.org>, "'Smitha T
 Murthy'" <smithatmurthy@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org>
Subject: RE: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops
Date: Tue, 26 Dec 2023 10:42:15 +0530
Message-ID: <15cf01da37ba$18936ad0$49ba4070$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKOGlHY6WxiJqLoSx78067AznjgmAFJzwIkAnbPk3avNTqAkA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>
	<CGME20231224154437epcas5p4ce3d24f3cbdc4ad25b215f14c5bccd3e@epcas5p4.samsung.com>
	<20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org>


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski=40samsung.com>; Andrzej Hajda
> <andrzej.hajda=40intel.com>; Mauro Carvalho Chehab
> <mchehab=40kernel.org>
> Cc: Aakarsh Jain <aakarsh.jain=40samsung.com>; linux-fsd=40tesla.coma; li=
nux-
> samsung-soc=40vger.kernel.org; Smitha T Murthy
> <smithatmurthy=40gmail.com>; linux-arm-kernel=40lists.infradead.org; linu=
x-
> media=40vger.kernel.org; linux-kernel=40vger.kernel.org; Krzysztof Kozlow=
ski
> <krzysztof.kozlowski=40linaro.org>
> Subject: =5BPATCH 02/15=5D media: s5p-mfc: drop unused static s5p_mfc_ops
>=20
> File-scope static variable =22s5p_mfc_ops=22 is not read after assignment=
, thus it
> can be dropped entirely.
>=20
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> ---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c =7C 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> index 673962301173..5ba791fa3676 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> =40=40 -14,18 +14,15 =40=40
>  =23include =22s5p_mfc_opr_v5.h=22
>  =23include =22s5p_mfc_opr_v6.h=22
>=20
> -static struct s5p_mfc_hw_ops *s5p_mfc_ops;
> -
>  void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev)  =7B
>  	if (IS_MFCV6_PLUS(dev)) =7B
> -		s5p_mfc_ops =3D s5p_mfc_init_hw_ops_v6();
> +		dev->mfc_ops =3D s5p_mfc_init_hw_ops_v6();
>  		dev->warn_start =3D S5P_FIMV_ERR_WARNINGS_START_V6;
>  	=7D else =7B
> -		s5p_mfc_ops =3D s5p_mfc_init_hw_ops_v5();
> +		dev->mfc_ops =3D s5p_mfc_init_hw_ops_v5();
>  		dev->warn_start =3D S5P_FIMV_ERR_WARNINGS_START;
>  	=7D
> -	dev->mfc_ops =3D s5p_mfc_ops;
>  =7D
>=20
>  void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)
>=20
> --
> 2.34.1

Reviewed-by: Aakarsh Jain <aakarsh.jain=40samsung.com>

Thanks=21