Received-SPF: pass (google.com: domain of linux-kernel+bounces-11390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Aakarsh Jain" <aakarsh.jain@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>, "'Marek
 Szyprowski'" <m.szyprowski@samsung.com>, "'Andrzej Hajda'"
	<andrzej.hajda@intel.com>, "'Mauro Carvalho Chehab'" <mchehab@kernel.org>
Cc: <linux-fsd@tesla.coma>, <linux-samsung-soc@vger.kernel.org>, "'Smitha T
 Murthy'" <smithatmurthy@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20231224-n-s5p-mfc-const-v1-9-a3b246470fe4@linaro.org>
Subject: RE: [PATCH 09/15] media: s5p-mfc: constify s5p_mfc_fmt structures
Date: Tue, 26 Dec 2023 11:57:53 +0530
Message-ID: <15d401da37c4$a9dece80$fd9c6b80$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKOGlHY6WxiJqLoSx78067AznjgmAGjTMXtAfUJOwGvNpHr8A==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org>
	<CGME20231224154446epcas5p2b08000b76b8a94063b164a55e5e8a999@epcas5p2.samsung.com>
	<20231224-n-s5p-mfc-const-v1-9-a3b246470fe4@linaro.org>


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski=40samsung.com>; Andrzej Hajda
> <andrzej.hajda=40intel.com>; Mauro Carvalho Chehab
> <mchehab=40kernel.org>
> Cc: Aakarsh Jain <aakarsh.jain=40samsung.com>; linux-fsd=40tesla.coma; li=
nux-
> samsung-soc=40vger.kernel.org; Smitha T Murthy
> <smithatmurthy=40gmail.com>; linux-arm-kernel=40lists.infradead.org; linu=
x-
> media=40vger.kernel.org; linux-kernel=40vger.kernel.org; Krzysztof Kozlow=
ski
> <krzysztof.kozlowski=40linaro.org>
> Subject: =5BPATCH 09/15=5D media: s5p-mfc: constify s5p_mfc_fmt structure=
s
>=20
> Static =22s5p_mfc_fmt=22 structures are not modified by the driver, so th=
ey can
> be made const for code safety.
>=20
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> ---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h =7C 4 ++--
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.c    =7C 6 +++---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c    =7C 8 ++++----
>  3 files changed, 9 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> index fa556f27fa06..e9283020070e 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> =40=40 -633,8 +633,8 =40=40 struct s5p_mfc_ctx =7B
>  	unsigned int int_err;
>  	wait_queue_head_t queue;
>=20
> -	struct s5p_mfc_fmt *src_fmt;
> -	struct s5p_mfc_fmt *dst_fmt;
> +	const struct s5p_mfc_fmt *src_fmt;
> +	const struct s5p_mfc_fmt *dst_fmt;
>=20
>  	struct vb2_queue vq_src;
>  	struct vb2_queue vq_dst;
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.c
> index 4dbe8792ac3d..2f664c7e9e4c 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.c
> =40=40 -27,7 +27,7 =40=40
>  =23include =22s5p_mfc_opr.h=22
>  =23include =22s5p_mfc_pm.h=22
>=20
> -static struct s5p_mfc_fmt formats=5B=5D =3D =7B
> +static const struct s5p_mfc_fmt formats=5B=5D =3D =7B
>  	=7B
>  		.fourcc		=3D V4L2_PIX_FMT_NV12MT_16X16,
>  		.codec_mode	=3D S5P_MFC_CODEC_NONE,
> =40=40 -163,7 +163,7 =40=40 static struct s5p_mfc_fmt formats=5B=5D =3D =
=7B  =23define
> NUM_FORMATS ARRAY_SIZE(formats)
>=20
>  /* Find selected format description */
> -static struct s5p_mfc_fmt *find_format(struct v4l2_format *f, unsigned i=
nt
> t)
> +static const struct s5p_mfc_fmt *find_format(struct v4l2_format *f,
> +unsigned int t)
>  =7B
>  	unsigned int i;
>=20
> =40=40 -387,7 +387,7 =40=40 static int vidioc_g_fmt(struct file *file, vo=
id *priv,
> struct v4l2_format *f)  static int vidioc_try_fmt(struct file *file, void=
 *priv,
> struct v4l2_format *f)  =7B
>  	struct s5p_mfc_dev *dev =3D video_drvdata(file);
> -	struct s5p_mfc_fmt *fmt;
> +	const struct s5p_mfc_fmt *fmt;
>=20
>  	mfc_debug(2, =22Type is %d=5Cn=22, f->type);
>  	if (f->type =3D=3D V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) =7B diff --git
> a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c
> index 4b4c129c09e7..d6a4b9c701eb 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c
> =40=40 -30,7 +30,7 =40=40
>  =23define DEF_SRC_FMT_ENC	V4L2_PIX_FMT_NV12M
>  =23define DEF_DST_FMT_ENC	V4L2_PIX_FMT_H264
>=20
> -static struct s5p_mfc_fmt formats=5B=5D =3D =7B
> +static const struct s5p_mfc_fmt formats=5B=5D =3D =7B
>  	=7B
>  		.fourcc		=3D V4L2_PIX_FMT_NV12MT_16X16,
>  		.codec_mode	=3D S5P_MFC_CODEC_NONE,
> =40=40 -97,7 +97,7 =40=40 static struct s5p_mfc_fmt formats=5B=5D =3D =7B=
  =7D;
>=20
>  =23define NUM_FORMATS ARRAY_SIZE(formats) -static struct s5p_mfc_fmt
> *find_format(struct v4l2_format *f, unsigned int t)
> +static const struct s5p_mfc_fmt *find_format(struct v4l2_format *f,
> +unsigned int t)
>  =7B
>  	unsigned int i;
>=20
> =40=40 -1394,7 +1394,7 =40=40 static int vidioc_g_fmt(struct file *file, =
void *priv,
> struct v4l2_format *f)  static int vidioc_try_fmt(struct file *file, void=
 *priv,
> struct v4l2_format *f)  =7B
>  	struct s5p_mfc_dev *dev =3D video_drvdata(file);
> -	struct s5p_mfc_fmt *fmt;
> +	const struct s5p_mfc_fmt *fmt;
>  	struct v4l2_pix_format_mplane *pix_fmt_mp =3D &f->fmt.pix_mp;
>=20
>  	if (f->type =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) =7B =40=40 -
> 2355,7 +2355,7 =40=40 static const struct v4l2_ioctl_ops s5p_mfc_enc_ioct=
l_ops
> =3D =7B
>  	.vidioc_unsubscribe_event =3D v4l2_event_unsubscribe,  =7D;
>=20
> -static int check_vb_with_fmt(struct s5p_mfc_fmt *fmt, struct vb2_buffer
> *vb)
> +static int check_vb_with_fmt(const struct s5p_mfc_fmt *fmt, struct
> +vb2_buffer *vb)
>  =7B
>  	int i;
>=20
>=20
> --
> 2.34.1

Reviewed-by: Aakarsh Jain <aakarsh.jain=40samsung.com>

Thanks=21