Received-SPF: pass (google.com: domain of linux-kernel+bounces-11435-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231220072529.1036099-1-tj@kernel.org> <20231220072529.1036099-9-tj@kernel.org>
In-Reply-To: <20231220072529.1036099-9-tj@kernel.org>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Tue, 26 Dec 2023 17:14:18 +0800
Message-ID: <CAJhGHyC_9JemZdv4Gp4XG7BqLc72bS1uM8xv9vpQtSsyhefZvQ@mail.gmail.com>
Subject: Re: [PATCH 08/10] workqueue: Introduce struct wq_node_nr_active
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Naohiro.Aota@wdc.com, kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 3:26=E2=80=AFPM Tejun Heo <tj@kernel.org> wrote:

> @@ -1498,12 +1539,21 @@ static bool pwq_tryinc_nr_active(struct pool_work=
queue *pwq)
>  {
>         struct workqueue_struct *wq =3D pwq->wq;
>         struct worker_pool *pool =3D pwq->pool;
> -       bool obtained;
> +       struct wq_node_nr_active *nna =3D wq_node_nr_active(wq, pool->nod=
e);
> +       bool obtained =3D false;
>
>         lockdep_assert_held(&pool->lock);
>
> -       obtained =3D pwq->nr_active < wq->max_active;
> +       if (!nna) {
> +               /* per-cpu workqueue, pwq->nr_active is sufficient */
> +               obtained =3D pwq->nr_active < wq->max_active;
> +               goto out;
> +       }

For unbound workqueue, it is not checked against wq->max_active anymore
and it is increased unconditionally.  Is it by design?


> +
> +       atomic_inc(&nna->count);
> +       obtained =3D true;
>
> +out:
>         if (obtained)
>                 pwq->nr_active++;
>         return obtained;