Received-SPF: pass (google.com: domain of linux-kernel+bounces-11442-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <nycvar.YFH.7.76.2312121445510.24250@cbobk.fhfr.pm>
 <3a29c0a6-9b53-433d-a83d-5b68a87c1155@mailbox.org> <CAMMabwPd-m7a+EQV7zb=wU52=P1FkqFU1dg9=gyvaS1EP5tX3Q@mail.gmail.com>
 <d13694c9-4409-4566-919b-7a577afd583c@mailbox.org>
In-Reply-To: <d13694c9-4409-4566-919b-7a577afd583c@mailbox.org>
From: Yauhen Kharuzhy <jekhor@gmail.com>
Date: Tue, 26 Dec 2023 12:36:05 +0300
Message-ID: <CAKWEGV4DQRBLBrYXMvUp1aHP3bBS+WSPh0yCNZJM-58jKwtrMA@mail.gmail.com>
Subject: Re: [PATCH] HID: lenovo: Restrict detection of patched firmware only
 to USB cptkbd
To: "Uli v. d. Ohe" <u-v@mailbox.org>
Cc: Mikhail Khvoinitsky <me@khvoinitsky.org>, jkosina@suse.com, benjamin.tissoires@redhat.com, 
	iam@valdikss.org.ru, linux-input@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=D0=B2=D1=81, 24 =D0=B4=D0=B5=D0=BA. 2023=E2=80=AF=D0=B3. =D0=B2 18:51, Uli=
 v. d. Ohe <u-v@mailbox.org>:
>
> > So this means that the only reliable way is to add a sysfs parameter.
> > I'll send a patch.
>
> Thank you for the quick action!
>
> Perhaps it would be possible to modify the firmware further in order to
> facilitate reliable detection of this modified firmware? But for now the
> solution with a sysfs parameter (and defaulting to the workaround) seems
> good.
Unfortunately no, the firmware is closed-source and was patched in
binary form AFAIR (by replacing 1-2 instructions). Moreover, it cannot
be updated in the wireless version of the keyboard (ThinkPad Compact
Keyboard II).
>
> Best regards,
> Uli


--=20
Yauhen Kharuzhy