Received-SPF: pass (google.com: domain of linux-kernel+bounces-11502-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Dec 2023 12:21:56 +0000
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jie Luo <quic_luoj@quicinc.com>, agross@kernel.org,
	andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, robert.marko@sartura.hr,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	quic_srichara@quicinc.com
Subject: Re: [PATCH v4 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332
 platform
Message-ID: <20231226-twine-smolder-713cb81fa411@spud>
References: <20231225084424.30986-1-quic_luoj@quicinc.com>
 <20231225084424.30986-6-quic_luoj@quicinc.com>
 <dee72ce8-b24e-467a-b265-1b965588807f@linaro.org>
 <aeb364a3-6c05-4a1b-ba32-e687a89f20f8@quicinc.com>
 <58dde1a7-ed4a-442c-bb5c-c3f6d926fb7e@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YKoQgfQHX/tQukT9"
Content-Disposition: inline
In-Reply-To: <58dde1a7-ed4a-442c-bb5c-c3f6d926fb7e@linaro.org>


--YKoQgfQHX/tQukT9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 26, 2023 at 10:28:09AM +0100, Krzysztof Kozlowski wrote:
> On 26/12/2023 08:25, Jie Luo wrote:

> >>> +  qcom,cmn-ref-clock-frequency:
> >>> +    $ref: /schemas/types.yaml#/definitions/uint32
> >>> +    enum:
> >>> +      - 25000000
> >>> +      - 31250000
> >>> +      - 40000000
> >>> +      - 48000000
> >>> +      - 50000000
> >>> +      - 96000000
> >>> +    default: 48000000
> >>> +    description: |
> >>> +      The reference clock source of CMN PLL block is selectable, the
> >>> +      reference clock source can be from wifi module or the external
> >>> +      xtal, the reference clock frequency 48MHZ can be from internal
> >>> +      wifi or the external xtal, if absent, the internal 48MHZ is us=
ed,
> >>> +      if the 48MHZ is specified, which means the external 48Mhz is u=
sed.
> >>
> >> This does not resolve mine and Conor's concerns from previous version.
> >> External clocks are defined as clock inputs.
> >=20
> > No matter the external or internal reference clock, they are the clock
> > source selection for CMN, there are only 48MHZ can be external or=20
> > internal, other clocks have the different clock rate, so the internal
> > 48MHZ reference clock can be implied when the=20
> > "qcom,cmn-ref-clock-frequency" is not defined, which is suggested by=20
> > Conor in the previous
> > comments.
>=20
> I don't think he proposed it, but maybe I missed some message (care to
> point me to his message where he agreed on usage of
> qcom,cmn-ref-clock-frequency?). I am pretty sure we both stayed on the
> same page, that the presence of clocks defines choice of internal clock.
> This property should go away.

Exactly, I wanted this property to be removed. My suggestion was about
defaulting to the internal clock when the "clocks" property did not
contain the cmn ref clock.

> It is tiring to keep discussing this.

Yup.


--YKoQgfQHX/tQukT9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZYrFZAAKCRB4tDGHoIJi
0tZUAQCG5wZXdhtGuFoHbSVtP0vu3felLI56vgP8Wu0OCd58qQEA2ambCadg33Gp
9MKVnpm0Trug6Fr9/z7dkNXJhR7+4wk=
=NGC5
-----END PGP SIGNATURE-----

--YKoQgfQHX/tQukT9--