Received-SPF: pass (google.com: domain of linux-kernel+bounces-11518-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231224124114.31119-1-othacehe@gnu.org> <20231224124114.31119-3-othacehe@gnu.org>
In-Reply-To: <20231224124114.31119-3-othacehe@gnu.org>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 26 Dec 2023 10:24:32 -0300
Message-ID: <CAOMZO5AmpdE2uMgx8+P-zXf8mYRvsJDBUf7xeRpaHC3jN-7_ww@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, Li Yang <leoyang.li@nxp.com>, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 24, 2023 at 9:41=E2=80=AFAM Mathieu Othacehe <othacehe@gnu.org>=
 wrote:

> +/{
> +       model =3D "Variscite VAR-SOM-MX93 on Symphony evaluation board";
> +       compatible =3D "variscite,var-som-mx93-symphony",
> +                    "variscite,var-som-mx93", "fsl,imx93";
> +
> +       aliases {
> +               ethernet1 =3D &fec;

You could pass ethernet0 here as well.


> +&lpi2c1 {
> +       #address-cells =3D <1>;
> +       #size-cells =3D <0>;

These are present in imx93.dtsi. You can drop them from here.

> +&lpi2c5 {
> +       #address-cells =3D <1>;
> +       #size-cells =3D <0>;

Ditto.

Reviewed-by: Fabio Estevam <festevam@gmail.com>