Received-SPF: pass (google.com: domain of linux-kernel+bounces-11621-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231226-libstringheader-v6-0-80aa08c7652c@google.com>
 <20231226-libstringheader-v6-2-80aa08c7652c@google.com> <CAHp75VfXWev7Z-tHRPAuWzaLj7ogiECW2arFc4CdcxUE87Ld0A@mail.gmail.com>
In-Reply-To: <CAHp75VfXWev7Z-tHRPAuWzaLj7ogiECW2arFc4CdcxUE87Ld0A@mail.gmail.com>
From: Tanzir Hasan <tanzirh@google.com>
Date: Tue, 26 Dec 2023 10:47:08 -0800
Message-ID: <CAE-cH4rche0dbKWXHQ89YUZzs6Q6XwRPrfdy5+uox9YnQ-5VXA@mail.gmail.com>
Subject: Re: [PATCH v6 2/2] lib/string: shrink lib/string.i via IWYU
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Kees Cook <keescook@chromium.org>, Nick Desaulniers <nnn@google.com>, 
	Andy Shevchenko <andy@kernel.org>, linux-hardening@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, 
	Greg KH <gregkh@linuxfoundation.org>, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 26, 2023 at 10:35=E2=80=AFAM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Dec 26, 2023 at 8:00=E2=80=AFPM Tanzir Hasan <tanzirh@google.com>=
 wrote:
> >
> > This diff uses an open source tool include-what-you-use (IWYU) to modif=
y
> > the include list, changing indirect includes to direct includes. IWYU i=
s
> > implemented using the IWYUScripts github repository which is a tool tha=
t
> > is currently undergoing development. These changes seek to improve buil=
d
> > times.
> >
> > This change to lib/string.c resulted in a preprocessed size of
> > lib/string.i from 26371 lines to 5321 lines (-80%) for the x86
> > defconfig.
>
> Why did you ignore my tag?

I'm sorry. I forgot you had already reviewed this one. In a future
revision I will include this:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Best,
Tanzir