Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757105AbXLJSDd (ORCPT ); Mon, 10 Dec 2007 13:03:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756882AbXLJSDW (ORCPT ); Mon, 10 Dec 2007 13:03:22 -0500 Received: from [198.99.130.12] ([198.99.130.12]:55220 "EHLO saraswathi.solana.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756755AbXLJSDV (ORCPT ); Mon, 10 Dec 2007 13:03:21 -0500 Date: Mon, 10 Dec 2007 13:03:09 -0500 From: Jeff Dike To: Julia Lawall Cc: wangchen@cn.fujitsu.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3] Fix use of skb after netif_rx Message-ID: <20071210180309.GA9068@c2.user-mode-linux.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 20 On Sun, Dec 09, 2007 at 09:02:31PM +0100, Julia Lawall wrote: > Recently, Wang Chen submitted a patch > (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb) > after a subsequent reference to skb, because netif_rx may call kfree_skb on > its argument. The same problem occurs in some other drivers as well. > > This was found using the following semantic match. > (http://www.emn.fr/x-info/coccinelle/) Thanks, I'll forward this on. Jeff -- Work email - jdike at linux dot intel dot com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/