Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957AbXLJSLY (ORCPT ); Mon, 10 Dec 2007 13:11:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751756AbXLJSLP (ORCPT ); Mon, 10 Dec 2007 13:11:15 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:57758 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752183AbXLJSLO (ORCPT ); Mon, 10 Dec 2007 13:11:14 -0500 Date: Mon, 10 Dec 2007 19:11:12 +0100 From: Adrian Bunk To: Pierre Ossman Cc: Geert Uytterhoeven , Al Viro , Andrew Morton , Sam Ravnborg , Marcel Holtmann , Linux Kernel Development , Rusty Russell , linux-arch@vger.kernel.org Subject: Re: Correct types for mod_devicetable.h (was: Re: m68k build failure) Message-ID: <20071210181112.GM20441@stusta.de> References: <20071127220723.e2e3d0b4.akpm@linux-foundation.org> <20071128094856.056c0a3f@poseidon.drzeus.cx> <20071128010056.85703a34.akpm@linux-foundation.org> <20071128092856.GV8181@ftp.linux.org.uk> <20071128132916.125e72ec@poseidon.drzeus.cx> <20071201215602.7a4710d9@poseidon.drzeus.cx> <20071209180818.55bf1443@poseidon.drzeus.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20071209180818.55bf1443@poseidon.drzeus.cx> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1486 Lines: 41 On Sun, Dec 09, 2007 at 06:08:18PM +0100, Pierre Ossman wrote: > On Sun, 2 Dec 2007 12:22:31 +0100 (CET) > Geert Uytterhoeven wrote: > > > > > I gave it a try: > > - Remove existing alignment attributes from some device_id types > > - Introduce kernel_* types with proper size and alignment for > > cross-compilation (sample for m68k included) > > - Introduce BITS_PER_KERNEL_LONG, to make it clearer it applies to the target > > > > Apart from a cross-compile session for m68k, it's untested. > > > > This still requires a bit of maintenance to set up a kerneltypes.h for every arch. Better doing this work once than fixing similar issues again and again. > It also means we have to be very careful that gcc's internal alignment settings matched the ones in our header. There's nothing "gcc internal" about struct alignment - remember that any change in struct alignment would change our userspace ABI. > Rgds > Pierre cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/