Received-SPF: pass (google.com: domain of linux-kernel+bounces-11684-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 26 Dec 2023 15:24:41 -0500
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>, 
 davem@davemloft.net, 
 dsahern@kernel.org, 
 edumazet@google.com, 
 kuba@kernel.org, 
 pabeni@redhat.com, 
 shuah@kernel.org, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 linux-kselftest@vger.kernel.org
Message-ID: <658b3689d3617_5c2a929422@willemb.c.googlers.com.notmuch>
In-Reply-To: <e8b01e54-b623-44ec-84d5-406ea3b0c80b@gmail.com>
References: <f4eff69d-3917-4c42-8c6b-d09597ac4437@gmail.com>
 <e8b01e54-b623-44ec-84d5-406ea3b0c80b@gmail.com>
Subject: Re: [PATCH net-next 1/3] net: gso: add HBH extension header offload
 support
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Richard Gobert wrote:
> This commit adds net_offload to IPv6 Hop-by-Hop extension headers (as it
> is done for routing and dstopts) since it is supported in GSO and GRO.
> This allows to remove specific HBH conditionals in GSO and GRO when
> pulling and parsing an incoming packet.
> 
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

> ---
>  net/ipv6/exthdrs_offload.c | 11 +++++++++++
>  net/ipv6/ip6_offload.c     | 25 +++++++++++--------------
>  2 files changed, 22 insertions(+), 14 deletions(-)
> 
> diff --git a/net/ipv6/exthdrs_offload.c b/net/ipv6/exthdrs_offload.c
> index 06750d65d480..4c00398f4dca 100644
> --- a/net/ipv6/exthdrs_offload.c
> +++ b/net/ipv6/exthdrs_offload.c
> @@ -16,6 +16,10 @@ static const struct net_offload dstopt_offload = {
>  	.flags		=	INET6_PROTO_GSO_EXTHDR,
>  };
>  
> +static const struct net_offload hbh_offload = {
> +	.flags		=	INET6_PROTO_GSO_EXTHDR,
> +};
> +
>  int __init ipv6_exthdrs_offload_init(void)
>  {
>  	int ret;
> @@ -28,9 +32,16 @@ int __init ipv6_exthdrs_offload_init(void)
>  	if (ret)
>  		goto out_rt;
>  
> +	ret = inet6_add_offload(&hbh_offload, IPPROTO_HOPOPTS);
> +	if (ret)
> +		goto out_dstopts;
> +
>  out:
>  	return ret;
>  
> +out_dstopts:
> +	inet6_del_offload(&dstopt_offload, IPPROTO_DSTOPTS);
> +
>  out_rt:
>  	inet6_del_offload(&rthdr_offload, IPPROTO_ROUTING);
>  	goto out;
> diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
> index d6314287338d..0e0b5fed0995 100644
> --- a/net/ipv6/ip6_offload.c
> +++ b/net/ipv6/ip6_offload.c
> @@ -45,15 +45,13 @@ static int ipv6_gso_pull_exthdrs(struct sk_buff *skb, int proto)
>  		struct ipv6_opt_hdr *opth;
>  		int len;
>  
> -		if (proto != NEXTHDR_HOP) {
> -			ops = rcu_dereference(inet6_offloads[proto]);
> +		ops = rcu_dereference(inet6_offloads[proto]);
>  
> -			if (unlikely(!ops))
> -				break;
> +		if (unlikely(!ops))
> +			break;
>  
> -			if (!(ops->flags & INET6_PROTO_GSO_EXTHDR))
> -				break;
> -		}
> +		if (!(ops->flags & INET6_PROTO_GSO_EXTHDR))
> +			break;
>  
>  		if (unlikely(!pskb_may_pull(skb, 8)))
>  			break;
> @@ -171,13 +169,12 @@ static int ipv6_exthdrs_len(struct ipv6hdr *iph,
>  
>  	proto = iph->nexthdr;
>  	for (;;) {
> -		if (proto != NEXTHDR_HOP) {
> -			*opps = rcu_dereference(inet6_offloads[proto]);
> -			if (unlikely(!(*opps)))
> -				break;
> -			if (!((*opps)->flags & INET6_PROTO_GSO_EXTHDR))
> -				break;
> -		}
> +		*opps = rcu_dereference(inet6_offloads[proto]);
> +		if (unlikely(!(*opps)))
> +			break;
> +		if (!((*opps)->flags & INET6_PROTO_GSO_EXTHDR))
> +			break;
> +
>  		opth = (void *)opth + optlen;
>  		optlen = ipv6_optlen(opth);
>  		len += optlen;
> -- 
> 2.36.1
>