Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756640AbXLJStG (ORCPT ); Mon, 10 Dec 2007 13:49:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756001AbXLJSsv (ORCPT ); Mon, 10 Dec 2007 13:48:51 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:59891 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbXLJSsu (ORCPT ); Mon, 10 Dec 2007 13:48:50 -0500 Date: Mon, 10 Dec 2007 19:50:39 +0100 From: Sam Ravnborg To: Andi Kleen Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au Subject: Re: [PATCH RFC] [4/9] modpost: Fix format string warnings Message-ID: <20071210185039.GB17315@uranus.ravnborg.org> References: <20071122343.446909000@suse.de> <20071122024309.AD8E314D68@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071122024309.AD8E314D68@wotan.suse.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2172 Lines: 51 On Thu, Nov 22, 2007 at 03:43:09AM +0100, Andi Kleen wrote: > > Fix wrong format strings in modpost exposed by the previous patch. > Including one missing argument -- some random data was printed instead. Looks good. Can I get a s-o-b then I will apply it. Sam > > --- > scripts/mod/modpost.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > Index: linux/scripts/mod/modpost.c > =================================================================== > --- linux.orig/scripts/mod/modpost.c > +++ linux/scripts/mod/modpost.c > @@ -388,7 +388,7 @@ static int parse_elf(struct elf_info *in > > /* Check if file offset is correct */ > if (hdr->e_shoff > info->size) { > - fatal("section header offset=%u in file '%s' is bigger then filesize=%lu\n", hdr->e_shoff, filename, info->size); > + fatal("section header offset=%lu in file '%s' is bigger then filesize=%lu\n", (unsigned long)hdr->e_shoff, filename, info->size); > return 0; > } > > @@ -409,7 +409,7 @@ static int parse_elf(struct elf_info *in > const char *secname; > > if (sechdrs[i].sh_offset > info->size) { > - fatal("%s is truncated. sechdrs[i].sh_offset=%u > sizeof(*hrd)=%ul\n", filename, (unsigned int)sechdrs[i].sh_offset, sizeof(*hdr)); > + fatal("%s is truncated. sechdrs[i].sh_offset=%lu > sizeof(*hrd)=%lu\n", filename, (unsigned long)sechdrs[i].sh_offset, sizeof(*hdr)); > return 0; > } > secname = secstrings + sechdrs[i].sh_name; > @@ -907,7 +907,8 @@ static void warn_sec_mismatch(const char > "before '%s' (at offset -0x%llx)\n", > modname, fromsec, (unsigned long long)r.r_offset, > secname, refsymname, > - elf->strtab + after->st_name); > + elf->strtab + after->st_name, > + (unsigned long long)r.r_offset); > } else { > warn("%s(%s+0x%llx): Section mismatch: reference to %s:%s\n", > modname, fromsec, (unsigned long long)r.r_offset, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/