Received-SPF: pass (google.com: domain of linux-kernel+bounces-11738-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 27 Dec 2023 08:46:46 +0800
From: Baoquan He <bhe@redhat.com>
To: Youling Tang <youling.tang@outlook.com>, akpm@linux-foundation.org
Cc: Huacai Chen <chenhuacai@loongson.cn>, linux-kernel@vger.kernel.org,
	Youling Tang <tangyouling@kylinos.cn>
Subject: Re: [PATCH v2] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
Message-ID: <ZYtz9hyniU3Llqa0@MiWiFi-R3L-srv>
References: <MW4PR84MB3145459ADC7EB38BBB36955B8198A@MW4PR84MB3145.NAMPRD84.PROD.OUTLOOK.COM>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MW4PR84MB3145459ADC7EB38BBB36955B8198A@MW4PR84MB3145.NAMPRD84.PROD.OUTLOOK.COM>

On 12/27/23 at 07:46am, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
> 
> Remove duplicate definitions, no functional changes.
> 
> Reported-by: Huacai Chen <chenhuacai@loongson.cn>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> ---
>  include/linux/crash_core.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
> index 5126a4fecb44..9eaeaafe0cad 100644
> --- a/include/linux/crash_core.h
> +++ b/include/linux/crash_core.h
> @@ -87,12 +87,6 @@ Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
>  			  void *data, size_t data_len);
>  void final_note(Elf_Word *buf);
>  
> -#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> -#ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
> -#define DEFAULT_CRASH_KERNEL_LOW_SIZE  (128UL << 20)
> -#endif
> -#endif

Good catch, thx.

Acked-by: Baoquan He <bhe@redhat.com>

> -
>  int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
>  		unsigned long long *crash_size, unsigned long long *crash_base,
>  		unsigned long long *low_size, bool *high);
> -- 
> 2.40.0
>