Received-SPF: pass (google.com: domain of linux-kernel+bounces-11756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b42e66b0-58a1-4408-a3f6-bbbf5254e472@infradead.org>
Date: Tue, 26 Dec 2023 17:15:22 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] LoongArch: KVM: add a return kvm_own_lasx() stub
Content-Language: en-US
To: Huacai Chen <chenhuacai@kernel.org>
Cc: linux-kernel@vger.kernel.org, Bibo Mao <maobibo@loongson.cn>,
 Tianrui Zhao <zhaotianrui@loongson.cn>, Huacai Chen
 <chenhuacai@loongson.cn>, WANG Xuerui <kernel@xen0n.name>,
 kvm@vger.kernel.org, loongarch@lists.linux.dev,
 Stephen Rothwell <sfr@canb.auug.org.au>
References: <20231227010742.21539-1-rdunlap@infradead.org>
 <CAAhV-H4JVEa9hhD0WrDC0YA0Q55T3-SKQCHyxNm=KR3Tb_oeQA@mail.gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAAhV-H4JVEa9hhD0WrDC0YA0Q55T3-SKQCHyxNm=KR3Tb_oeQA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 12/26/23 17:11, Huacai Chen wrote:
> Hi, Randy,
> 
> Could you please fix kvm_own_lsx() together?
> 

Sure will. Thanks.

> Huacai
> 
> On Wed, Dec 27, 2023 at 9:07 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> The stub for kvm_own_lasx() when CONFIG_CPU_HAS_LASX is not defined
>> should have a return value since it returns an int, so add
>> "return -EINVAL;" to the stub. Fixes the build error:
>>
>> In file included from ../arch/loongarch/include/asm/kvm_csr.h:12,
>>                  from ../arch/loongarch/kvm/interrupt.c:8:
>> ../arch/loongarch/include/asm/kvm_vcpu.h: In function 'kvm_own_lasx':
>> ../arch/loongarch/include/asm/kvm_vcpu.h:73:39: error: no return statement in function returning non-void [-Werror=return-type]
>>    73 | static inline int kvm_own_lasx(struct kvm_vcpu *vcpu) { }
>>
>> Fixes: 118e10cd893d ("LoongArch: KVM: Add LASX (256bit SIMD) support")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Bibo Mao <maobibo@loongson.cn>
>> Cc: Tianrui Zhao <zhaotianrui@loongson.cn>
>> Cc: Huacai Chen <chenhuacai@loongson.cn>
>> Cc: WANG Xuerui <kernel@xen0n.name>
>> Cc: kvm@vger.kernel.org
>> Cc: loongarch@lists.linux.dev
>> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---


-- 
#Randy