Received-SPF: pass (google.com: domain of linux-kernel+bounces-11775-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 27 Dec 2023 09:30:29 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>,
	harry.wentland@amd.com, sunpeng.li@amd.com,
	Rodrigo.Siqueira@amd.com
Cc: Linux AMDGPU <amd-gfx@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Removing duplicate copyright text
Message-ID: <ZYuMRZU85plJiVWO@archie.me>
References: <20231226235741.4376-1-marcelomspessoto@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZGVgynaKhqIN2HVd"
Content-Disposition: inline
In-Reply-To: <20231226235741.4376-1-marcelomspessoto@gmail.com>


--ZGVgynaKhqIN2HVd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 26, 2023 at 08:57:41PM -0300, Marcelo Mendes Spessoto Junior wr=
ote:
> Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
>=20
> The file display/modules/inc/mod_freesync.h has two identical AMD
> Copyright texts. This simple patch aims to remove the duplicate one.

Hi Marcelo,

The patch subject should have a subsystem prefix (e.g. the full subject
should have been "[PATCH] drm/amdgpu: mod_freesync: Remove duplicate
copyright boilerplate").

For patch description, I'd like to write it as "mod_freesync header file
has duplicated copyright boilerplate. Drop the duplicate". And make
sure that your Signed-off-by: trailer is on the bottom of description,
before triple dashes (`git commit -s` does it for you).

>=20
> ---
>  .../amd/display/modules/inc/mod_freesync.h    | 28 -------------------
>  1 file changed, 28 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h b/dri=
vers/gpu/drm/amd/display/modules/inc/mod_freesync.h
> index afe1f6cce..cc3dc9b58 100644
> --- a/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h
> +++ b/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h
> @@ -1,31 +1,3 @@
> -/*
> - * Copyright 2016 Advanced Micro Devices, Inc.
> - *
> - * Permission is hereby granted, free of charge, to any person obtaining=
 a
> - * copy of this software and associated documentation files (the "Softwa=
re"),
> - * to deal in the Software without restriction, including without limita=
tion
> - * the rights to use, copy, modify, merge, publish, distribute, sublicen=
se,
> - * and/or sell copies of the Software, and to permit persons to whom the
> - * Software is furnished to do so, subject to the following conditions:
> - *
> - * The above copyright notice and this permission notice shall be includ=
ed in
> - * all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE=
SS OR
> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI=
TY,
> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SH=
ALL
> - * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES=
 OR
> - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> - * OTHER DEALINGS IN THE SOFTWARE.
> - *
> - * Authors: AMD
> - *
> - */
> -
> -
> -
> -
>  /*
>   * Copyright 2016 Advanced Micro Devices, Inc.
>   *

The diff itself LGTM.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--ZGVgynaKhqIN2HVd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZYuMQgAKCRD2uYlJVVFO
o0qFAP48gatzxW12gHZZvhcbCTjbLWlzeSScerZ+QyttfS1K4QEAxEaqJj86R9nS
X7dnpFXXjKu+pZ+rN8LzhrBwEQgndQk=
=xonQ
-----END PGP SIGNATURE-----

--ZGVgynaKhqIN2HVd--