Received-SPF: pass (google.com: domain of linux-kernel+bounces-11874-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20231226100431.331616-1-qiujingbao.dlmu@gmail.com>
 <20231226100431.331616-2-qiujingbao.dlmu@gmail.com> <170359073827.2315471.1581188151554847748.robh@kernel.org>
In-Reply-To: <170359073827.2315471.1581188151554847748.robh@kernel.org>
From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Date: Wed, 27 Dec 2023 15:05:38 +0800
Message-ID: <CAJRtX8Q+OJ1wZPkbDiySfdzTc6uDQT_8PZGJmxSbO95tUhcNDw@mail.gmail.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: sophgo: add MFD subsys support
 for Sophgo CV1800 series SoC
To: Rob Herring <robh@kernel.org>
Cc: inochiama@outlook.com, aou@eecs.berkeley.edu, conor@kernel.org, 
	linux-rtc@vger.kernel.org, chao.wei@sophgo.com, 
	krzysztof.kozlowski+dt@linaro.org, unicorn_wang@outlook.com, 
	linux-kernel@vger.kernel.org, palmer@dabbelt.com, conor+dt@kernel.org, 
	a.zummo@towertech.it, dlan@gentoo.org, paul.walmsley@sifive.com, 
	alexandre.belloni@bootlin.com, robh+dt@kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 26, 2023 at 7:39=E2=80=AFPM Rob Herring <robh@kernel.org> wrote=
:
>
>
> On Tue, 26 Dec 2023 18:04:28 +0800, Jingbao Qiu wrote:
> > Add devicetree binding for Sophgo CV1800 SoC MFD subsys.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> > ---
> >  .../bindings/mfd/sophgo,cv1800-subsys.yaml    | 51 +++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/sophgo,cv1800=
-subsys.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>

I'm sorry for that. My current patch depends on a CLK patch that has
not been merged yet.
So should I wait for the clk patch to merge before submitting?
the depends patch link:
https://lore.kernel.org/all/IA1PR20MB49539CDAD9A268CBF6CA184BBB9FA@IA1PR20M=
B4953.namprd20.prod.outlook.com/

> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/m=
fd/sophgo,cv1800-subsys.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/rt=
c/sophgo,cv1800-rtc.yaml
> Documentation/devicetree/bindings/mfd/sophgo,cv1800-subsys.example.dts:25=
:18: fatal error: dt-bindings/clock/sophgo,cv1800.h: No such file or direct=
ory
>    25 |         #include <dt-bindings/clock/sophgo,cv1800.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings=
/mfd/sophgo,cv1800-subsys.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_bin=
ding_check] Error 2
> make: *** [Makefile:234: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202312=
26100431.331616-2-qiujingbao.dlmu@gmail.com
>
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your sch=
ema.
>

Best regards,
Jingbao Qiu