Received-SPF: pass (google.com: domain of linux-kernel+bounces-11878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 27 Dec 2023 09:11:35 +0200
From: Petre Rodan <petre.rodan@subdimension.ro>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andreas Klinger <ak@it-klinger.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 01/10] dt-bindings: iio: pressure:
 honeywell,mprls0025pa.yaml fix
Message-ID: <ZYvOJ9tlO1fp_QBT@sunspire>
References: <20231224143500.10940-1-petre.rodan@subdimension.ro>
 <20231224143500.10940-2-petre.rodan@subdimension.ro>
 <20231226162839.5ceddc9e@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="gXDyfpoylppolFU2"
Content-Disposition: inline
In-Reply-To: <20231226162839.5ceddc9e@jic23-huawei>


--gXDyfpoylppolFU2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Hello Cameron,

On Tue, Dec 26, 2023 at 04:28:39PM +0000, Jonathan Cameron wrote:
> On Sun, 24 Dec 2023 16:34:46 +0200
> Petre Rodan <petre.rodan@subdimension.ro> wrote:
>=20
> > Define enum inside the honeywell,transfer-function property block.
> >=20
> > Set the correct irq edge in the example block.
> > Based on the datasheet, in table 13 on page 11:
> > "End-of-conversion indicator: This pin is set high when a measurement
> > and calculation have been completed and the data is ready to be
> > clocked out"
> >=20
> > Add description on End-of-conversion interrupt.
> >=20
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> What's the relationship between Andreas and this patch?
>=20
> Petre seems to have sent it so either Andreas should have a Co-authored-b=
y or
> should be the author... Or not there at all

Andreas has written this driver as it is in the mainline tree right now and=
 he
is marked as a maintainer for it.
A month back I told him about the enum off-by-one problem and also about my=
 plan
of adding more features to the driver.
He was happy to accept my code and once I sent v1 of this patch to the list=
 has
asked to work together for the v2 you see here. This has helped with cleani=
ng up
the code. He requested the additional 'Signed-off-by' tag, but if you have =
a more
explicit one I will happily use it. 'Co-developed-by' it is.

He also owns an i2c version of the sensor so he was able to make sure that =
the
original half of the driver still works after my refactor, hence the 'Teste=
d-by'
tag in the last patch.

please tell me how do the 'fixes'/feature/improvement tags/keywords look li=
ke?
are these to be added on the subject line, or should they reside near my
'Signed-off-by' inside the email body? I probably missed the documentation =
where
these are covered :)

also, should I add a 'Reviewed-by:' you for 09/10 and 10/10 (the last two p=
atches)?

best regards,
peter

--gXDyfpoylppolFU2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE2Ap/wXYVGTXsPl+pzyaZmYROfzAFAmWLzh8ACgkQzyaZmYRO
fzBpxg//ekA/5x6UzTA8o9Ujo78/i0MRMxc5zWYkHfpJLuVweN6FNqIOSN9Ang3e
qRkZT39HmeLL8FzxchjHr/tgUTaejMM6iltdsnKvukPxGzdkkSKfEqEka0KgbljO
2CPy6UJEzUx5XSEONeL7no6nLHvTsjCPXE1W4UBPTIoIr5oNA5wuokW0VD3+lg+u
DOXh2RFK/+oIp1HXnYpO+8q23dVBMFRZtuiJLqy83uUTlz7aeuCUG/7MYWPqOhSO
cIH2CtYpX7MjUxGvqdbRDAY17wid4qJ3yOOD1+MDxe362Ldp93piwNT752ORuh/x
UGNZ8B87v6iIdUimEtEcLWfsg+AP6xEJvXD+7gsG0lhazz90/36RHmSZcn/asgSD
f1bBY6P8Iry0vgnqPQej0K/7OBDb0TuesHxuZ9oXDFAtAjuV+Xwcoq4swouPpO4Z
cbxGPpyyTfkKtYJVwIo13pHY1g5JtxOfsWm2pBpatCxr0RDk2+zAkufUiZ6pbYTQ
tsotCSfGt4+qvpBb87SMPEAsg6+MxoOV2r4DWCy3VgiNXaUGim0o2bLA2lNQX/q5
RsA09oToLJ5fUdX+Lrc9oBqK4kHZL4A06jYwWMXhJTfp7NkwFjJ1S6MwVqfO202o
JgiXoUibcQpLTYh1AV7GeXAW69zZKjdxy/CfG3ZzitSPbhwLXSM=
=Otfh
-----END PGP SIGNATURE-----

--gXDyfpoylppolFU2--