Received-SPF: pass (google.com: domain of linux-kernel+bounces-11951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231225080608.967953-1-chancel.liu@nxp.com>
In-Reply-To: <20231225080608.967953-1-chancel.liu@nxp.com>
From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: Wed, 27 Dec 2023 18:13:51 +0800
Message-ID: <CAA+D8APY3KL6+7kpeqGLm-n_gLTLHOWvMoEZxhrRH2X+9O1d-w@mail.gmail.com>
Subject: Re: [PATCH] ASoC: fsl_rpmsg: Fix error handler with pm_runtime_enable
To: Chancel Liu <chancel.liu@nxp.com>
Cc: Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, 
	lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, 
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, 
	linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 25, 2023 at 4:06=E2=80=AFPM Chancel Liu <chancel.liu@nxp.com> w=
rote:
>
> There is error message when defer probe happens:
>
> fsl_rpmsg rpmsg_audio: Unbalanced pm_runtime_enable!
>
> Fix the error handler with pm_runtime_enable.
>
> Fixes: b73d9e6225e8 ("ASoC: fsl_rpmsg: Add CPU DAI driver for audio base =
on rpmsg")
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
wang shengjiu
> ---
>  sound/soc/fsl/fsl_rpmsg.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_rpmsg.c b/sound/soc/fsl/fsl_rpmsg.c
> index 5c5c04ce9db7..00852f174a69 100644
> --- a/sound/soc/fsl/fsl_rpmsg.c
> +++ b/sound/soc/fsl/fsl_rpmsg.c
> @@ -238,7 +238,7 @@ static int fsl_rpmsg_probe(struct platform_device *pd=
ev)
>         ret =3D devm_snd_soc_register_component(&pdev->dev, &fsl_componen=
t,
>                                               &fsl_rpmsg_dai, 1);
>         if (ret)
> -               return ret;
> +               goto err_pm_disable;
>
>         rpmsg->card_pdev =3D platform_device_register_data(&pdev->dev,
>                                                          "imx-audio-rpmsg=
",
> @@ -248,16 +248,22 @@ static int fsl_rpmsg_probe(struct platform_device *=
pdev)
>         if (IS_ERR(rpmsg->card_pdev)) {
>                 dev_err(&pdev->dev, "failed to register rpmsg card\n");
>                 ret =3D PTR_ERR(rpmsg->card_pdev);
> -               return ret;
> +               goto err_pm_disable;
>         }
>
>         return 0;
> +
> +err_pm_disable:
> +       pm_runtime_disable(&pdev->dev);
> +       return ret;
>  }
>
>  static void fsl_rpmsg_remove(struct platform_device *pdev)
>  {
>         struct fsl_rpmsg *rpmsg =3D platform_get_drvdata(pdev);
>
> +       pm_runtime_disable(&pdev->dev);
> +
>         if (rpmsg->card_pdev)
>                 platform_device_unregister(rpmsg->card_pdev);
>  }
> --
> 2.42.0
>