Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3320339rdb; Wed, 27 Dec 2023 03:54:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEs5kgRCjKas9WxNU7SsCFlMjQqEA8i/jnDdp7jg/HFRTqY+H/jODjXa2TmPXqbRDaHu8Xg X-Received: by 2002:a05:620a:988:b0:781:5693:867f with SMTP id x8-20020a05620a098800b007815693867fmr2627724qkx.117.1703678099102; Wed, 27 Dec 2023 03:54:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703678099; cv=none; d=google.com; s=arc-20160816; b=NxTdWKNoZGZ5vIvpZuiQpeTa2tVoRvwdIAYa1gvnJJ65Az8RaUuNdK6KSQK1ILlhqG UDLqaQU8jJEP4UU6gibEa8u53nG10DfVx1HrolRTVtBPv5iCILme7QX/VQuRbb7hkbY9 rD5OAJw5RhTP4drzDPt0RIQFwU1YRfgP4S5FiG5QPKshMCQulHM348ZvZz5gOhuhhfbR IMYqDJ8Aqtx+TM7pJJ8Nfd5iq7y4c2y/vee8VcchYjnYXrCWltfvq/Y/V1iJ9/EYs8PC muoYiR+8qaIiZqf/DIR5D8+UOvPFUFkN4kEqDI61/eZFZdlUulOQ0OZjkPG/tG1G7Wvg QMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=0rYgu3SiCaq7hrmRY3ZPE+6M1nIV7bD+FPdYLtShoxI=; fh=v7Dp+aeLAz0gl9hbtCAucqiioHUutjmysTt5BUH4i3g=; b=Dr1n5IFGEspuxKnJmubT0Jd0zGAE1VtRhWZUo6QSM6NH95uoR9E7cRBJ7C5u4jKrCE zdl+Aqv7emplDvqTEGTXYpS3UpN5dBRYj+KrLbqTbKQSgTjJcZfQO9n8CSZZRhg2PVzY NsN4YreLbmVj1MGh81cv6dqlzsVYkt6b4vrMZrlzpKCf+03QWm2GJV0RtLSUoxM5JHyb 3uLf3SufyrrMWQcJ/toWiCR2MM1//2ZrBkB3CXzIO3YCKeod+/8pgNgTPS6QsEb4+6zH tz1Rfw3cCbt/AwL3iFT1KW5XNLPrXqExo3ylwpa3mCAcSGgfoJdW4XQKY1MI3s6aEbYk bzFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oMgwFwVS; spf=pass (google.com: domain of linux-kernel+bounces-12000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12000-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id vu28-20020a05620a561c00b00781330cafb3si9726541qkn.25.2023.12.27.03.54.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 03:54:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oMgwFwVS; spf=pass (google.com: domain of linux-kernel+bounces-12000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12000-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C67401C20B72 for ; Wed, 27 Dec 2023 11:54:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7201D446C0; Wed, 27 Dec 2023 11:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oMgwFwVS" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34FB544C62 for ; Wed, 27 Dec 2023 11:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-33674f60184so5257476f8f.1 for ; Wed, 27 Dec 2023 03:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703678086; x=1704282886; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0rYgu3SiCaq7hrmRY3ZPE+6M1nIV7bD+FPdYLtShoxI=; b=oMgwFwVS3KRWfiSHUWID6yrD72UYZpzCJ9RuLzP/UQrH8nzZpJCWYONXjDsXDwUmD1 FgQURwQOLlRvSup2pbVDIT3MI894pGqS7ikz/219rJJTwmwBDTZZbnZGO3/Q4hrSLtBG 3aM4Pnny6f3m2aOTIgxxX2RxYRN2tMv8PEYM3F5EU6PWSL52C5JLphxB6NdNhyMtdBX4 8FdSSubehAmezSOPo7ZCveeJCFy53wI4QU+fajrq8ijtezuxilOZ8bd8PLJymOmBQP+K Fu2UDRyIh03CKwHRwHbztMrdPOBvzXK0FpWCb7uTO6zAauxfYuaRIcnte5EBDcAKhXEe 8TUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703678086; x=1704282886; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0rYgu3SiCaq7hrmRY3ZPE+6M1nIV7bD+FPdYLtShoxI=; b=U2TgPZ4RPzOivV7hqQ0CmNl7V3TepxzY2Qqijo1UrWkIboX+sLDoLT7y/2d6mO2yMJ hIKhIRPo8t8tNIndjWUV1/fh7N6jcCbOAc1HiURaPNrhcQ7LF2ADyK3Aqb+/PGcWbWdR DfiUcu/5yIHscQz5FIeH7LGTKYd4bMm9lnuCBfFV82a1dvuXO0t9ad7lh4ettddLACg/ uNVa+V2nLggiKz5PAKj3Wx0lRb/1W1DJNqml/xpHuKXM2fXs+8H7nxCXeoWo/2MPQ/ko FCwXJYHLJwWgViDohszsVjujJJ2bbEEFhT6gDZ7M5duhG0eHzbVRrDMH0p8Aj3xVpngy pb6g== X-Gm-Message-State: AOJu0YwhQdxE8CPk4R1QOkJwDQYKFNhM95vkqiKpCokuR2zV/zYpH+aE CYUB6UPY3n4HtZd/ARnH/d00lETGnscs9T4fDKDlVGSU+EUfCg== X-Received: by 2002:a5d:4c8d:0:b0:336:5dfb:201f with SMTP id z13-20020a5d4c8d000000b003365dfb201fmr4955982wrs.34.1703678086535; Wed, 27 Dec 2023 03:54:46 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id a15-20020adfed0f000000b00336673a4153sm14617023wro.80.2023.12.27.03.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 03:54:46 -0800 (PST) Message-ID: <103c1d8c-314a-457e-884d-6ad67fe65e62@linaro.org> Date: Wed, 27 Dec 2023 12:54:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/24] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source Content-Language: en-US To: Mark Hasemeyer , LKML Cc: AngeloGioacchino Del Regno , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20231226192149.1830592-1-markhas@chromium.org> <20231226122113.v3.7.I06b059021de1bf6103e60a73211f078f2af75d17@changeid> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231226122113.v3.7.I06b059021de1bf6103e60a73211f078f2af75d17@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/12/2023 20:21, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. > > Some Chromebooks use a separate wake pin, while others overload the > interrupt for wake and IO. With the current assumption, spurious wakes > can occur on systems that use a separate wake pin. It is planned to > update the driver to no longer assume that the EC interrupt pin should > be enabled for wake. > > Add the wakeup-source property to all cros-ec-spi compatible device > nodes to signify to the driver that they should still be a valid wakeup > source. > > -Commit-changes: 3 This looks like changelog, although a bit confusing. If it is changelog, then please keep it under ---. I can fix it while applying, but this will be after the merge window. Best regards, Krzysztof