Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3414218rdb; Wed, 27 Dec 2023 06:50:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHe7BCVhvdBR2MnIacBokBeNJlK1/qOjVQ8q2Ko9a7giQ785YR/eWLcHGxP5TEGsIrLTaui X-Received: by 2002:a17:90b:4aca:b0:28c:1161:5205 with SMTP id mh10-20020a17090b4aca00b0028c11615205mr3759409pjb.85.1703688644964; Wed, 27 Dec 2023 06:50:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703688644; cv=none; d=google.com; s=arc-20160816; b=hFck9ilX+km526XHwyJDJhH53BU8TMuLcQiAaAXMnt7UgG40YQdkPR5A11KW21tfIQ g/cykZ8uaoosVo5ZTXEnJAVO6Fr3VSMWJ6rn7nI1ENdgL6Dwuhzhu/jhnxzSMJSm0Fhr HWLXlhIFRHjjS0jLoQhbDD4me+i3p7YUJvRQyAVkqvaf5/IPJMUxi7vA2w0k4rlFm9Nr dx6T5SyikuWN1rEY31K6hf/PP1+VECGrwyCFJ0YbYWRee6ndd6Kmgc5VoRyx8k/CuIky 4kKQnEw1cxcRd8YMLFp+TcJVvnVPvrWXMr58vpiImmzMDhHofpXMTNHH2DknOY/rc/GD ynxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Ykeys9/b81hQucL41oKnYrH4NAgYOfGtA2bT2pIxo5Q=; fh=nCHpoOmZzPFKkYnjB6DcQplzE6zNssY94haDgAefa7c=; b=KXKCtsz0nUJKUL2ZU38y2AnK9OI3b1CyLMf/lgg6biVM8UiHApc/USLxxn970xSaSa YS5Ap0EASofn00a5Z7qgqLLpyHj0eVECAXIzk3YFXcTcRNKmcqWBVwUFn4YxB4po3iM9 sn98eM8EaD3aIEIPxE1BTNpWTW6Uy4NCSpeYwDg37ALZHb5dhIWi907r6Lqpr6tNMhdr P1Gq2RVzfEEiZVmXecSGDNVkJjeie7SdR842hIPmlUmj4oXYnLo9pKQ9p6m23UAoFBrb yRl4zb+EMeLcvXGkZQvseMLksy81jPYFAR9Ne3rPIqaptPAuOuko3r9pfD7r203TI/bw P78w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="NN/5vIBk"; spf=pass (google.com: domain of linux-kernel+bounces-12064-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s7-20020a17090b070700b0028b2b3d252csi11106777pjz.29.2023.12.27.06.50.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 06:50:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12064-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="NN/5vIBk"; spf=pass (google.com: domain of linux-kernel+bounces-12064-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 66B84281F4C for ; Wed, 27 Dec 2023 14:50:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C90574653A; Wed, 27 Dec 2023 14:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NN/5vIBk" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF70A4645C for ; Wed, 27 Dec 2023 14:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d3ea5cc137so41536835ad.0 for ; Wed, 27 Dec 2023 06:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703688598; x=1704293398; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ykeys9/b81hQucL41oKnYrH4NAgYOfGtA2bT2pIxo5Q=; b=NN/5vIBkuMEgYFRUg56ViHsz6i0CXAPj1jkWMWTSuL+MVuBz6am6ZAV3e7oJvLaErg i2ewoS4ZxSnC+Y0Wu3u1SSLWJVOokwbXmpWwjEjaP5Jo+Ktx4X9NYOcINEf4XRF69Vtk W1Z2c0acQF3t0I+/oF39onoQCFIxp3DSCuyVk/pppKBQi/v3pyxMD5FNmmhMPe6U+2wY xMAjioZHWbXo7QYk8y+ru/xjshGkCFLhdrAFlrtMxUDMpyBdo/cV6bz5n3PW5Bwng86A 4ZxoCAsNKf+Wrm18b/cELUJCvw/KsPhEGbe0iIIOdjmNOICuQ0j+o9K/tmWNhicocZpW 23kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703688598; x=1704293398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ykeys9/b81hQucL41oKnYrH4NAgYOfGtA2bT2pIxo5Q=; b=LjBA3gYQfVdhc+IZjMsDlNIPLSW6mmAGAEiXiTPUgGrmOeDmW4yUY3062nyhV6bgYk d2kvjcggSewtlYXFIPrbNWDSRGPwBDXQ/FjwuKXXFag8E5pdFqNqsKQlGj4c+QX5Q3vB tiRVUcY0PfqYTBopNMp50Sk4JEd7B3/fDMOJUf+pKNf791ybk8ZDSKAyCFkjBR+7glf+ ZZEjHOJMl+/y8VjTo6JZgSWQ79subfMDDsHJ197UoN8y+Rec/OB21NgI3/vOQTjAclDW KW0b1Cc5tY2ag3gRvvw3113AWR6+TIpTvn9LiBO/p6JnQ+gIIHdj5iNTN+D1nNuIjXrR Un1Q== X-Gm-Message-State: AOJu0YxRxQk0w9i9aDSBVg5W+st+yLBACHjavbBEXyjAgitgeYu/Y70c 0MD3u1oBuYHlYZbaxZ++V8ldL++DJqQ= X-Received: by 2002:a17:902:ec92:b0:1d0:6ffe:9f5 with SMTP id x18-20020a170902ec9200b001d06ffe09f5mr8166768plg.83.1703688597875; Wed, 27 Dec 2023 06:49:57 -0800 (PST) Received: from localhost ([47.89.225.180]) by smtp.gmail.com with ESMTPSA id x22-20020a170902821600b001cfc1b931a9sm11995380pln.249.2023.12.27.06.49.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2023 06:49:57 -0800 (PST) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: Tejun Heo , Naohiro.Aota@wdc.com, Lai Jiangshan , Lai Jiangshan Subject: [PATCH 4/7] workqueue: Wrap common code into wq_adjust_pwqs_max_active() Date: Wed, 27 Dec 2023 22:51:40 +0800 Message-Id: <20231227145143.2399-5-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20231227145143.2399-1-jiangshanlai@gmail.com> References: <20231227145143.2399-1-jiangshanlai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lai Jiangshan There are 3 places using the same code, so wrap them into a common helper. Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 37 +++++++++++++++---------------------- 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 3347ba3a734f..e0101b2b5fa3 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -4190,6 +4190,16 @@ static void pwq_adjust_max_active(struct pool_workqueue *pwq) raw_spin_unlock_irqrestore(&pwq->pool->lock, flags); } +static void wq_adjust_pwqs_max_active(struct workqueue_struct *wq) +{ + struct pool_workqueue *pwq; + + mutex_lock(&wq->mutex); + for_each_pwq(pwq, wq) + pwq_adjust_max_active(pwq); + mutex_unlock(&wq->mutex); +} + /* initialize newly allocated @pwq which is associated with @wq and @pool */ static void init_pwq(struct pool_workqueue *pwq, struct workqueue_struct *wq, struct worker_pool *pool) @@ -4700,7 +4710,6 @@ struct workqueue_struct *alloc_workqueue(const char *fmt, { va_list args; struct workqueue_struct *wq; - struct pool_workqueue *pwq; /* * Unbound && max_active == 1 used to imply ordered, which is no longer @@ -4761,14 +4770,8 @@ struct workqueue_struct *alloc_workqueue(const char *fmt, * list. */ mutex_lock(&wq_pool_mutex); - - mutex_lock(&wq->mutex); - for_each_pwq(pwq, wq) - pwq_adjust_max_active(pwq); - mutex_unlock(&wq->mutex); - + wq_adjust_pwqs_max_active(wq); list_add_tail_rcu(&wq->list, &workqueues); - mutex_unlock(&wq_pool_mutex); return wq; @@ -5698,19 +5701,14 @@ EXPORT_SYMBOL_GPL(work_on_cpu_safe_key); void freeze_workqueues_begin(void) { struct workqueue_struct *wq; - struct pool_workqueue *pwq; mutex_lock(&wq_pool_mutex); WARN_ON_ONCE(workqueue_freezing); workqueue_freezing = true; - list_for_each_entry(wq, &workqueues, list) { - mutex_lock(&wq->mutex); - for_each_pwq(pwq, wq) - pwq_adjust_max_active(pwq); - mutex_unlock(&wq->mutex); - } + list_for_each_entry(wq, &workqueues, list) + wq_adjust_pwqs_max_active(wq); mutex_unlock(&wq_pool_mutex); } @@ -5773,7 +5771,6 @@ bool freeze_workqueues_busy(void) void thaw_workqueues(void) { struct workqueue_struct *wq; - struct pool_workqueue *pwq; mutex_lock(&wq_pool_mutex); @@ -5783,12 +5780,8 @@ void thaw_workqueues(void) workqueue_freezing = false; /* restore max_active and repopulate worklist */ - list_for_each_entry(wq, &workqueues, list) { - mutex_lock(&wq->mutex); - for_each_pwq(pwq, wq) - pwq_adjust_max_active(pwq); - mutex_unlock(&wq->mutex); - } + list_for_each_entry(wq, &workqueues, list) + wq_adjust_pwqs_max_active(wq); out_unlock: mutex_unlock(&wq_pool_mutex); -- 2.19.1.6.gb485710b