Received-SPF: pass (google.com: domain of linux-kernel+bounces-12089-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 27 Dec 2023 15:46:41 +0000
From: Greg KH <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Hou Tao <houtao@huaweicloud.com>, bpf@vger.kernel.org,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Alexei Starovoitov <ast@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	David Vernet <void@manifault.com>, Jiri Kosina <jikos@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: HID: bpf: One function call less in call_hid_bpf_rdesc_fixup()
 after error detection
Message-ID: <2023122719-stunt-duration-9504@gregkh>
References: <3203eb44-6e69-4bda-b585-426408cb75ee@web.de>
 <618f886f-b2ff-4d50-cf74-e8478a7e8547@huaweicloud.com>
 <b75d66cc-a507-432a-af60-655950671b8a@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b75d66cc-a507-432a-af60-655950671b8a@web.de>

On Wed, Dec 27, 2023 at 09:19:27AM +0100, Markus Elfring wrote:
> >> The kfree() function was called in one case by the
> >> call_hid_bpf_rdesc_fixup() function during error handling
> >> even if the passed data structure member contained a null pointer.
> >> This issue was detected by using the Coccinelle software.
> >
> > It is totally OK to free a null pointer through kfree() and the ENOMEM
> > case is an unlikely case, so I don't think the patch is necessary.
> 
> Would you ever like to avoid redundant data processing a bit more?


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot